From: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>, igt-dev@lists.freedesktop.org
Cc: Intel-gfx@lists.freedesktop.org,
Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Subject: Re: [igt-dev] [PATCH i-g-t 04/15] gem_wsim: Engine map load balance command
Date: Thu, 23 May 2019 14:58:00 +0100 [thread overview]
Message-ID: <3dd08b76-88f4-634c-29b9-8e0b6ae03188@linux.intel.com> (raw)
In-Reply-To: <155861794842.28319.15632127961597355104@skylake-alporthouse-com>
On 23/05/2019 14:25, Chris Wilson wrote:
> Quoting Tvrtko Ursulin (2019-05-22 16:57:09)
>> From: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
>>
>> A new workload command for enabling a load balanced context map (aka
>> Virtual Engine). Example usage:
>>
>> B.1
>>
>> This turns on load balancing for context one, assuming it has already been
>> configured with an engine map. Only DEFAULT engine specifier can be used
>> with load balanced engine maps.
>>
>> v2:
>> * Lift restriction to only use load balancer when enabled in context map.
>> (Chris)
>
> You didn't fancy going all out and say:
> B.1.DEFAULT.VCS1|VCS2
> ?
>
> If you are happy with the current code, it looks to do what you want,
> Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
Thanks, I wouldn't say I am happy as in really proud of it happy. But as
a tool by hackers for hackers, which grew organically always as a second
priority thing, it seems to work for now and is able to exercise the new
uAPI and scheduling paths.
So there is scope to tidy, and will certainly need more work in the
future (not least per engine calibration), but I need to call it done
for a while at some reasonable point and it feels like that should be now.
Proof in the pudding is that I think you found it useful when
benchmarking the semaphore code and related issues. So it at least
continues providing the same simulated workloads over the new uAPI.
Regards,
Tvrtko
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
next prev parent reply other threads:[~2019-05-23 13:58 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-22 15:57 [igt-dev] [PATCH i-g-t 00/15] Remaining bits of Virtual Engine tooling Tvrtko Ursulin
2019-05-22 15:57 ` [igt-dev] [PATCH i-g-t 01/15] gem_wsim: Engine map support Tvrtko Ursulin
2019-05-23 13:23 ` [igt-dev] [Intel-gfx] " Chris Wilson
2019-05-22 15:57 ` [igt-dev] [PATCH i-g-t 02/15] gem_wsim: Save some lines by changing to implicit NULL checking Tvrtko Ursulin
2019-05-22 15:57 ` [igt-dev] [PATCH i-g-t 03/15] gem_wsim: Compact int command parsing with a macro Tvrtko Ursulin
2019-05-22 15:57 ` [igt-dev] [PATCH i-g-t 04/15] gem_wsim: Engine map load balance command Tvrtko Ursulin
2019-05-23 13:25 ` Chris Wilson
2019-05-23 13:58 ` Tvrtko Ursulin [this message]
2019-05-22 15:57 ` [Intel-gfx] [PATCH i-g-t 05/15] gem_wsim: Engine bond command Tvrtko Ursulin
2019-05-22 15:57 ` [Intel-gfx] [PATCH i-g-t 06/15] gem_wsim: Some more example workloads Tvrtko Ursulin
2019-05-22 15:57 ` [igt-dev] [PATCH i-g-t 07/15] gem_wsim: Infinite batch support Tvrtko Ursulin
2019-05-23 14:05 ` Chris Wilson
2019-05-23 14:09 ` Chris Wilson
2019-05-23 14:17 ` Tvrtko Ursulin
2019-05-22 15:57 ` [igt-dev] [PATCH i-g-t 08/15] gem_wsim: Command line switch for specifying low slice count workloads Tvrtko Ursulin
2019-05-22 15:57 ` [igt-dev] [PATCH i-g-t 09/15] gem_wsim: Per context SSEU control Tvrtko Ursulin
2019-05-22 15:57 ` [igt-dev] [PATCH i-g-t 10/15] gem_wsim: Allow RCS virtual engine with " Tvrtko Ursulin
2019-05-22 15:57 ` [igt-dev] [PATCH i-g-t 11/15] gem_wsim: Consolidate engine assignments into helpers Tvrtko Ursulin
2019-05-23 13:26 ` Chris Wilson
2019-05-22 15:57 ` [igt-dev] [PATCH i-g-t 12/15] gem_wsim: Discover engines Tvrtko Ursulin
2019-05-22 15:57 ` [igt-dev] [PATCH i-g-t 13/15] gem_wsim: Support Icelake parts Tvrtko Ursulin
2019-05-22 15:57 ` [igt-dev] [PATCH i-g-t 14/15] gem_wsim: Fix prng usage Tvrtko Ursulin
2019-05-22 16:51 ` Chris Wilson
2019-05-22 15:57 ` [Intel-gfx] [PATCH i-g-t 15/15] gem_wsim: Allow random seed control Tvrtko Ursulin
2019-05-22 16:52 ` [igt-dev] " Chris Wilson
2019-05-22 17:21 ` [igt-dev] ✓ Fi.CI.BAT: success for Remaining bits of Virtual Engine tooling Patchwork
2019-05-23 14:15 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3dd08b76-88f4-634c-29b9-8e0b6ae03188@linux.intel.com \
--to=tvrtko.ursulin@linux.intel.com \
--cc=Intel-gfx@lists.freedesktop.org \
--cc=chris@chris-wilson.co.uk \
--cc=igt-dev@lists.freedesktop.org \
--cc=tvrtko.ursulin@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox