From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.24]) by gabe.freedesktop.org (Postfix) with ESMTPS id BA69010E03B for ; Mon, 14 Aug 2023 10:20:16 +0000 (UTC) Message-ID: <3e0c48cb-e6f1-c756-a028-71bf607a8a9a@intel.com> Date: Mon, 14 Aug 2023 15:50:11 +0530 MIME-Version: 1.0 Content-Language: en-US To: Bhanuprakash Modem , igt-dev@lists.freedesktop.org References: <20230811184655.157060-1-bhanuprakash.modem@intel.com> <20230811184655.157060-60-bhanuprakash.modem@intel.com> From: "Sharma, Swati2" In-Reply-To: <20230811184655.157060-60-bhanuprakash.modem@intel.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [igt-dev] [i-g-t V6 59/81] tests/kms_plane_alpha_blend: Document each subtest for testplan List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" List-ID: LGTM Reviewed-by: Swati Sharma On 12-Aug-23 12:16 AM, Bhanuprakash Modem wrote: > Add documentation for all kms tests which is used by IGT testplan > documentation. > > Signed-off-by: Bhanuprakash Modem > --- > tests/kms_plane_alpha_blend.c | 55 +++++++++++++++++++++++++++++++++++ > 1 file changed, 55 insertions(+) > > diff --git a/tests/kms_plane_alpha_blend.c b/tests/kms_plane_alpha_blend.c > index 341b85c7e..d139f2367 100644 > --- a/tests/kms_plane_alpha_blend.c > +++ b/tests/kms_plane_alpha_blend.c > @@ -24,6 +24,11 @@ > * Maarten Lankhorst > */ > > +/** > + * TEST: kms plane alpha blend > + * Category: Display > + * Description: Test plane alpha and blending mode properties > + */ > #include "igt.h" > > IGT_TEST_DESCRIPTION("Test plane alpha and blending mode properties"); > @@ -477,6 +482,56 @@ static void coverage_premult_constant(data_t *data, enum pipe pipe, igt_plane_t > igt_pipe_crc_stop(data->pipe_crc); > } > > +/** > + * SUBTEST: alpha-%s > + * Description: Test to %arg[1] > + * Driver requirement: any > + * Functionality: plane > + * Mega feature: General Display Features > + * Run type: FULL > + * Test category: functionality test > + * > + * arg[1]: > + * > + * @7efc: validate alpha values 0x7e and 0xfc are swappable on > + * pre-multiplied blend mode. > + * @basic: basic plane alpha properties. > + * @opaque-fb: alpha properties with opaque fb. > + * @transparent-fb: alpha property with transparent fb. > + */ > + > +/** > + * SUBTEST: coverage-vs-premult-vs-constant > + * Description: Tests pipe coverage blending properties. > + * Driver requirement: any > + * Functionality: plane > + * Mega feature: General Display Features > + * Run type: FULL > + * Test category: functionality test > + * > + * SUBTEST: coverage-7efc > + * Description: Uses alpha values 0x7e and 0xfc to validate fg.alpha and > + * plane_alpha are swappable on coverage blend mode. > + * Driver requirement: any > + * Functionality: plane > + * Mega feature: General Display Features > + * Run type: FULL > + * Test category: functionality test > + * > + * SUBTEST: constant-alpha-%s > + * Description: Tests plane alpha and blending properties with %arg[1]. > + * Driver requirement: any > + * Functionality: plane > + * Mega feature: General Display Features > + * Run type: FULL > + * Test category: functionality test > + * > + * arg[1]: > + * > + * @max: maximum alpha value > + * @mid: medium alpha value > + * @min: minimum alpha value > + */ > static void run_test_on_pipe_planes(data_t *data, enum pipe pipe, igt_output_t *output, > bool blend, bool must_multiply, > void(*test)(data_t *, enum pipe, igt_plane_t *))