From: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>, intel-gfx@lists.freedesktop.org
Cc: igt-dev@lists.freedesktop.org
Subject: Re: [igt-dev] [PATCH i-g-t] i915/gem_mocs_settings: Identify Cometlake
Date: Tue, 23 Jul 2019 13:47:53 +0100 [thread overview]
Message-ID: <3e0c81d7-dc9a-a6f5-ae3e-d077348862f3@linux.intel.com> (raw)
In-Reply-To: <20190723114709.26886-1-chris@chris-wilson.co.uk>
On 23/07/2019 12:47, Chris Wilson wrote:
> Cometlake is yet another Skylake refresh and used the same mocs
> registers.
>
> Bugzilla: https://bugzilla.freedesktop.org/show_bug.cgi?id=111137
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
> ---
> lib/intel_chipset.h | 3 ++-
> tests/i915/gem_mocs_settings.c | 2 +-
> 2 files changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/lib/intel_chipset.h b/lib/intel_chipset.h
> index 781486d02..2bd57f4f0 100644
> --- a/lib/intel_chipset.h
> +++ b/lib/intel_chipset.h
> @@ -162,11 +162,12 @@ void intel_check_pch(void);
> #define IS_HASWELL(devid) (intel_get_device_info(devid)->is_haswell)
> #define IS_BROADWELL(devid) (intel_get_device_info(devid)->is_broadwell)
> #define IS_CHERRYVIEW(devid) (intel_get_device_info(devid)->is_cherryview)
> -#define IS_KABYLAKE(devid) (intel_get_device_info(devid)->is_kabylake)
> #define IS_SKYLAKE(devid) (intel_get_device_info(devid)->is_skylake)
> #define IS_BROXTON(devid) (intel_get_device_info(devid)->is_broxton)
> +#define IS_KABYLAKE(devid) (intel_get_device_info(devid)->is_kabylake)
> #define IS_GEMINILAKE(devid) (intel_get_device_info(devid)->is_geminilake)
> #define IS_COFFEELAKE(devid) (intel_get_device_info(devid)->is_coffeelake)
> +#define IS_COMETLAKE(devid) (intel_get_device_info(devid)->is_cometlake)
> #define IS_CANNONLAKE(devid) (intel_get_device_info(devid)->is_cannonlake)
> #define IS_ICELAKE(devid) (intel_get_device_info(devid)->is_icelake)
> #define IS_TIGERLAKE(devid) (intel_get_device_info(devid)->is_tigerlake)
> diff --git a/tests/i915/gem_mocs_settings.c b/tests/i915/gem_mocs_settings.c
> index 1a311b8c0..f3ee8a7bc 100644
> --- a/tests/i915/gem_mocs_settings.c
> +++ b/tests/i915/gem_mocs_settings.c
> @@ -137,7 +137,7 @@ static bool get_mocs_settings(int fd, struct mocs_table *table, bool dirty)
> uint32_t devid = intel_get_drm_devid(fd);
> bool result = false;
>
> - if (IS_SKYLAKE(devid) || IS_KABYLAKE(devid)) {
> + if (IS_SKYLAKE(devid) || IS_KABYLAKE(devid) || IS_COMETLAKE(devid)) {
> if (dirty) {
> table->size = ARRAY_SIZE(dirty_skylake_mocs_table);
> table->table = dirty_skylake_mocs_table;
>
Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Regards,
Tvrtko
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
next prev parent reply other threads:[~2019-07-23 12:47 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-23 11:47 [igt-dev] [PATCH i-g-t] i915/gem_mocs_settings: Identify Cometlake Chris Wilson
2019-07-23 12:13 ` [igt-dev] ✗ GitLab.Pipeline: warning for " Patchwork
2019-07-23 12:28 ` [igt-dev] ✓ Fi.CI.BAT: success " Patchwork
2019-07-23 12:47 ` Tvrtko Ursulin [this message]
2019-07-23 15:54 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3e0c81d7-dc9a-a6f5-ae3e-d077348862f3@linux.intel.com \
--to=tvrtko.ursulin@linux.intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=igt-dev@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox