From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by gabe.freedesktop.org (Postfix) with ESMTPS id 539646E8BD for ; Fri, 29 Mar 2019 11:36:20 +0000 (UTC) References: <20190328192206.1591-1-andi.shyti@intel.com> <20190328192206.1591-3-andi.shyti@intel.com> From: Tvrtko Ursulin Message-ID: <3e55d5c5-957f-5937-6af3-3da9ae72fd74@linux.intel.com> Date: Fri, 29 Mar 2019 11:36:17 +0000 MIME-Version: 1.0 In-Reply-To: <20190328192206.1591-3-andi.shyti@intel.com> Content-Language: en-US Subject: Re: [igt-dev] [PATCH v16 2/8] lib: ioctl_wrappers: reach engines by index as well List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" To: Andi Shyti , IGT dev Cc: Andi Shyti List-ID: Ck9uIDI4LzAzLzIwMTkgMTk6MjIsIEFuZGkgU2h5dGkgd3JvdGU6Cj4gV2l0aCB0aGUgbmV3IGVu Z2luZSBxdWVyeSBtZXRob2QgZW5naW5lcyBhcmUgcmVhY2hhYmxlIHRocm91Z2gKPiBhbiBpbmRl eCBhbmQgY29udGV4dCB0aGV5IGFyZSBjb21iaW5lZCB3aXRoLgo+IAo+IFRoZSAnZ2VtX2hhc19y aW5nKCknIGJlY29tZXMgJ2dlbV9jb250ZXh0X2hhc19lbmdpbmUoKScgdGhhdAo+IHJlcXVpcmVz IHRoZSBpbmRleCB0aGF0IHRoZSBlbmdpbmUgaXMgbWFwcGVkIHdpdGhpbiB0aGUgZHJpdmVyLgo+ IFRoZSBmdW5jdGlvbiBoYXMgYmVlbiBtb3ZlZCBmcm9tIGxpYi9pb2N0bF93YXBwZXJzIHRvCj4g bGliL2k5MTUvZ2VtX2NvbnRleHQgd2hlcmUgaXQgaXMgbW9yZSBhcHByb3ByaWF0ZS4KPiAKPiBU aGUgcHJldmlvdXMgJ2dlbV9oYXNfcmluZygpJyBmdW5jdGlvbiBiZWNvbWVzIGEgd3JhcHBlciB0 byB0aGUKPiBuZXcgJ2dlbV9jb250ZXh0X2hhc19lbmdpbmUoKScuCj4gCj4gU2lnbmVkLW9mZi1i eTogQW5kaSBTaHl0aSA8YW5kaS5zaHl0aUBpbnRlbC5jb20+Cj4gUmV2aWV3ZWQtYnk6IENocmlz IFdpbHNvbiA8Y2hyaXNAY2hyaXMtd2lsc29uLmNvLnVrPgo+IC0tLQo+ICAgbGliL2k5MTUvZ2Vt X2NvbnRleHQuYyB8IDI4ICsrKysrKysrKysrKysrKysrKysrKysrKysrKysKPiAgIGxpYi9pOTE1 L2dlbV9jb250ZXh0LmggfCAgMiArKwo+ICAgbGliL2lvY3RsX3dyYXBwZXJzLmMgICB8IDE5IC0t LS0tLS0tLS0tLS0tLS0tLS0KPiAgIGxpYi9pb2N0bF93cmFwcGVycy5oICAgfCAgMyArKy0KPiAg IDQgZmlsZXMgY2hhbmdlZCwgMzIgaW5zZXJ0aW9ucygrKSwgMjAgZGVsZXRpb25zKC0pCj4gCj4g ZGlmZiAtLWdpdCBhL2xpYi9pOTE1L2dlbV9jb250ZXh0LmMgYi9saWIvaTkxNS9nZW1fY29udGV4 dC5jCj4gaW5kZXggOGI0ZDViNzA0NjUwLi43MzJmNjZiNDI3M2UgMTAwNjQ0Cj4gLS0tIGEvbGli L2k5MTUvZ2VtX2NvbnRleHQuYwo+ICsrKyBiL2xpYi9pOTE1L2dlbV9jb250ZXh0LmMKPiBAQCAt MjcxLDMgKzI3MSwzMSBAQCB2b2lkIGdlbV9jb250ZXh0X3NldF9wcmlvcml0eShpbnQgZmQsIHVp bnQzMl90IGN0eF9pZCwgaW50IHByaW8pCj4gICB7Cj4gICAJaWd0X2Fzc2VydF9lcShfX2dlbV9j b250ZXh0X3NldF9wcmlvcml0eShmZCwgY3R4X2lkLCBwcmlvKSwgMCk7Cj4gICB9Cj4gKwo+ICti b29sIGdlbV9jb250ZXh0X2hhc19lbmdpbmUoaW50IGZkLCB1aW50NjRfdCBjdHgsIHVpbnQ2NF90 IGVuZ2luZSkKPiArewo+ICsJc3RydWN0IGRybV9pOTE1X2dlbV9leGVjYnVmZmVyMiBleGVjYnVm Owo+ICsJc3RydWN0IGRybV9pOTE1X2dlbV9leGVjX29iamVjdDIgZXhlYzsKPiArCj4gKwkvKgo+ ICsJICogJ2VuZ2luZScgdmFsdWUgY2FuIGVpdGhlciBzdG9yZSBhbiBleGVjYnVmIGVuZ2luZSBz ZWxlY3Rvcgo+ICsJICogb3IgYSBjb250ZXh0IG1hcCBpbmRleDsgZm9yIHRoZSBsYXR0ZXIgY2Fz ZSB3ZSBkbyBub3QgZXhwZWN0Cj4gKwkgKiB0byBoYXZlIGFueSB2YWx1ZSBhdCBiaXQgMTMgYW5k IDE0IChCU0QxLzIgc2VsZWN0b3IpLAo+ICsJICogdGhlcmVmb3JlLCB3ZSBhc3N1bWUgdGhhdCB0 aGUgZm9sbG93aW5nIGNoZWNrIGlzIHNhZmUgaXQgd291bGRuJ3QKPiArCSAqIHByb2R1Y2UgYW55 IHJlc3VsdCBhbmQgd2UgZG9uJ3QgZXhlcGN0IGFueXdheSB0byBoYXZlIG1vcmUgdGhhbgo+ICsJ ICogb25lIGVuZ2luZSBtYXBwZWQgaW4gJ3VuaXQ2NF90IGVuZ2luZScuCgp0eXBvIGluIGV4cGVj dCBhbmQgdWludC4KCkkgdGhpbmsgaGVyZSB5b3UgbWVhbnQgdGhhdCB3ZSBkb24ndCBleHBlY3Qg bW9yZSB0aGFuICgxIDw8IDEzIC0gMSkgZW5naW5lcz8KCj4gKwkgKi8KPiArCWlmICgoZW5naW5l ICYgfigzPDwxMykpID09IEk5MTVfRVhFQ19CU0QpIHsKPiArCQlpZiAoZW5naW5lICYgKDMgPDwg MTMpICYmICFnZW1faGFzX2JzZDIoZmQpKQo+ICsJCQlyZXR1cm4gZmFsc2U7Cj4gKwl9Cj4gKwo+ ICsJbWVtc2V0KCZleGVjLCAwLCBzaXplb2YoZXhlYykpOwo+ICsJbWVtc2V0KCZleGVjYnVmLCAw LCBzaXplb2YoZXhlY2J1ZikpOwo+ICsJZXhlY2J1Zi5idWZmZXJzX3B0ciA9IHRvX3VzZXJfcG9p bnRlcigmZXhlYyk7Cj4gKwlleGVjYnVmLmJ1ZmZlcl9jb3VudCA9IDE7Cj4gKwlleGVjYnVmLmZs YWdzID0gZW5naW5lOwo+ICsJZXhlY2J1Zi5yc3ZkMSA9IGN0eDsKPiArCj4gKwlyZXR1cm4gX19n ZW1fZXhlY2J1ZihmZCwgJmV4ZWNidWYpID09IC1FTk9FTlQ7Cj4gK30KPiBkaWZmIC0tZ2l0IGEv bGliL2k5MTUvZ2VtX2NvbnRleHQuaCBiL2xpYi9pOTE1L2dlbV9jb250ZXh0LmgKPiBpbmRleCBh ZWY2OGRkYTZiMjYuLmQ0ZThmZWMzYWNmMCAxMDA2NDQKPiAtLS0gYS9saWIvaTkxNS9nZW1fY29u dGV4dC5oCj4gKysrIGIvbGliL2k5MTUvZ2VtX2NvbnRleHQuaAo+IEBAIC00NSw0ICs0NSw2IEBA IGludCBfX2dlbV9jb250ZXh0X2dldF9wYXJhbShpbnQgZmQsIHN0cnVjdCBkcm1faTkxNV9nZW1f Y29udGV4dF9wYXJhbSAqcCk7Cj4gICBpbnQgX19nZW1fY29udGV4dF9zZXRfcHJpb3JpdHkoaW50 IGZkLCB1aW50MzJfdCBjdHgsIGludCBwcmlvKTsKPiAgIHZvaWQgZ2VtX2NvbnRleHRfc2V0X3By aW9yaXR5KGludCBmZCwgdWludDMyX3QgY3R4LCBpbnQgcHJpbyk7Cj4gICAKPiArYm9vbCBnZW1f Y29udGV4dF9oYXNfZW5naW5lKGludCBmZCwgdWludDY0X3QgY3R4LCB1aW50NjRfdCBlbmdpbmUp Owo+ICsKPiAgICNlbmRpZiAvKiBHRU1fQ09OVEVYVF9IICovCj4gZGlmZiAtLWdpdCBhL2xpYi9p b2N0bF93cmFwcGVycy5jIGIvbGliL2lvY3RsX3dyYXBwZXJzLmMKPiBpbmRleCBhNjZlYjRiYzBm NGYuLjNmOGYwODc0YmM0YiAxMDA2NDQKPiAtLS0gYS9saWIvaW9jdGxfd3JhcHBlcnMuYwo+ICsr KyBiL2xpYi9pb2N0bF93cmFwcGVycy5jCj4gQEAgLTEyNTMsMjUgKzEyNTMsNiBAQCB2b2lkIGln dF9yZXF1aXJlX2dlbShpbnQgZmQpCj4gICAJaWd0X3JlcXVpcmVfZihlcnIgPT0gMCwgIlVucmVz cG9uc2l2ZSBpOTE1L0dFTSBkZXZpY2VcbiIpOwo+ICAgfQo+ICAgCj4gLWJvb2wgZ2VtX2hhc19y aW5nKGludCBmZCwgdW5zaWduZWQgcmluZykKPiAtewo+IC0Jc3RydWN0IGRybV9pOTE1X2dlbV9l eGVjYnVmZmVyMiBleGVjYnVmOwo+IC0Jc3RydWN0IGRybV9pOTE1X2dlbV9leGVjX29iamVjdDIg ZXhlYzsKPiAtCj4gLQkvKiBzaWxseSBBQkksIHRoZSBrZXJuZWwgdGhpbmtzIGV2ZXJ5b25lIHdo byBoYXMgQlNEIGFsc28gaGFzIEJTRDIgKi8KPiAtCWlmICgocmluZyAmIH4oMzw8MTMpKSA9PSBJ OTE1X0VYRUNfQlNEKSB7Cj4gLQkJaWYgKHJpbmcgJiAoMyA8PCAxMykgJiYgIWdlbV9oYXNfYnNk MihmZCkpCj4gLQkJCXJldHVybiBmYWxzZTsKPiAtCX0KPiAtCj4gLQltZW1zZXQoJmV4ZWMsIDAs IHNpemVvZihleGVjKSk7Cj4gLQltZW1zZXQoJmV4ZWNidWYsIDAsIHNpemVvZihleGVjYnVmKSk7 Cj4gLQlleGVjYnVmLmJ1ZmZlcnNfcHRyID0gdG9fdXNlcl9wb2ludGVyKCZleGVjKTsKPiAtCWV4 ZWNidWYuYnVmZmVyX2NvdW50ID0gMTsKPiAtCWV4ZWNidWYuZmxhZ3MgPSByaW5nOwo+IC0JcmV0 dXJuIF9fZ2VtX2V4ZWNidWYoZmQsICZleGVjYnVmKSA9PSAtRU5PRU5UOwo+IC19Cj4gLQo+ICAg LyoqCj4gICAgKiBnZW1fcmVxdWlyZV9yaW5nOgo+ICAgICogQGZkOiBvcGVuIGk5MTUgZHJtIGZp bGUgZGVzY3JpcHRvcgo+IGRpZmYgLS1naXQgYS9saWIvaW9jdGxfd3JhcHBlcnMuaCBiL2xpYi9p b2N0bF93cmFwcGVycy5oCj4gaW5kZXggYWQ5M2RhZmZjZmQ1Li5lNzEyZjE5NzMxNDIgMTAwNjQ0 Cj4gLS0tIGEvbGliL2lvY3RsX3dyYXBwZXJzLmgKPiArKysgYi9saWIvaW9jdGxfd3JhcHBlcnMu aAo+IEBAIC0xNDIsMTEgKzE0MiwxMiBAQCBib29sIGdlbV9oYXNfZXhlY19mZW5jZShpbnQgZmQp Owo+ICAgCj4gICAvKiBjaGVjayBmdW5jdGlvbnMgd2hpY2ggYXV0by1za2lwIHRlc3RzIGJ5IGNh bGxpbmcgaWd0X3NraXAoKSAqLwo+ICAgdm9pZCBnZW1fcmVxdWlyZV9jYWNoaW5nKGludCBmZCk7 Cj4gLWJvb2wgZ2VtX2hhc19yaW5nKGludCBmZCwgdW5zaWduZWQgcmluZyk7Cj4gICB2b2lkIGdl bV9yZXF1aXJlX3JpbmcoaW50IGZkLCB1bnNpZ25lZCByaW5nKTsKPiAgIGJvb2wgZ2VtX2hhc19t b2NzX3JlZ2lzdGVycyhpbnQgZmQpOwo+ICAgdm9pZCBnZW1fcmVxdWlyZV9tb2NzX3JlZ2lzdGVy cyhpbnQgZmQpOwo+ICAgCj4gKyNkZWZpbmUgZ2VtX2hhc19yaW5nKGYsIHIpIGdlbV9jb250ZXh0 X2hhc19lbmdpbmUoZiwgMCwgcikKPiArCj4gICAvKiBwcmltZSAqLwo+ICAgc3RydWN0IGxvY2Fs X2RtYV9idWZfc3luYyB7Cj4gICAJdWludDY0X3QgZmxhZ3M7Cj4gCgpXaXRoIHRoZSBjb21tZW50 IHRpZGllZDoKClJldmlld2VkLWJ5OiBUdnJ0a28gVXJzdWxpbiA8dHZydGtvLnVyc3VsaW5AaW50 ZWwuY29tPgoKUmVnYXJkcywKClR2cnRrbwpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fXwppZ3QtZGV2IG1haWxpbmcgbGlzdAppZ3QtZGV2QGxpc3RzLmZyZWVk ZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZv L2lndC1kZXY=