Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: "Joshi, Kunal1" <kunal1.joshi@intel.com>
To: "B S, Karthik" <karthik.b.s@intel.com>,
	"igt-dev@lists.freedesktop.org" <igt-dev@lists.freedesktop.org>
Subject: Re: [igt-dev] [PATCH 1/3] tests/intel-ci: Added chamelium config blacklist
Date: Thu, 20 Jul 2023 04:54:14 +0000	[thread overview]
Message-ID: <3f5448e0-c129-435b-21e8-27b95696212a@intel.com> (raw)
In-Reply-To: <8fc0dc67-d19a-99e6-90b6-9e884179be62@intel.com>

Thanks karthik for reviewing.

Will do suggested changes before merging

On 7/20/2023 10:20 AM, Karthik B S wrote:
> Hi,
>
> Please update the subject to say "non-chamelium" config blacklist. 
> Feels a little misleading currently.
>
> On 7/19/2023 12:39 PM, Kunal Joshi wrote:
>> blacklist for non chamelium config
>
> Please add details as to where/why this will be used.
>
> With these updates to the commit message, the patch LGTM.
>
> Reviewed-by: Karthik B S <karthik.b.s@intel.com>
>

Thanks Karthik for reviewing.

Will do suggested changes for both pathces before merging

Regards

Kunal Joshi


  reply	other threads:[~2023-07-20  4:54 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-07-19  7:09 [igt-dev] [PATCH 0/3] Add seperate blacklist for specific config Kunal Joshi
2023-07-19  7:09 ` [igt-dev] [PATCH 1/3] tests/intel-ci: Added chamelium config blacklist Kunal Joshi
2023-07-20  4:50   ` Karthik B S
2023-07-20  4:54     ` Joshi, Kunal1 [this message]
2023-07-19  7:09 ` [igt-dev] [PATCH 2/3] tests/intel-ci: Added psr " Kunal Joshi
2023-07-20  4:53   ` Karthik B S
2023-07-19  7:09 ` [igt-dev] [PATCH 3/3] tests/intel-ci: added blacklist to meson.build Kunal Joshi
2023-07-20  4:56   ` Karthik B S
2023-07-19  8:08 ` [igt-dev] ○ CI.xeBAT: info for Add seperate blacklist for specific config (rev2) Patchwork
2023-07-19  8:19 ` [igt-dev] ✗ Fi.CI.BAT: failure " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3f5448e0-c129-435b-21e8-27b95696212a@intel.com \
    --to=kunal1.joshi@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=karthik.b.s@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox