Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Karthik B S <karthik.b.s@intel.com>
To: Kamil Konieczny <kamil.konieczny@linux.intel.com>,
	<igt-dev@lists.freedesktop.org>, <kamil.konieczny@intel.com>,
	<jari.tahvanainen@intel.com>
Subject: Re: [PATCH i-g-t v2] scripts/test_list: Do not stop the build process if documantion fails
Date: Tue, 25 Mar 2025 13:52:42 +0530	[thread overview]
Message-ID: <4008a7da-a901-4bc7-a600-5e56100c27e9@intel.com> (raw)
In-Reply-To: <20250321185002.73kzuscjdahh37fe@kamilkon-desk.igk.intel.com>

Hi Kamil,

On 3/22/2025 12:20 AM, Kamil Konieczny wrote:
> Hi Karthik,
> On 2025-03-20 at 19:35:08 +0530, Karthik B S wrote:
>
> small nit in subject:
>
>> Do not stop the build process if documantion fails
> -----------------------------------^^^^^^^^^^^
> s/documantion/documentation/
>
> What about also shortening it a bit?
>
> scripts/test_list: Do not stop the build if documentation fails

Thank you for the feedback.

Will make these changes and merge this.

Thanks,
Karthik.B.S
>
> Regards,
> Kamil
>
>> Current approach stops whole build process on a case that there is mistake
>> on documentation. Let's have entry on logs instead and continue.
>>
>> Small fix also related multiline data e.g. on Description part.
>>
>> Signed-off-by: Jari Tahvanainen <jari.tahvanainen@intel.com>
>> Signed-off-by: Karthik B S <karthik.b.s@intel.com>
>> Reviewed-by: Kamil Konieczny <kamil.konieczny@linux.intel.com>
>> ---
>>   scripts/test_list.py | 6 +++---
>>   1 file changed, 3 insertions(+), 3 deletions(-)
>>
>> diff --git a/scripts/test_list.py b/scripts/test_list.py
>> index 867d28400..5f1b4218b 100644
>> --- a/scripts/test_list.py
>> +++ b/scripts/test_list.py
>> @@ -1399,7 +1399,7 @@ class TestList:
>>   
>>                   # Handle multi-line field contents
>>                   if current_field:
>> -                    match = re.match(r'\s+(.*)', file_line)
>> +                    match = re.match(r'(.*)', file_line)
>>                       if match:
>>                           if handle_section == 'test':
>>                               dic = self.doc[current_test]
>> @@ -1408,7 +1408,7 @@ class TestList:
>>   
>>                           if dic[current_field] != '':
>>                               dic[current_field] += " "
>> -                        dic[current_field] += match.group(1)
>> +                        dic[current_field] += match.group(1).strip()
>>                           continue
>>   
>>                   # Handle multi-line argument contents
>> @@ -1427,7 +1427,7 @@ class TestList:
>>                       continue
>>   
>>                   file_line.rstrip(r"\n")
>> -                sys.exit(f"{fname}:{file_ln + 1}: Error: unrecognized line. Need to add field at %s?\n\t==> %s" %
>> +                printf(f"{fname}:{file_ln + 1}: Warning: unrecognized line. Need to add field at %s?\n\t==> %s" %
>>                            (config_origin, file_line))
>>   
>>       def show_subtests(self, sort_field):
>> -- 
>> 2.43.0
>>

      reply	other threads:[~2025-03-25  8:22 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-03-20 14:05 [PATCH i-g-t v2] scripts/test_list: Do not stop the build process if documantion fails Karthik B S
2025-03-20 14:27 ` ✓ Xe.CI.BAT: success for " Patchwork
2025-03-20 14:47 ` ✓ i915.CI.BAT: " Patchwork
2025-03-20 15:09 ` ✗ Xe.CI.Full: failure " Patchwork
2025-03-20 16:19 ` ✗ i915.CI.Full: " Patchwork
2025-03-25  8:25   ` Karthik B S
2025-03-21 18:50 ` [PATCH i-g-t v2] " Kamil Konieczny
2025-03-25  8:22   ` Karthik B S [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4008a7da-a901-4bc7-a600-5e56100c27e9@intel.com \
    --to=karthik.b.s@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=jari.tahvanainen@intel.com \
    --cc=kamil.konieczny@intel.com \
    --cc=kamil.konieczny@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox