public inbox for igt-dev@lists.freedesktop.org
 help / color / mirror / Atom feed
From: "Kahola, Mika" <mika.kahola@intel.com>
To: "Latvala, Petri" <petri.latvala@intel.com>
Cc: "igt-dev@lists.freedesktop.org" <igt-dev@lists.freedesktop.org>
Subject: Re: [igt-dev] [PATCH i-g-t v2] tests/kms_concurrent: Move bandwidth calculation to igt_fixture
Date: Mon, 30 Mar 2020 12:11:48 +0000	[thread overview]
Message-ID: <40bcde68191c447699061d60f4760302@intel.com> (raw)
In-Reply-To: <20200330114038.GE9497@platvala-desk.ger.corp.intel.com>



-----Original Message-----
From: Latvala, Petri <petri.latvala@intel.com> 
Sent: Monday, March 30, 2020 2:41 PM
To: Kahola, Mika <mika.kahola@intel.com>
Cc: igt-dev@lists.freedesktop.org; juhapekka.heikkila@gmail.com; Lisovskiy, Stanislav <stanislav.lisovskiy@intel.com>
Subject: Re: [PATCH i-g-t v2] tests/kms_concurrent: Move bandwidth calculation to igt_fixture

On Mon, Mar 30, 2020 at 01:06:40PM +0300, Kahola, Mika wrote:
> I noticed that pipe B was failing with other platforms as well, not 
> just with HSW. Bandwidth calculation within fixture fixed the other 
> platforms that was failing as well as my local HSW machine. I think it 
> is unnecessary to calculate bandwidth for older platforms. We have 
> seen these issues only with gen11+.

I mean what was the crashing operation and the reason that was reached? Dividing by zero? Buffer overflow when reading because some array index was too big?

I was thinking that we iterate usually only once and the whole idea of the test is to draw planes and concurrently switch resolutions from higher to lower and back. Maybe we just need to keep child process running while switching resolution? I tested this with a patch that increased to number of child process iterations to 5 instead of 1. Let's see, what CI thinks about this idea. 

Anyway, I need to run these tests in CI  as I cannot produce these errors locally on HSW that shows problematic behavior.

--
Petri Latvala
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

  reply	other threads:[~2020-03-30 12:11 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-30  8:17 [igt-dev] [PATCH i-g-t v2] tests/kms_concurrent: Move bandwidth calculation to igt_fixture Mika Kahola
2020-03-30  8:52 ` [igt-dev] ✓ Fi.CI.BAT: success for tests/kms_concurrent: Move bandwidth calculation to igt_fixture (rev3) Patchwork
2020-03-30  9:07 ` [igt-dev] [PATCH i-g-t v2] tests/kms_concurrent: Move bandwidth calculation to igt_fixture Petri Latvala
2020-03-30 10:06   ` Kahola, Mika
2020-03-30 11:40     ` Petri Latvala
2020-03-30 12:11       ` Kahola, Mika [this message]
2020-03-30  9:59 ` [igt-dev] ✗ Fi.CI.IGT: failure for tests/kms_concurrent: Move bandwidth calculation to igt_fixture (rev3) Patchwork
2020-03-30 10:29   ` Kahola, Mika

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=40bcde68191c447699061d60f4760302@intel.com \
    --to=mika.kahola@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=petri.latvala@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox