From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ed1-x536.google.com (mail-ed1-x536.google.com [IPv6:2a00:1450:4864:20::536]) by gabe.freedesktop.org (Postfix) with ESMTPS id B93D810E225 for ; Mon, 21 Aug 2023 10:06:23 +0000 (UTC) Received: by mail-ed1-x536.google.com with SMTP id 4fb4d7f45d1cf-52a06f5f556so1239136a12.2 for ; Mon, 21 Aug 2023 03:06:23 -0700 (PDT) Message-ID: <40d121ba-eca6-0438-bf04-00f6a31be591@gmail.com> Date: Mon, 21 Aug 2023 13:06:17 +0300 MIME-Version: 1.0 Content-Language: en-US To: =?UTF-8?Q?Jouni_H=c3=b6gander?= , igt-dev@lists.freedesktop.org References: <20230818080827.1889393-1-jouni.hogander@intel.com> From: Juha-Pekka Heikkila In-Reply-To: <20230818080827.1889393-1-jouni.hogander@intel.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Subject: Re: [igt-dev] [PATCH i-g-t] tests/i915: Take into account fbc_status "stolen memory not initialised" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: juhapekka.heikkila@gmail.com Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" List-ID: Reviewed-by: Juha-Pekka Heikkila On 18.8.2023 11.08, Jouni Högander wrote: > Earlier non initialized memory caused fbc_status debugfs interface not > being created at all. This was considered as "Unsupported chipset" by > certain igt testcases. Now fbc_status is informing "stolen memory not > initialised". Consider this again as "Unsupported chipset" > > Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/9131 > Signed-off-by: Jouni Högander > --- > tests/i915/kms_fbcon_fbt.c | 3 ++- > tests/i915/kms_frontbuffer_tracking.c | 3 ++- > 2 files changed, 4 insertions(+), 2 deletions(-) > > diff --git a/tests/i915/kms_fbcon_fbt.c b/tests/i915/kms_fbcon_fbt.c > index e65cbda93..2cb0ffdb4 100644 > --- a/tests/i915/kms_fbcon_fbt.c > +++ b/tests/i915/kms_fbcon_fbt.c > @@ -103,7 +103,8 @@ static bool fbc_supported_on_chipset(int device, int debugfs_fd) > if (ret < 0) > return false; > > - return !strstr(buf, "FBC unsupported on this chipset\n"); > + return !strstr(buf, "FBC unsupported on this chipset\n") && > + !strstr(buf, "stolen memory not initialised\n"); > } > > static bool connector_can_fbc(drmModeConnectorPtr connector) > diff --git a/tests/i915/kms_frontbuffer_tracking.c b/tests/i915/kms_frontbuffer_tracking.c > index 3e8f15bb0..136426204 100644 > --- a/tests/i915/kms_frontbuffer_tracking.c > +++ b/tests/i915/kms_frontbuffer_tracking.c > @@ -1444,7 +1444,8 @@ static bool fbc_supported_on_chipset(void) > if (*buf == '\0') > return false; > > - return !strstr(buf, "FBC unsupported on this chipset\n"); > + return !strstr(buf, "FBC unsupported on this chipset\n") && > + !strstr(buf, "stolen memory not initialised\n"); > } > > static void setup_fbc(void)