From: Alex Hung <alex.hung@amd.com>
To: "vitaly prosyak" <vprosyak@amd.com>,
"André Almeida" <andrealmeid@igalia.com>,
"Kamil Konieczny" <kamil.konieczny@linux.intel.com>,
igt-dev@lists.freedesktop.org,
"Vitaly Prosyak" <vitaly.prosyak@amd.com>,
"Jeevan B" <jeevan.b@intel.com>,
kernel-dev@igalia.com, "Harry Wentland" <harry.wentland@amd.com>
Subject: Re: [PATCH v2] tests/kms_async_flips: Create subtest for overlay planes
Date: Tue, 25 Feb 2025 12:06:08 -0700 [thread overview]
Message-ID: <41966687-e25e-42eb-a6b3-fba5d6c85e16@amd.com> (raw)
In-Reply-To: <a8fc5cef-5ccf-486d-b401-f587e500746d@amd.com>
On 2/25/25 08:51, vitaly prosyak wrote:
> Hi Andre,
>
> Apologies for the delay.
>
> On 2025-02-25 10:42, André Almeida wrote:
>> Hey Vitaly,
>>
>> Em 19/02/2025 15:06, vitaly prosyak escreveu:
>>> Added Harry and Alex
>>>
>>> Hi Kamll
>>>
>>> Thanks for the letting us know.
>>>
>>> On 2025-02-19 05:37, Kamil Konieczny wrote:
>>>> Hi André,
>>>> On 2024-12-16 at 17:24:27 -0300, André Almeida wrote:
>>>>> amdgpu can perform async flips in overlay planes as well, so create a
>>>>> test for that.
>>>>>
>>>> Vitaly could you find someone from AMD who could help with
>>>> review and testing? Thanks!
>>> Alex,
>>>
>>> Can you help with DAL CI to run this patch ?
>>> Thanks in advance
>>>
>> Did you managed to get this running in the CI?
> I currently don't have access to DAL CI.
>
> I've reached out to Alex again via Teams and will keep you updated.
>
> Thanks, Vitaly
We don't have a CI to test individual IGT patches so I tested this patch
on an APU and dGPU with kms_async_flips
== APU ===
...
Starting subtest: overlay-atomic
Starting dynamic subtest: pipe-A-eDP-1
Dynamic subtest pipe-A-eDP-1: SUCCESS (2.773s)
Starting dynamic subtest: pipe-B-eDP-1
Dynamic subtest pipe-B-eDP-1: SUCCESS (2.772s)
Starting dynamic subtest: pipe-C-eDP-1
Dynamic subtest pipe-C-eDP-1: SUCCESS (2.772s)
Starting dynamic subtest: pipe-D-eDP-1
Dynamic subtest pipe-D-eDP-1: SUCCESS (2.772s)
Subtest overlay-atomic: SUCCESS (13.686s)
...
=== dGPU ===
...
Starting subtest: overlay-atomic
Starting dynamic subtest: pipe-A-DP-1
Dynamic subtest pipe-A-DP-1: SUCCESS (2.160s)
Starting dynamic subtest: pipe-B-DP-1
Dynamic subtest pipe-B-DP-1: SUCCESS (2.160s)
Starting dynamic subtest: pipe-C-DP-1
Dynamic subtest pipe-C-DP-1: SUCCESS (2.160s)
Starting dynamic subtest: pipe-D-DP-1
Dynamic subtest pipe-D-DP-1: SUCCESS (2.160s)
Starting dynamic subtest: pipe-E-DP-1
Dynamic subtest pipe-E-DP-1: SUCCESS (2.160s)
Starting dynamic subtest: pipe-F-DP-1
Dynamic subtest pipe-F-DP-1: SUCCESS (2.159s)
Subtest overlay-atomic: SUCCESS (13.952s)
...
If I run overlay-atomic alone (i.e., --run-subtest overlay-atomic),
overlay-atomic fails as below (partial outputs only). Is this an
expected result? Does overlay-atomic need to run along with other subtests?
IGT-Version: 1.30-g8fee6d12c (x86_64) (Linux: 6.11.0-18-generic x86_64)
Using IGT_SRANDOM=1740510058 for randomisation
Opened device: /dev/dri/card1
Starting subtest: overlay-atomic
Starting dynamic subtest: pipe-A-DP-1
(kms_async_flips:3180096) CRITICAL: Test assertion failure function
test_async_flip, file ../tests/kms_async_flips.c:361:
(kms_async_flips:3180096) CRITICAL: Failed assertion: ret == 0
(kms_async_flips:3180096) CRITICAL: Last errno: 22, Invalid argument
(kms_async_flips:3180096) CRITICAL: error: -22 != 0
Stack trace:
Dynamic subtest pipe-A-DP-1 failed.
**** DEBUG ****
(kms_async_flips:3180096) DEBUG: Test requirement passed:
!(is_joiner_mode(data->drm_fd, data->output))
(kms_async_flips:3180096) igt_fb-DEBUG:
igt_create_fb_with_bo_size(width=3440, height=1440,
format=XR24(0x34325258), modifier=0x0, size=0)
(kms_async_flips:3180096) igt_fb-DEBUG:
igt_create_fb_with_bo_size(handle=1, pitch=13824)
(kms_async_flips:3180096) ioctl_wrappers-DEBUG: Test requirement passed:
igt_has_fb_modifiers(fd)
(kms_async_flips:3180096) igt_fb-DEBUG: Test requirement passed:
cairo_surface_status(fb->cairo_surface) == CAIRO_STATUS_SUCCESS
(kms_async_flips:3180096) igt_fb-DEBUG: Test requirement passed:
cairo_surface_status(fb->cairo_surface) == CAIRO_STATUS_SUCCESS
(kms_async_flips:3180096) igt_fb-DEBUG:
igt_create_fb_with_bo_size(width=3440, height=1440,
format=XR24(0x34325258), modifier=0x0, size=0)
(kms_async_flips:3180096) igt_fb-DEBUG:
igt_create_fb_with_bo_size(handle=2, pitch=13824)
(kms_async_flips:3180096) ioctl_wrappers-DEBUG: Test requirement passed:
igt_has_fb_modifiers(fd)
(kms_async_flips:3180096) igt_fb-DEBUG: Test requirement passed:
cairo_surface_status(fb->cairo_surface) == CAIRO_STATUS_SUCCESS
(kms_async_flips:3180096) igt_fb-DEBUG: Test requirement passed:
cairo_surface_status(fb->cairo_surface) == CAIRO_STATUS_SUCCESS
(kms_async_flips:3180096) igt_fb-DEBUG:
igt_create_fb_with_bo_size(width=3440, height=1440,
format=XR24(0x34325258), modifier=0x0, size=0)
(kms_async_flips:3180096) igt_fb-DEBUG:
igt_create_fb_with_bo_size(handle=3, pitch=13824)
(kms_async_flips:3180096) ioctl_wrappers-DEBUG: Test requirement passed:
igt_has_fb_modifiers(fd)
(kms_async_flips:3180096) igt_fb-DEBUG: Test requirement passed:
cairo_surface_status(fb->cairo_surface) == CAIRO_STATUS_SUCCESS
(kms_async_flips:3180096) igt_fb-DEBUG: Test requirement passed:
cairo_surface_status(fb->cairo_surface) == CAIRO_STATUS_SUCCESS
(kms_async_flips:3180096) igt_fb-DEBUG:
igt_create_fb_with_bo_size(width=3440, height=1440,
format=XR24(0x34325258), modifier=0x0, size=0)
(kms_async_flips:3180096) igt_fb-DEBUG:
igt_create_fb_with_bo_size(handle=4, pitch=13824)
(kms_async_flips:3180096) ioctl_wrappers-DEBUG: Test requirement passed:
igt_has_fb_modifiers(fd)
(kms_async_flips:3180096) igt_fb-DEBUG: Test requirement passed:
cairo_surface_status(fb->cairo_surface) == CAIRO_STATUS_SUCCESS
(kms_async_flips:3180096) igt_fb-DEBUG: Test requirement passed:
cairo_surface_status(fb->cairo_surface) == CAIRO_STATUS_SUCCESS
(kms_async_flips:3180096) igt_fb-DEBUG:
igt_create_fb_with_bo_size(width=3440, height=1440,
format=XR24(0x34325258), modifier=0x0, size=0)
(kms_async_flips:3180096) igt_fb-DEBUG:
igt_create_fb_with_bo_size(handle=5, pitch=13824)
(kms_async_flips:3180096) ioctl_wrappers-DEBUG: Test requirement passed:
igt_has_fb_modifiers(fd)
(kms_async_flips:3180096) igt_fb-DEBUG: Test requirement passed:
cairo_surface_status(fb->cairo_surface) == CAIRO_STATUS_SUCCESS
(kms_async_flips:3180096) igt_fb-DEBUG: Test requirement passed:
cairo_surface_status(fb->cairo_surface) == CAIRO_STATUS_SUCCESS
(kms_async_flips:3180096) igt_fb-DEBUG:
igt_create_fb_with_bo_size(width=3440, height=1440,
format=XR24(0x34325258), modifier=0x0, size=0)
(kms_async_flips:3180096) igt_fb-DEBUG:
igt_create_fb_with_bo_size(handle=6, pitch=13824)
(kms_async_flips:3180096) ioctl_wrappers-DEBUG: Test requirement passed:
igt_has_fb_modifiers(fd)
(kms_async_flips:3180096) igt_fb-DEBUG: Test requirement passed:
cairo_surface_status(fb->cairo_surface) == CAIRO_STATUS_SUCCESS
(kms_async_flips:3180096) igt_fb-DEBUG: Test requirement passed:
cairo_surface_status(fb->cairo_surface) == CAIRO_STATUS_SUCCESS
(kms_async_flips:3180096) igt_fb-DEBUG:
igt_create_fb_with_bo_size(width=3440, height=1440,
format=XR24(0x34325258), modifier=0x0, size=0)
(kms_async_flips:3180096) igt_fb-DEBUG:
igt_create_fb_with_bo_size(handle=7, pitch=13824)
(kms_async_flips:3180096) ioctl_wrappers-DEBUG: Test requirement passed:
igt_has_fb_modifiers(fd)
(kms_async_flips:3180096) igt_fb-DEBUG: Test requirement passed:
cairo_surface_status(fb->cairo_surface) == CAIRO_STATUS_SUCCESS
(kms_async_flips:3180096) igt_fb-DEBUG: Test requirement passed:
cairo_surface_status(fb->cairo_surface) == CAIRO_STATUS_SUCCESS
(kms_async_flips:3180096) igt_fb-DEBUG:
igt_create_fb_with_bo_size(width=3440, height=1440,
format=XR24(0x34325258), modifier=0x0, size=0)
(kms_async_flips:3180096) igt_fb-DEBUG:
igt_create_fb_with_bo_size(handle=8, pitch=13824)
(kms_async_flips:3180096) ioctl_wrappers-DEBUG: Test requirement passed:
igt_has_fb_modifiers(fd)
(kms_async_flips:3180096) igt_fb-DEBUG: Test requirement passed:
cairo_surface_status(fb->cairo_surface) == CAIRO_STATUS_SUCCESS
(kms_async_flips:3180096) igt_fb-DEBUG: Test requirement passed:
cairo_surface_status(fb->cairo_surface) == CAIRO_STATUS_SUCCESS
(kms_async_flips:3180096) igt_kms-DEBUG: display: A.0: plane_set_fb(151)
(kms_async_flips:3180096) igt_kms-DEBUG: display: A.0: plane_set_size
(3440x1440)
(kms_async_flips:3180096) igt_kms-DEBUG: display: A.0: fb_set_position(0,0)
(kms_async_flips:3180096) igt_kms-DEBUG: display: A.0:
fb_set_size(3440x1440)
(kms_async_flips:3180096) igt_kms-DEBUG: display: A.0: plane_set_size
(3440x1440)
(kms_async_flips:3180096) igt_kms-DEBUG: display: A.2: plane_set_fb(151)
(kms_async_flips:3180096) igt_kms-DEBUG: display: A.2: plane_set_size
(3440x1440)
(kms_async_flips:3180096) igt_kms-DEBUG: display: A.2: fb_set_position(0,0)
(kms_async_flips:3180096) igt_kms-DEBUG: display: A.2:
fb_set_size(3440x1440)
(kms_async_flips:3180096) igt_kms-DEBUG: display: A.2: plane_set_size
(3440x1440)
(kms_async_flips:3180096) igt_kms-DEBUG: display: commit {
(kms_async_flips:3180096) igt_kms-DEBUG: Pipe A: Setting property
"MODE_ID" to 0x96/150
(kms_async_flips:3180096) igt_kms-DEBUG: Pipe A: Setting property
"ACTIVE" to 0x1/1
(kms_async_flips:3180096) igt_kms-DEBUG: display: populating plane
data: A.0, fb 151
(kms_async_flips:3180096) igt_kms-DEBUG: plane A.0: Setting property
"SRC_X" to 0x0/0
(kms_async_flips:3180096) igt_kms-DEBUG: plane A.0: Setting property
"SRC_Y" to 0x0/0
(kms_async_flips:3180096) igt_kms-DEBUG: plane A.0: Setting property
"SRC_W" to 0xd700000/225443840
(kms_async_flips:3180096) igt_kms-DEBUG: plane A.0: Setting property
"SRC_H" to 0x5a00000/94371840
(kms_async_flips:3180096) igt_kms-DEBUG: plane A.0: Setting property
"CRTC_W" to 0xd70/3440
(kms_async_flips:3180096) igt_kms-DEBUG: plane A.0: Setting property
"CRTC_H" to 0x5a0/1440
(kms_async_flips:3180096) igt_kms-DEBUG: plane A.0: Setting property
"FB_ID" to 0x97/151
(kms_async_flips:3180096) igt_kms-DEBUG: plane A.0: Setting property
"CRTC_ID" to 0x5b/91
(kms_async_flips:3180096) igt_kms-DEBUG: plane A.0: Setting property
"COLOR_ENCODING" to 0x1/1
(kms_async_flips:3180096) igt_kms-DEBUG: plane A.0: Setting property
"COLOR_RANGE" to 0x0/0
(kms_async_flips:3180096) igt_kms-DEBUG: display: populating plane
data: A.2, fb 151
(kms_async_flips:3180096) igt_kms-DEBUG: plane A.2: Setting property
"SRC_X" to 0x0/0
(kms_async_flips:3180096) igt_kms-DEBUG: plane A.2: Setting property
"SRC_Y" to 0x0/0
(kms_async_flips:3180096) igt_kms-DEBUG: plane A.2: Setting property
"SRC_W" to 0xd700000/225443840
(kms_async_flips:3180096) igt_kms-DEBUG: plane A.2: Setting property
"SRC_H" to 0x5a00000/94371840
(kms_async_flips:3180096) igt_kms-DEBUG: plane A.2: Setting property
"CRTC_W" to 0xd70/3440
(kms_async_flips:3180096) igt_kms-DEBUG: plane A.2: Setting property
"CRTC_H" to 0x5a0/1440
(kms_async_flips:3180096) igt_kms-DEBUG: plane A.2: Setting property
"FB_ID" to 0x97/151
(kms_async_flips:3180096) igt_kms-DEBUG: plane A.2: Setting property
"CRTC_ID" to 0x5b/91
(kms_async_flips:3180096) igt_kms-DEBUG: display: populating plane
data: B.0, fb 0
(kms_async_flips:3180096) igt_kms-DEBUG: plane B.0: Setting property
"COLOR_ENCODING" to 0x0/0
(kms_async_flips:3180096) igt_kms-DEBUG: plane B.0: Setting property
"COLOR_RANGE" to 0x0/0
(kms_async_flips:3180096) igt_kms-DEBUG: display: populating plane
data: C.0, fb 0
(kms_async_flips:3180096) igt_kms-DEBUG: plane C.0: Setting property
"COLOR_ENCODING" to 0x0/0
(kms_async_flips:3180096) igt_kms-DEBUG: plane C.0: Setting property
"COLOR_RANGE" to 0x0/0
(kms_async_flips:3180096) igt_kms-DEBUG: display: populating plane
data: D.0, fb 0
(kms_async_flips:3180096) igt_kms-DEBUG: plane D.0: Setting property
"COLOR_ENCODING" to 0x0/0
(kms_async_flips:3180096) igt_kms-DEBUG: plane D.0: Setting property
"COLOR_RANGE" to 0x0/0
(kms_async_flips:3180096) igt_kms-DEBUG: display: populating plane
data: E.0, fb 0
(kms_async_flips:3180096) igt_kms-DEBUG: plane E.0: Setting property
"COLOR_ENCODING" to 0x0/0
(kms_async_flips:3180096) igt_kms-DEBUG: plane E.0: Setting property
"COLOR_RANGE" to 0x0/0
(kms_async_flips:3180096) igt_kms-DEBUG: display: populating plane
data: F.0, fb 0
(kms_async_flips:3180096) igt_kms-DEBUG: plane F.0: Setting property
"COLOR_ENCODING" to 0x0/0
(kms_async_flips:3180096) igt_kms-DEBUG: plane F.0: Setting property
"COLOR_RANGE" to 0x0/0
(kms_async_flips:3180096) igt_kms-DEBUG: display: DP-1: preparing
atomic, pipe: A
(kms_async_flips:3180096) igt_kms-DEBUG: DP-1: Setting property
"CRTC_ID" to 0x5b/91
(kms_async_flips:3180096) igt_kms-DEBUG: display: }
(kms_async_flips:3180096) igt_kms-DEBUG: display: A.2: plane_set_fb(154)
(kms_async_flips:3180096) igt_kms-DEBUG: display: A.2: plane_set_size
(3440x1440)
(kms_async_flips:3180096) igt_kms-DEBUG: display: A.2: fb_set_position(0,0)
(kms_async_flips:3180096) igt_kms-DEBUG: display: A.2:
fb_set_size(3440x1440)
(kms_async_flips:3180096) igt_kms-DEBUG: display: commit {
(kms_async_flips:3180096) igt_kms-DEBUG: display: populating plane
data: A.2, fb 154
(kms_async_flips:3180096) igt_kms-DEBUG: plane A.2: Setting property
"SRC_X" to 0x0/0
(kms_async_flips:3180096) igt_kms-DEBUG: plane A.2: Setting property
"SRC_Y" to 0x0/0
(kms_async_flips:3180096) igt_kms-DEBUG: plane A.2: Setting property
"SRC_W" to 0xd700000/225443840
(kms_async_flips:3180096) igt_kms-DEBUG: plane A.2: Setting property
"SRC_H" to 0x5a00000/94371840
(kms_async_flips:3180096) igt_kms-DEBUG: plane A.2: Setting property
"CRTC_W" to 0xd70/3440
(kms_async_flips:3180096) igt_kms-DEBUG: plane A.2: Setting property
"CRTC_H" to 0x5a0/1440
(kms_async_flips:3180096) igt_kms-DEBUG: plane A.2: Setting property
"FB_ID" to 0x9a/154
(kms_async_flips:3180096) igt_kms-DEBUG: plane A.2: Setting property
"CRTC_ID" to 0x5b/91
(kms_async_flips:3180096) igt_kms-DEBUG: display: }
(kms_async_flips:3180096) CRITICAL: Test assertion failure function
test_async_flip, file ../tests/kms_async_flips.c:361:
(kms_async_flips:3180096) CRITICAL: Failed assertion: ret == 0
(kms_async_flips:3180096) CRITICAL: Last errno: 22, Invalid argument
(kms_async_flips:3180096) CRITICAL: error: -22 != 0
(kms_async_flips:3180096) igt_core-INFO: Stack trace:
**** END ****
Dynamic subtest pipe-A-DP-1: FAIL (0.227s)
>
>>
>> Thanks!
>>
>>> Vitaly
>>>
>>>> Please add to Cc Vitaly from AMD:
>>>> Cc: Vitaly Prosyak <vitaly.prosyak@amd.com>
>>>>
>>>> Also add Jeevan here:
>>>> Cc: Jeevan B <jeevan.b@intel.com>
>>>>
>>>> Regards,
>>>> Kamil
>>>>
>>>>> Signed-off-by: André Almeida <andrealmeid@igalia.com>
>>>>> ---
>>>>> v2: Add test description for GitLab compilation
>>>>> ---
>>>>> tests/kms_async_flips.c | 45 +++++++++++++++++++++++++++++++++++++----
>>>>> 1 file changed, 41 insertions(+), 4 deletions(-)
>>>>>
>>>>> diff --git a/tests/kms_async_flips.c b/tests/kms_async_flips.c
>>>>> index 4a72be7b5..dd0907d50 100644
>>>>> --- a/tests/kms_async_flips.c
>>>>> +++ b/tests/kms_async_flips.c
>>>>> @@ -89,6 +89,9 @@
>>>>> *
>>>>> * SUBTEST: async-flip-suspend-resume
>>>>> * Description: Verify the async flip functionality with suspend and resume cycle
>>>>> + *
>>>>> + * SUBTEST: overlay-atomic
>>>>> + * Description: Verify overlay planes with async flips in atomic API
>>>>> */
>>>>>
>>>>> #define CURSOR_POS 128
>>>>> @@ -109,12 +112,14 @@ typedef struct {
>>>>> uint32_t crtc_id;
>>>>> uint32_t refresh_rate;
>>>>> struct igt_fb bufs[NUM_FBS];
>>>>> + struct igt_fb bufs_overlay[NUM_FBS];
>>>>> igt_display_t display;
>>>>> igt_output_t *output;
>>>>> unsigned long flip_timestamp_us;
>>>>> double flip_interval;
>>>>> uint64_t modifier;
>>>>> igt_plane_t *plane;
>>>>> + igt_plane_t *overlay_plane;
>>>>> igt_pipe_crc_t *pipe_crc;
>>>>> igt_crc_t ref_crc;
>>>>> int flip_count;
>>>>> @@ -126,6 +131,7 @@ typedef struct {
>>>>> bool allow_fail;
>>>>> struct buf_ops *bops;
>>>>> bool atomic_path;
>>>>> + bool overlay_path;
>>>>> } data_t;
>>>>>
>>>>> static void flip_handler(int fd_, unsigned int sequence, unsigned int tv_sec,
>>>>> @@ -226,6 +232,8 @@ static void test_init(data_t *data)
>>>>> igt_output_set_pipe(data->output, data->pipe);
>>>>>
>>>>> data->plane = igt_output_get_plane_type(data->output, DRM_PLANE_TYPE_PRIMARY);
>>>>> + if (data->overlay_path)
>>>>> + data->overlay_plane = igt_output_get_plane_type(data->output, DRM_PLANE_TYPE_OVERLAY);
>>>>> }
>>>>>
>>>>> static void test_init_fbs(data_t *data)
>>>>> @@ -246,16 +254,27 @@ static void test_init_fbs(data_t *data)
>>>>> prev_modifier = data->modifier;
>>>>>
>>>>> if (data->bufs[0].fb_id) {
>>>>> - for (i = 0; i < NUM_FBS; i++)
>>>>> + for (i = 0; i < NUM_FBS; i++) {
>>>>> igt_remove_fb(data->drm_fd, &data->bufs[i]);
>>>>> + if (data->overlay_path)
>>>>> + igt_remove_fb(data->drm_fd, &data->bufs_overlay[i]);
>>>>> + }
>>>>> }
>>>>>
>>>>> - for (i = 0; i < NUM_FBS; i++)
>>>>> + for (i = 0; i < NUM_FBS; i++) {
>>>>> make_fb(data, &data->bufs[i], width, height, i);
>>>>> + if (data->overlay_path)
>>>>> + make_fb(data, &data->bufs_overlay[i], width, height, i);
>>>>> + }
>>>>> }
>>>>>
>>>>> igt_plane_set_fb(data->plane, &data->bufs[0]);
>>>>> igt_plane_set_size(data->plane, width, height);
>>>>> +
>>>>> + if (data->overlay_path) {
>>>>> + igt_plane_set_fb(data->overlay_plane, &data->bufs[0]);
>>>>> + igt_plane_set_size(data->overlay_plane, width, height);
>>>>> + }
>>>>> }
>>>>>
>>>>> static bool async_flip_needs_extra_frame(data_t *data)
>>>>> @@ -283,12 +302,17 @@ static bool async_flip_needs_extra_frame(data_t *data)
>>>>> static int perform_flip(data_t *data, int frame, int flags)
>>>>> {
>>>>> int ret;
>>>>> + igt_plane_t *plane;
>>>>> + struct igt_fb *bufs;
>>>>> +
>>>>> + plane = data->overlay_path ? data->overlay_plane : data->plane;
>>>>> + bufs = data->overlay_path ? data->bufs_overlay : data->bufs;
>>>>>
>>>>> if (!data->atomic_path) {
>>>>> ret = drmModePageFlip(data->drm_fd, data->crtc_id,
>>>>> - data->bufs[frame % NUM_FBS].fb_id, flags, data);
>>>>> + bufs[frame % NUM_FBS].fb_id, flags, data);
>>>>> } else {
>>>>> - igt_plane_set_fb(data->plane, &data->bufs[frame % NUM_FBS]);
>>>>> + igt_plane_set_fb(plane, &data->bufs[frame % NUM_FBS]);
>>>>> ret = igt_display_try_commit_atomic(&data->display, flags, data);
>>>>> }
>>>>>
>>>>> @@ -772,6 +796,7 @@ igt_main
>>>>> igt_subtest_with_dynamic("async-flip-with-page-flip-events") {
>>>>> data.alternate_sync_async = false;
>>>>> data.atomic_path = false;
>>>>> + data.overlay_path = false;
>>>>> if (is_intel_device(data.drm_fd))
>>>>> run_test_with_modifiers(&data, test_async_flip);
>>>>> else
>>>>> @@ -783,6 +808,7 @@ igt_main
>>>>> igt_subtest_with_dynamic("async-flip-with-page-flip-events-atomic") {
>>>>> data.alternate_sync_async = false;
>>>>> data.atomic_path = true;
>>>>> + data.overlay_path = false;
>>>>> if (is_intel_device(data.drm_fd))
>>>>> run_test_with_modifiers(&data, test_async_flip);
>>>>> else
>>>>> @@ -793,6 +819,7 @@ igt_main
>>>>> igt_subtest_with_dynamic("alternate-sync-async-flip") {
>>>>> data.alternate_sync_async = true;
>>>>> data.atomic_path = false;
>>>>> + data.overlay_path = false;
>>>>> run_test(&data, test_async_flip);
>>>>> }
>>>>>
>>>>> @@ -800,7 +827,17 @@ igt_main
>>>>> igt_subtest_with_dynamic("alternate-sync-async-flip-atomic") {
>>>>> data.alternate_sync_async = true;
>>>>> data.atomic_path = true;
>>>>> + data.overlay_path = false;
>>>>> + run_test(&data, test_async_flip);
>>>>> + }
>>>>> +
>>>>> + igt_describe("Verify overlay planes with async flips in atomic API");
>>>>> + igt_subtest_with_dynamic("overlay-atomic") {
>>>>> + igt_require(is_amdgpu_device(data.drm_fd));
>>>>> + data.atomic_path = true;
>>>>> + data.overlay_path = true;
>>>>> run_test(&data, test_async_flip);
>>>>> + data.overlay_path = false;
>>>>> }
>>>>>
>>>>> igt_describe("Verify that the async flip timestamp does not "
>>>>> --
>>>>> 2.47.1
>>>>>
next prev parent reply other threads:[~2025-02-25 19:06 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-16 20:24 [PATCH v2] tests/kms_async_flips: Create subtest for overlay planes André Almeida
2024-12-16 23:53 ` ✓ i915.CI.BAT: success for tests/kms_async_flips: Create subtest for overlay planes (rev2) Patchwork
2024-12-17 2:26 ` ✓ Xe.CI.BAT: " Patchwork
2024-12-17 7:14 ` ✗ i915.CI.Full: failure " Patchwork
2024-12-17 9:39 ` ✗ Xe.CI.Full: " Patchwork
2024-12-17 12:14 ` Patchwork
2025-02-14 17:37 ` [PATCH v2] tests/kms_async_flips: Create subtest for overlay planes André Almeida
2025-02-18 16:30 ` ✓ Xe.CI.BAT: success for tests/kms_async_flips: Create subtest for overlay planes (rev3) Patchwork
2025-02-18 16:47 ` ✗ i915.CI.BAT: failure " Patchwork
2025-02-19 10:04 ` Kamil Konieczny
2025-02-19 11:50 ` Ravali, JupallyX
2025-02-19 9:00 ` ✗ Xe.CI.Full: " Patchwork
2025-02-19 10:25 ` Kamil Konieczny
2025-02-19 10:37 ` [PATCH v2] tests/kms_async_flips: Create subtest for overlay planes Kamil Konieczny
2025-02-19 18:06 ` vitaly prosyak
2025-02-25 15:42 ` André Almeida
2025-02-25 15:51 ` vitaly prosyak
2025-02-25 19:06 ` Alex Hung [this message]
2025-02-25 20:16 ` André Almeida
2025-02-25 21:40 ` Alex Hung
2025-02-25 22:01 ` André Almeida
2025-02-25 22:47 ` Alex Hung
2025-02-27 2:07 ` André Almeida
2025-02-27 17:22 ` Alex Hung
2025-02-19 11:44 ` ✓ i915.CI.BAT: success for tests/kms_async_flips: Create subtest for overlay planes (rev3) Patchwork
2025-02-20 1:48 ` ✗ i915.CI.Full: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=41966687-e25e-42eb-a6b3-fba5d6c85e16@amd.com \
--to=alex.hung@amd.com \
--cc=andrealmeid@igalia.com \
--cc=harry.wentland@amd.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=jeevan.b@intel.com \
--cc=kamil.konieczny@linux.intel.com \
--cc=kernel-dev@igalia.com \
--cc=vitaly.prosyak@amd.com \
--cc=vprosyak@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox