public inbox for igt-dev@lists.freedesktop.org
 help / color / mirror / Atom feed
From: "Das, Nirmoy" <nirmoy.das@linux.intel.com>
To: Matthew Auld <matthew.auld@intel.com>, igt-dev@lists.freedesktop.org
Cc: intel-gfx@lists.freedesktop.org,
	Janga Rahul Kumar <janga.rahul.kumar@intel.com>
Subject: Re: [igt-dev] [PATCH i-g-t] tests/i915/module_load: restore gem_sanitycheck for discrete
Date: Thu, 3 Nov 2022 12:10:12 +0100	[thread overview]
Message-ID: <41f5ad21-9667-e678-f6a6-3b924e398152@linux.intel.com> (raw)
In-Reply-To: <20221102150500.227161-1-matthew.auld@intel.com>

Reviewed-by: Nirmoy.das@intel.com

On 11/2/2022 4:05 PM, Matthew Auld wrote:
> This looks to be recently broken in: 5389b3f3
> ("tests/i915/i915_module_load: Use GEM_BUSY instead of SET_CACHE for
> sanity check").
>
> Which fails on discrete platforms, since we switched over to the
> gem_busy ioctl, from the set_caching ioctl, which no longer gives
> -ENODEV as the expected error.
>
> Signed-off-by: Matthew Auld <matthew.auld@intel.com>
> Cc: Janga Rahul Kumar <janga.rahul.kumar@intel.com>
> Cc: Priyanka Dandamudi <priyanka.dandamudi@intel.com>
> ---
>   tests/i915/i915_module_load.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/i915/i915_module_load.c b/tests/i915/i915_module_load.c
> index eebb3167..d3a86b11 100644
> --- a/tests/i915/i915_module_load.c
> +++ b/tests/i915/i915_module_load.c
> @@ -228,7 +228,7 @@ static void gem_sanitycheck(void)
>   {
>   	struct drm_i915_gem_busy args = {};
>   	int i915 = __drm_open_driver(DRIVER_INTEL);
> -	int expected = gem_has_lmem(i915) ? -ENODEV : -ENOENT;
> +	int expected = -ENOENT;
>   	int err;
>   
>   	err = 0;

  parent reply	other threads:[~2022-11-03 11:10 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-02 15:05 [igt-dev] [PATCH i-g-t] tests/i915/module_load: restore gem_sanitycheck for discrete Matthew Auld
2022-11-02 16:11 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2022-11-02 19:38 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork
2022-11-03 11:10 ` Das, Nirmoy [this message]
2022-11-03 11:12   ` [igt-dev] [Intel-gfx] [PATCH i-g-t] " Das, Nirmoy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=41f5ad21-9667-e678-f6a6-3b924e398152@linux.intel.com \
    --to=nirmoy.das@linux.intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=janga.rahul.kumar@intel.com \
    --cc=matthew.auld@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox