Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: "Borah, Chaitanya Kumar" <chaitanya.kumar.borah@intel.com>
To: Melissa Wen <mwen@igalia.com>,
	Petri Latvala <adrinael@adrinael.net>,
	Arkadiusz Hiler <arek@hiler.eu>,
	Kamil Konieczny <kamil.konieczny@linux.intel.com>,
	Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com>,
	Bhanuprakash Modem <bhanuprakash.modem@gmail.com>,
	Ashutosh Dixit <ashutosh.dixit@intel.com>,
	Karthik B S <karthik.b.s@intel.com>
Cc: <igt-dev@lists.freedesktop.org>, <kernel-dev@igalia.com>,
	Alex Hung <alex.hung@amd.com>,
	Swati Sharma <swati2.sharma@intel.com>,
	John Harrison <John.Harrison@Igalia.com>,
	Rodrigo Siqueira <siqueira@igalia.com>,
	Simon Ser <contact@emersion.fr>, Xaver Hugl <xaver.hugl@kde.org>,
	Harry Wentland <harry.wentland@amd.com>,
	Uma Shankar <uma.shankar@intel.com>
Subject: Re: [PATCH i-g-t v2 4/4] tests/kms_color_pipeline: skip if not an intel device
Date: Fri, 31 Jul 2026 13:57:51 +0530	[thread overview]
Message-ID: <4204b8bf-254d-47b7-b663-09ba6e9b7b4d@intel.com> (raw)
In-Reply-To: <20260602211259.898147-5-mwen@igalia.com>



On 6/3/2026 2:36 AM, Melissa Wen wrote:
>  From documentation, the test requires i915 or xe driver, so make sure it
> only runs with intel devices. In addition, it's a CRC-based test, making
> kms_colorop with writeback more aligned with color testing and
> validation. Other drivers should work on adapting this test to their
> needs if they are looking for CRC validation.
> 

I wonder if we should move this to the intel specific folder but the 
test follows the generic [Degamma] -> [CTM] -> [Gamma] pipeline. So in 
theory some other device can use still use it if they want. We can do 
without the move.

Reviewed-by: Chaitanya Kumar Borah <chaitanya.kumar.borah@intel.com>

> Signed-off-by: Melissa Wen <mwen@igalia.com>
> ---
>   tests/kms_color_pipeline.c | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/tests/kms_color_pipeline.c b/tests/kms_color_pipeline.c
> index 6119a830f..4ec483038 100644
> --- a/tests/kms_color_pipeline.c
> +++ b/tests/kms_color_pipeline.c
> @@ -367,6 +367,7 @@ int igt_main()
>   
>   		igt_display_require(&data.display, data.drm_fd);
>   		igt_require(data.display.is_atomic);
> +		igt_require(is_intel_device(data.drm_fd));
>   	}
>   
>   	igt_subtest_group()


  reply	other threads:[~2026-07-31  8:28 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-02 21:06 [PATCH i-g-t v2 0/4] test/kms_colorop_helper: don't request colorop updates indefinitely Melissa Wen
2026-06-02 21:06 ` [PATCH i-g-t v2 1/4] lib/igt_kms: clear colorop-changed flag after commit Melissa Wen
2026-07-31  8:25   ` Borah, Chaitanya Kumar
2026-06-02 21:06 ` [PATCH i-g-t v2 2/4] test/kms_colorop_helper: only check if a given enum value exist Melissa Wen
2026-07-31  8:26   ` Borah, Chaitanya Kumar
2026-06-02 21:06 ` [PATCH i-g-t v2 3/4] tests/kms_properties: check colorop properties on active color pipelines Melissa Wen
2026-07-31  8:27   ` Borah, Chaitanya Kumar
2026-06-02 21:06 ` [PATCH i-g-t v2 4/4] tests/kms_color_pipeline: skip if not an intel device Melissa Wen
2026-07-31  8:27   ` Borah, Chaitanya Kumar [this message]
2026-06-03  6:51 ` ✓ Xe.CI.BAT: success for test/kms_colorop_helper: don't request colorop updates indefinitely Patchwork
2026-06-03  6:57 ` ✓ i915.CI.BAT: " Patchwork
2026-06-03 18:25 ` ✓ Xe.CI.FULL: " Patchwork
2026-06-04  3:33 ` ✗ i915.CI.Full: failure " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4204b8bf-254d-47b7-b663-09ba6e9b7b4d@intel.com \
    --to=chaitanya.kumar.borah@intel.com \
    --cc=John.Harrison@Igalia.com \
    --cc=adrinael@adrinael.net \
    --cc=alex.hung@amd.com \
    --cc=arek@hiler.eu \
    --cc=ashutosh.dixit@intel.com \
    --cc=bhanuprakash.modem@gmail.com \
    --cc=contact@emersion.fr \
    --cc=harry.wentland@amd.com \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=juhapekka.heikkila@gmail.com \
    --cc=kamil.konieczny@linux.intel.com \
    --cc=karthik.b.s@intel.com \
    --cc=kernel-dev@igalia.com \
    --cc=mwen@igalia.com \
    --cc=siqueira@igalia.com \
    --cc=swati2.sharma@intel.com \
    --cc=uma.shankar@intel.com \
    --cc=xaver.hugl@kde.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox