Re: [PATCH i-g-t] tests/intel/kms_pm_dc: Skip runtime PM active check on headless systems

[Dibin Moolakadan Subrahmanian <dibin.moolakadan.subrahmanian@intel.com>]

On 31-03-2026 23:46, Mohammed Thasleem wrote:
> Skip runtime PM active check on disconnected displays in DPMS_ON.
> On headless systems, DPMS_ON operations don't enable CRTCs or acquire
> RPM wakerefs, leaving the device suspended.
> Skip the active state wait when no outputs are connected.
>
> Signed-off-by: Mohammed Thasleem <mohammed.thasleem@intel.com>
> ---
>   tests/intel/kms_pm_dc.c | 19 ++++++++++++++++++-
>   1 file changed, 18 insertions(+), 1 deletion(-)
>
> diff --git a/tests/intel/kms_pm_dc.c b/tests/intel/kms_pm_dc.c
> index 39e94f36b..39d00bb6e 100644
> --- a/tests/intel/kms_pm_dc.c
> +++ b/tests/intel/kms_pm_dc.c
> @@ -385,6 +385,17 @@ static void setup_dc_dpms(data_t *data)
>   	}
>   }
>   
> +static bool has_connected_outputs(data_t *data)
> +{
> +	igt_display_t *display = &data->display;
> +	igt_output_t *output;
> +
> +	for_each_connected_output(display, output)
> +		return true;
> +
> +	return false;
> +}
> +
>   static void dpms_off(data_t *data)
>   {
>   	for (int i = 0; i < data->display.n_outputs; i++) {
> @@ -406,7 +417,13 @@ static void dpms_on(data_t *data)
>   					   DRM_MODE_DPMS_ON);
>   	}
>   
> -	if (!data->runtime_suspend_disabled)
> +	/*
> +	 * DPMS_ON on disconnected connectors does not enable any pipe
> +	 * or acquire a runtime PM wakeref, so the device will never
> +	 * transition to active state. Skip the wait when no outputs
> +	 * are physically connected.
> +	 */
> +	if (!data->runtime_suspend_disabled && has_connected_outputs(data))
>   		igt_assert(igt_wait_for_pm_status
>   			   (IGT_RUNTIME_PM_STATUS_ACTIVE));
>   }

LGTM,
Reviewed-by: Dibin Moolakadan Subrahmanian <dibin.moolakadan.subrahmanian@intel.com>