Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Senna Tschudin <peter.senna@linux.intel.com>
To: Kamil Konieczny <kamil.konieczny@linux.intel.com>,
	igt-dev@lists.freedesktop.org, marcin.bernatowicz@intel.com,
	matthew.brost@intel.com, pravalika.gurram@intel.com
Subject: Re: [PATCH i-g-t] tests/intel/intel_sysfs_debugfs: Remove xe-gt
Date: Fri, 11 Apr 2025 09:35:14 +0200	[thread overview]
Message-ID: <424b20b4-4a5e-4c96-ad6f-89895d868c5f@linux.intel.com> (raw)
In-Reply-To: <20250410181117.6ovckutjog7wleah@kamilkon-DESK.igk.intel.com>

Hi Kamil,

On 4/10/2025 8:11 PM, Kamil Konieczny wrote:
> Hi Peter,
> On 2025-04-10 at 11:03:15 +0200, Peter Senna Tschudin wrote:
>> The intel_sysfs_debugfs test now includes functionality to read all Xe
>> debugfs files, making the older xe-gt test redundant. Additionally,
>> xe-gt causes issues when testing Virtual Functions (VFs) in SR-IOV
>> setups, as some of the debugfs files it expects are not present for VFs.
>>
>> Rather than extending the overlapping and problematic xe-gt, this commit
>> removes it entirely.
> 
> I agree on removing reading part but not on existence checks.
> Imho start with small refactor:
> 
> - remove readings
> - change existing checks so they will print _all_ missing
>   debugfs nodes and only after that test will fail if there
>   were misses

But that is the issue. For printing _all_ missing debugfs nodes
we need first to have a list of nodes that is complete and up to
date. Looking at git blame it is not clear that the current list
had the intention of being complete. Do you know why are we
testing for these few specific files?

[...]

Peter

  reply	other threads:[~2025-04-11  7:35 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-04-10  9:03 [PATCH i-g-t] tests/intel/intel_sysfs_debugfs: Remove xe-gt Peter Senna Tschudin
2025-04-10  9:30 ` Bernatowicz, Marcin
2025-04-10 10:22 ` ✓ i915.CI.BAT: success for " Patchwork
2025-04-10 10:40 ` ✓ Xe.CI.BAT: " Patchwork
2025-04-10 17:09 ` ✗ i915.CI.Full: failure " Patchwork
2025-04-10 17:22   ` Peter Senna Tschudin
2025-04-11  5:43     ` Ravali, JupallyX
2025-04-10 18:11 ` [PATCH i-g-t] " Kamil Konieczny
2025-04-11  7:35   ` Peter Senna Tschudin [this message]
2025-04-11  8:01   ` Bernatowicz, Marcin
2025-04-15  9:04     ` Kamil Konieczny
2025-04-11  5:09 ` ✓ i915.CI.Full: success for " Patchwork
2025-04-15  9:25 ` [PATCH i-g-t] " Kamil Konieczny
2025-04-15 10:05 ` Peter Senna Tschudin
2025-04-15 20:52 ` ✓ i915.CI.BAT: success for tests/intel/intel_sysfs_debugfs: Remove xe-gt (rev2) Patchwork
2025-04-15 21:22 ` ✓ Xe.CI.BAT: " Patchwork
2025-04-16  3:41 ` ✗ i915.CI.Full: failure " Patchwork
2025-04-16  4:55 ` ✗ Xe.CI.Full: " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=424b20b4-4a5e-4c96-ad6f-89895d868c5f@linux.intel.com \
    --to=peter.senna@linux.intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=kamil.konieczny@linux.intel.com \
    --cc=marcin.bernatowicz@intel.com \
    --cc=matthew.brost@intel.com \
    --cc=pravalika.gurram@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox