From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: References: <20180302104157.2943-1-chris@chris-wilson.co.uk> <20180305173031.16495-1-chris@chris-wilson.co.uk> From: Tvrtko Ursulin Message-ID: <42713e78-6e36-e0c6-81f4-5fa2a3967006@linux.intel.com> Date: Tue, 6 Mar 2018 09:37:50 +0000 MIME-Version: 1.0 In-Reply-To: <20180305173031.16495-1-chris@chris-wilson.co.uk> Content-Language: en-GB Subject: Re: [igt-dev] [Intel-gfx] [PATCH igt v3] igt/gen7_forcewake_mt: Make the mmio register as volatile List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" To: Chris Wilson , intel-gfx@lists.freedesktop.org Cc: igt-dev@lists.freedesktop.org List-ID: Ck9uIDA1LzAzLzIwMTggMTc6MzAsIENocmlzIFdpbHNvbiB3cm90ZToKPiBQcmV2ZW50IHRoZSBj b21waWxlciBmcm9tIGNhY2hpbmcgcmVhZHMvd3JpdGVzIHRvIHRoZSBodyByZWdpc3RlciBhcyB3 ZQo+IGRvIHdhbnQgdG8gcGVyZm9ybSBtbWlvLgo+IAo+IFdoaWxzdCBmaXhpbmcgdXAgdGhlIG1t aW8gYWNjZXNzLCBhbHNvIGVuc3VyZSB0aGF0IHdlIGRvIG5vdCBsZWF2ZSB0aGUKPiB0ZXN0IHdp dGggYW55IG90aGVyIGJpdHMgc3RpbGwgc2V0IGluIHRoZSBmb3JjZXdha2UgcmVnaXN0ZXIgdG8g cHJldmVudAo+IGFmZmVjdGluZyBvdGhlciB0ZXN0cywgYXMgc3BvdHRlZCBieSBUdnJ0a28uCj4g Cj4gdjI6IFVzZSBpbnRlbF9tbWlvX3VzZV9wY2lfYmFyKCkgcmF0aGVyIG9wZW4gY29kZSB0aGUg aW9yZW1hcAo+IHYzOiBGbGlwIGlndF93YWl0KCkgY2hlY2tpbmcgYXMgaXQgcmV0dXJucyB0cnVl IG9uIHN1Y2Nlc3MsIG5vdCBlcnJuby4KPiAKPiBTaWduZWQtb2ZmLWJ5OiBDaHJpcyBXaWxzb24g PGNocmlzQGNocmlzLXdpbHNvbi5jby51az4KPiBDYzogVHZydGtvIFVyc3VsaW4gPHR2cnRrby51 cnN1bGluQGludGVsLmNvbT4KPiAtLS0KPiAgIHRlc3RzL2dlbjdfZm9yY2V3YWtlX210LmMgfCA3 NSArKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrLS0tLS0tLS0tLS0tLS0tLQo+ICAgMSBm aWxlIGNoYW5nZWQsIDQ5IGluc2VydGlvbnMoKyksIDI2IGRlbGV0aW9ucygtKQo+IAo+IGRpZmYg LS1naXQgYS90ZXN0cy9nZW43X2ZvcmNld2FrZV9tdC5jIGIvdGVzdHMvZ2VuN19mb3JjZXdha2Vf bXQuYwo+IGluZGV4IDA3MzIwZWY5Li42ODE4ZDdhYSAxMDA2NDQKPiAtLS0gYS90ZXN0cy9nZW43 X2ZvcmNld2FrZV9tdC5jCj4gKysrIGIvdGVzdHMvZ2VuN19mb3JjZXdha2VfbXQuYwo+IEBAIC00 MSwxMiArNDEsMTQgQEAgSUdUX1RFU1RfREVTQ1JJUFRJT04oIkV4ZXJjaXNlIGEgc3VzcGVjdCB3 b3JrYXJvdW5kIHJlcXVpcmVkIGZvciIKPiAgIAkJICAgICAiIEZPUkNFV0FLRV9NVC4iKTsKPiAg IAo+ICAgI2RlZmluZSBGT1JDRVdBS0VfTVQgMHhhMTg4Cj4gKyNkZWZpbmUgUkVBRF9PTkNFKHgp ICgqKHZvbGF0aWxlIHR5cGVvZih4KSAqKSgmKHgpKSkKPiAgIAo+ICAgc3RydWN0IHRocmVhZCB7 Cj4gICAJcHRocmVhZF90IHRocmVhZDsKPiAtCXZvaWQgKm1taW87Cj4gKwl2b2xhdGlsZSB1aW50 MzJfdCAqZm9yY2V3YWtlX210Owo+ICAgCWludCBmZDsKPiAgIAlpbnQgYml0Owo+ICsJYm9vbCBk b25lOwo+ICAgfTsKPiAgIAo+ICAgc3RhdGljIGNvbnN0IHN0cnVjdCBwY2lfaWRfbWF0Y2ggbWF0 Y2hbXSA9IHsKPiBAQCAtNzcsNDMgKzc5LDM4IEBAIHN0YXRpYyBzdHJ1Y3QgcGNpX2RldmljZSAq X19pZ2Z4X2dldCh2b2lkKQo+ICAgCQlwY2lfaXRlcmF0b3JfZGVzdHJveShpdGVyKTsKPiAgIAl9 Cj4gICAKPiArCXBjaV9kZXZpY2VfcHJvYmUoZGV2KTsKPiAgIAlyZXR1cm4gZGV2Owo+ICAgfQo+ ICAgCj4gLXN0YXRpYyB2b2lkICppZ2Z4X2dldF9tbWlvKHZvaWQpCj4gK3N0YXRpYyB2b2xhdGls ZSB1aW50MzJfdCAqaWdmeF9tbWlvX2ZvcmNld2FrZV9tdCh2b2lkKQoKSSB0aGluayBpdHMgb3Zl cmtpbGwgdG8gYm90aGVyIHdpdGggdm9sYXRpbGUgYWxsIHRocm91Z2hvdXQgdGhlIGNoYWluLCAK aXQncyBub3QgbGlrZSBpdCdzIGNvbnN0LiBCdXQgbmV2ZXIgbWluZC4KCj4gICB7Cj4gICAJc3Ry dWN0IHBjaV9kZXZpY2UgKnBjaSA9IF9faWdmeF9nZXQoKTsKPiAtCXZvaWQgKm1taW8gPSBOVUxM Owo+IC0JaW50IGVycm9yOwo+ICAgCj4gLQlpZ3Rfc2tpcF9vbihwY2kgPT0gTlVMTCk7Cj4gLQlp Z3Rfc2tpcF9vbihpbnRlbF9nZW4ocGNpLT5kZXZpY2VfaWQpICE9IDcpOwo+ICsJaWd0X3JlcXVp cmUocGNpICYmIGludGVsX2dlbihwY2ktPmRldmljZV9pZCkgPT0gNyk7Cj4gICAKPiAtCWVycm9y ID0gcGNpX2RldmljZV9wcm9iZShwY2kpOwo+IC0JaWd0X2Fzc2VydF9lcShlcnJvciwgMCk7Cj4g KwlpbnRlbF9tbWlvX3VzZV9wY2lfYmFyKHBjaSk7Cj4gICAKPiAtCWVycm9yID0gcGNpX2Rldmlj ZV9tYXBfcmFuZ2UocGNpLAo+IC0JCQkJICAgICBwY2ktPnJlZ2lvbnNbMF0uYmFzZV9hZGRyLAo+ IC0JCQkJICAgICAyKjEwMjQqMTAyNCwKPiAtCQkJCSAgICAgUENJX0RFVl9NQVBfRkxBR19XUklU QUJMRSwKPiAtCQkJCSAgICAgJm1taW8pOwo+IC0JaWd0X2Fzc2VydF9lcShlcnJvciwgMCk7Cj4g LQlpZ3RfYXNzZXJ0KG1taW8gIT0gTlVMTCk7Cj4gLQo+IC0JcmV0dXJuIG1taW87Cj4gKwlyZXR1 cm4gKHZvbGF0aWxlIHVpbnQzMl90ICopKChjaGFyICopaWd0X2dsb2JhbF9tbWlvICsgRk9SQ0VX QUtFX01UKTsKPiAgIH0KPiAgIAo+ICAgc3RhdGljIHZvaWQgKnRocmVhZCh2b2lkICphcmcpCj4g ICB7Cj4gKwlzdGF0aWMgY29uc3QgY2hhciBhY3F1aXJlX2Vycm9yW10gPSAiYWNxdWlyZSI7Cj4g KwlzdGF0aWMgY29uc3QgY2hhciByZWxlYXNlX2Vycm9yW10gPSAicmVsZWFzZSI7Cj4gKwo+ICAg CXN0cnVjdCB0aHJlYWQgKnQgPSBhcmc7Cj4gLQl1aW50MzJfdCAqZm9yY2V3YWtlX210ID0gKHVp bnQzMl90ICopKChjaGFyICopdC0+bW1pbyArIEZPUkNFV0FLRV9NVCk7Cj4gLQl1aW50MzJfdCBi aXQgPSAxIDw8IHQtPmJpdDsKPiArCWNvbnN0IHVpbnQzMl90IGJpdCA9IDEgPDwgdC0+Yml0Owo+ ICsJdm9sYXRpbGUgdWludDMyX3QgKmZvcmNld2FrZV9tdCA9IHQtPmZvcmNld2FrZV9tdDsKPiAg IAo+IC0Jd2hpbGUgKDEpIHsKPiArCXdoaWxlICghUkVBRF9PTkNFKHQtPmRvbmUpKSB7CgpOb3Qg cmVhbGx5IGltcG9ydGFudCwgYnV0IGlzbid0IHRoaXMgbm90IGFsbG93ZWQgdG8gYmUgY29tcGls ZWQgb3V0IApzaW5jZSBpdCBjb21lcyBmcm9tIGV4dGVybmFsIHRvIHRoZSBmdW5jdGlvbiBtZW1v cnk/Cgo+ICAgCQkqZm9yY2V3YWtlX210ID0gYml0IDw8IDE2IHwgYml0Owo+IC0JCWlndF9hc3Nl cnQoKmZvcmNld2FrZV9tdCAmIGJpdCk7Cj4gKwkJaWYgKCFpZ3Rfd2FpdCgqZm9yY2V3YWtlX210 ICYgYml0LCA1MCwgMSkpCj4gKwkJCXJldHVybiAodm9pZCAqKWFjcXVpcmVfZXJyb3I7Cj4gKwo+ ICAgCQkqZm9yY2V3YWtlX210ID0gYml0IDw8IDE2Owo+IC0JCWlndF9hc3NlcnQoKCpmb3JjZXdh a2VfbXQgJiBiaXQpID09IDApOwo+ICsJCWlmICghaWd0X3dhaXQoKCpmb3JjZXdha2VfbXQgJiBi aXQpID09IDAsIDUwLCAxKSkKPiArCQkJcmV0dXJuICh2b2lkICopcmVsZWFzZV9lcnJvcjsKPiAg IAl9Cj4gICAKPiAgIAlyZXR1cm4gTlVMTDsKPiBAQCAtMTI0LDEwICsxMjEsMTIgQEAgc3RhdGlj IHZvaWQgKnRocmVhZCh2b2lkICphcmcpCj4gICBpZ3Rfc2ltcGxlX21haW4KPiAgIHsKPiAgIAlz dHJ1Y3QgdGhyZWFkIHRbMTZdOwo+ICsJYm9vbCBzdWNjZXNzID0gdHJ1ZTsKPiAgIAlpbnQgaTsK PiAgIAo+ICAgCXRbMF0uZmQgPSBkcm1fb3Blbl9kcml2ZXIoRFJJVkVSX0lOVEVMKTsKPiAtCXRb MF0ubW1pbyA9IGlnZnhfZ2V0X21taW8oKTsKPiArCXRbMF0uZm9yY2V3YWtlX210ID0gaWdmeF9t bWlvX2ZvcmNld2FrZV9tdCgpOwo+ICsJdFswXS5kb25lID0gZmFsc2U7Cj4gICAKPiAgIAlmb3Ig KGkgPSAyOyBpIDwgMTY7IGkrKykgewo+ICAgCQl0W2ldID0gdFswXTsKPiBAQCAtMTM3LDcgKzEz Niw3IEBAIGlndF9zaW1wbGVfbWFpbgo+ICAgCj4gICAJc2xlZXAoMik7Cj4gICAKPiAtCWZvciAo aSA9IDA7IGkgPCAxMDAwOyBpKyspIHsKPiArCWlndF91bnRpbF90aW1lb3V0KDIpIHsKPiAgIAkJ dWludDMyX3QgKnA7Cj4gICAJCXN0cnVjdCBkcm1faTkxNV9nZW1fZXhlY2J1ZmZlcjIgZXhlY2J1 ZjsKPiAgIAkJc3RydWN0IGRybV9pOTE1X2dlbV9leGVjX29iamVjdDIgZXhlY1syXTsKPiBAQCAt MTkyLDEzICsxOTEsMzcgQEAgaWd0X3NpbXBsZV9tYWluCj4gICAJCXAgPSBnZW1fbW1hcF9fZ3R0 KHRbMF0uZmQsIGV4ZWNbMF0uaGFuZGxlLCA0MDk2LCBQUk9UX1JFQUQpOwo+ICAgCj4gICAJCWln dF9pbmZvKCJbJWRdPXsgJTA4eCAlMDh4IH1cbiIsIGksIHBbMF0sIHBbMV0pOwo+IC0JCWlndF9h c3NlcnQocFswXSAmIDIpOwo+IC0JCWlndF9hc3NlcnQoKHBbMV0gJiAyKSA9PSAwKTsKPiArCQlp ZiAoKHBbMF0gJiAyKSA9PSAwKSB7Cj4gKwkJCWlndF93YXJuKCJGYWlsZWQgdG8gYWNxdWlyZSBm b3JjZXdha2UgQklUKDEpIGZyb20gYmF0Y2hcbiIpOwo+ICsJCQlzdWNjZXNzID0gZmFsc2U7Cj4g KwkJfQo+ICsJCWlmICgocFsxXSAmIDIpKSB7Cj4gKwkJCWlndF93YXJuKCJGYWlsZWQgdG8gcmVs ZWFzZSBmb3JjZXdha2UgQklUKDEpIGZyb20gYmF0Y2hcbiIpOwo+ICsJCQlzdWNjZXNzID0gZmFs c2U7Cj4gKwkJfQo+ICAgCj4gICAJCW11bm1hcChwLCA0MDk2KTsKPiAgIAkJZ2VtX2Nsb3NlKHRb MF0uZmQsIGV4ZWNbMF0uaGFuZGxlKTsKPiAgIAkJZ2VtX2Nsb3NlKHRbMF0uZmQsIGV4ZWNbMV0u aGFuZGxlKTsKPiArCQlpZiAoIXN1Y2Nlc3MpCj4gKwkJCWJyZWFrOwo+ICAgCj4gICAJCXVzbGVl cCgxMDAwKTsKPiAgIAl9Cj4gKwo+ICsJZm9yIChpID0gMjsgaSA8IDE2OyBpKyspIHsKPiArCQl2 b2lkICpyZXN1bHQ7Cj4gKwo+ICsJCXRbaV0uZG9uZSA9IHRydWU7Cj4gKwkJcHRocmVhZF9qb2lu KHRbaV0udGhyZWFkLCAmcmVzdWx0KTsKCkNoZWNrIHJldHVybiB2YWx1ZSBqdXN0IGluIGNhc2U/ Cgo+ICsJCWlmIChyZXN1bHQpIHsKPiArCQkJaWd0X3dhcm4oIlRocmVhZCBCSVQoJWQpIGZhaWxl ZCB0byAlcyBmb3JjZXdha2VcbiIsIGksIChjaGFyICopcmVzdWx0KTsKPiArCQkJc3VjY2VzcyA9 IGZhbHNlOwo+ICsJCX0KPiArCX0KPiArCj4gKwkvKiBBbmQgY2xlYXIgYWxsIGZvcmNld2FrZSBi aXRzIGJlZm9yZSBkaXNhcHBlYXJpbmcgKi8KPiArCSp0WzBdLmZvcmNld2FrZV9tdCA9IDB4ZmZm ZSA8PCAxNjsKPiArCj4gKwlpZ3RfYXNzZXJ0KHN1Y2Nlc3MpOwo+ICAgfQo+IAoKQnV0IG9ubHkg bWlub3IgY29tbWVudHMgc286CgpSZXZpZXdlZC1ieTogVHZydGtvIFVyc3VsaW4gPHR2cnRrby51 cnN1bGluQGludGVsLmNvbT4KClJlZ2FyZHMsCgpUdnJ0a28KX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX18KaWd0LWRldiBtYWlsaW5nIGxpc3QKaWd0LWRldkBs aXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1h bi9saXN0aW5mby9pZ3QtZGV2Cg==