From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <igt-dev-bounces@lists.freedesktop.org>
Received: from mga09.intel.com (mga09.intel.com [134.134.136.24])
 by gabe.freedesktop.org (Postfix) with ESMTPS id 9FEEA10E6D2
 for <igt-dev@lists.freedesktop.org>; Tue, 25 Apr 2023 09:23:01 +0000 (UTC)
Message-ID: <42d04987-a81b-197b-4157-d48cda8a55ea@intel.com>
Date: Tue, 25 Apr 2023 14:52:45 +0530
MIME-Version: 1.0
Content-Language: en-US
To: Bhanuprakash Modem <bhanuprakash.modem@intel.com>,
 igt-dev@lists.freedesktop.org
References: <20230425064953.2121947-40-bhanuprakash.modem@intel.com>
From: "Gupta, Nidhi1" <nidhi1.gupta@intel.com>
In-Reply-To: <20230425064953.2121947-40-bhanuprakash.modem@intel.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [igt-dev] [i-g-t,V2,39/40] tests/kms_setmode: Add XE support
List-Unsubscribe: <https://lists.freedesktop.org/mailman/options/igt-dev>,
 <mailto:igt-dev-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <https://lists.freedesktop.org/archives/igt-dev>
List-Post: <mailto:igt-dev@lists.freedesktop.org>
List-Help: <mailto:igt-dev-request@lists.freedesktop.org?subject=help>
List-Subscribe: <https://lists.freedesktop.org/mailman/listinfo/igt-dev>,
 <mailto:igt-dev-request@lists.freedesktop.org?subject=subscribe>
Errors-To: igt-dev-bounces@lists.freedesktop.org
Sender: "igt-dev" <igt-dev-bounces@lists.freedesktop.org>
List-ID: <igt-dev@lists.freedesktop.org>

Looks good to me.

Reviewed-by: Nidhi Gupta <nidhi1.gupta@intel.com>

On 4/25/2023 12:19 PM, Bhanuprakash Modem wrote:
> Add XE driver support for kms tests.
> 
> Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
> ---
>   tests/kms_setmode.c | 7 +++++++
>   1 file changed, 7 insertions(+)
> 
> diff --git a/tests/kms_setmode.c b/tests/kms_setmode.c
> index bfa108916..a611d9382 100644
> --- a/tests/kms_setmode.c
> +++ b/tests/kms_setmode.c
> @@ -30,6 +30,7 @@
>   #include <string.h>
>   #include <sys/time.h>
>   #include <math.h>
> +#include "xe/xe_query.h"
>   
>   #define MAX_CONNECTORS  10
>   #define MAX_CRTCS       6
> @@ -954,6 +955,9 @@ igt_main_args("det:", NULL, help_str, opt_handler, NULL)
>   
>   		drm_resources = drmModeGetResources(drm_fd);
>   		igt_require(drm_resources);
> +
> +		if (is_xe_device(drm_fd))
> +			xe_device_get(drm_fd);
>   	}
>   
>   	for (i = 0; i < ARRAY_SIZE(tests); i++) {
> @@ -971,6 +975,9 @@ igt_main_args("det:", NULL, help_str, opt_handler, NULL)
>   	igt_fixture {
>   		drmModeFreeResources(drm_resources);
>   
> +		if (is_xe_device(drm_fd))
> +			xe_device_put(drm_fd);
> +
>   		close(drm_fd);
>   	}
>   }

-- 
~Nidhi Gupta