Re: [PATCH i-g-t v3 1/2] lib/igt_device_scan: Add driver field to igt_device_card struct

[Riana Tauro <riana.tauro@intel.com>]

On 3/28/2025 12:25 PM, Soham Purkait wrote:
> Add driver field to igt_device_card structure
> for storing driver names.
> 
> v1 : Add driver field to igt_device_card struct
> 
> v2 : Reorder commit sequence (Riana)
>       Include sign-off
> 
> Signed-off-by: Soham Purkait <soham.purkait@intel.com>
Looks good to me
Reviewed-by: Riana Tauro <riana.tauro@intel.com>


> ---
>   lib/igt_device_scan.c | 4 ++++
>   lib/igt_device_scan.h | 1 +
>   2 files changed, 5 insertions(+)
> 
> diff --git a/lib/igt_device_scan.c b/lib/igt_device_scan.c
> index 711bedc5c..3f26a1737 100644
> --- a/lib/igt_device_scan.c
> +++ b/lib/igt_device_scan.c
> @@ -774,6 +774,10 @@ __copy_dev_to_card(struct igt_device *dev, struct igt_device_card *card)
>   		safe_strncpy(card->render, dev->drm_render,
>   			     sizeof(card->render));
>   
> +	if (dev->driver != NULL)
> +		safe_strncpy(card->driver, dev->driver,
> +			     sizeof(card->driver));
> +
>   	if (dev->pci_slot_name != NULL)
>   		safe_strncpy(card->pci_slot_name, dev->pci_slot_name,
>   			     sizeof(card->pci_slot_name));
> diff --git a/lib/igt_device_scan.h b/lib/igt_device_scan.h
> index 92741fe3c..f1cd3b1e9 100644
> --- a/lib/igt_device_scan.h
> +++ b/lib/igt_device_scan.h
> @@ -59,6 +59,7 @@ struct igt_device_card {
>   	char subsystem[NAME_MAX];
>   	char card[NAME_MAX];
>   	char render[NAME_MAX];
> +	char driver[NAME_MAX];
>   	char pci_slot_name[PCI_SLOT_NAME_SIZE+1];
>   	uint16_t pci_vendor, pci_device;
>   };