From: "Jason-JH Lin (林睿祥)" <Jason-JH.Lin@mediatek.com>
To: "ville.syrjala@linux.intel.com" <ville.syrjala@linux.intel.com>,
"igt-dev@lists.freedesktop.org" <igt-dev@lists.freedesktop.org>,
"fshao@chromium.org" <fshao@chromium.org>,
"karthik.b.s@intel.com" <karthik.b.s@intel.com>,
"swati2.sharma@intel.com" <swati2.sharma@intel.com>,
"kamil.konieczny@linux.intel.com"
<kamil.konieczny@linux.intel.com>,
"juhapekka.heikkila@gmail.com" <juhapekka.heikkila@gmail.com>
Cc: Project_Global_Chrome_Upstream_Group
<Project_Global_Chrome_Upstream_Group@mediatek.com>,
"markyacoub@chromium.org" <markyacoub@chromium.org>,
"jani.nikula@intel.com" <jani.nikula@intel.com>,
"Paul-pl Chen (陳柏霖)" <Paul-pl.Chen@mediatek.com>,
"navaremanasi@google.com" <navaremanasi@google.com>,
"Lancelot Wu (吳瑋晟)" <Lancelot.Wu@mediatek.com>,
"gildekel@google.com" <gildekel@google.com>
Subject: Re: [PATCH i-g-t v2] tests/kms_plane: Remove redundant CRC frame sequence check
Date: Thu, 13 Aug 2026 05:36:49 +0000 [thread overview]
Message-ID: <43a2e6d0f6d068ccddf8bd16e64dd22fa99dfb26.camel@mediatek.com> (raw)
In-Reply-To: <7244584b-4bed-4756-bdae-e06b0054d2b7@intel.com>
> > diff --git a/tests/kms_plane.c b/tests/kms_plane.c
> > index 12dfbfe1d82b..fe8ee2ab26ab 100644
> > --- a/tests/kms_plane.c
> > +++ b/tests/kms_plane.c
> > @@ -765,11 +765,6 @@ static int num_unique_crcs(const igt_crc_t
> > crc[], int num_crc)
> > static void capture_crc(data_t *data, unsigned int vblank,
> > igt_crc_t *crc)
> > {
> > igt_pipe_crc_get_for_frame(data->drm_fd, data->pipe_crc,
> > vblank, crc);
>
> Also if this is only igt_pipe_crc_get_for_frame now, ideally we can
> just
> remove this function itself and call the helper directly.
No problem.
> But before
> doing that, as the existing assert was added by a patch from Ville
> and
> rb'ed by JP, I'll request an ack from them or if they have any inputs
> on
> this.
>
That's great! Thank you for your help!
Regards,
Jason-JH Lin
> Regards,
> Karthik.B.S
> > -
> > - igt_fail_on_f(!igt_skip_crc_compare &&
> > !igt_run_in_simulation() &&
> > - crc->has_valid_frame && crc->frame !=
> > vblank,
> > - "Got CRC for the wrong frame (got %u,
> > expected %u). CRC buffer overflow?\n",
> > - crc->frame, vblank);
> > }
> >
> > static void capture_format_crcs_single(data_t *data, igt_crtc_t
> > *crtc,
next prev parent reply other threads:[~2026-08-13 5:37 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-11 16:14 [PATCH i-g-t v2] tests/kms_plane: Remove redundant CRC frame sequence check Jason-JH Lin
2026-08-11 20:31 ` ✓ i915.CI.BAT: success for " Patchwork
2026-08-11 20:38 ` ✓ Xe.CI.BAT: " Patchwork
2026-08-11 22:33 ` ✓ Xe.CI.FULL: " Patchwork
2026-08-12 19:28 ` [PATCH i-g-t v2] " Manasi Navare
2026-08-13 3:37 ` Karthik B S
2026-08-13 5:36 ` Jason-JH Lin (林睿祥) [this message]
2026-08-13 11:07 ` Juha-Pekka Heikkilä
2026-08-14 2:46 ` Jason-JH Lin (林睿祥)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=43a2e6d0f6d068ccddf8bd16e64dd22fa99dfb26.camel@mediatek.com \
--to=jason-jh.lin@mediatek.com \
--cc=Lancelot.Wu@mediatek.com \
--cc=Paul-pl.Chen@mediatek.com \
--cc=Project_Global_Chrome_Upstream_Group@mediatek.com \
--cc=fshao@chromium.org \
--cc=gildekel@google.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=jani.nikula@intel.com \
--cc=juhapekka.heikkila@gmail.com \
--cc=kamil.konieczny@linux.intel.com \
--cc=karthik.b.s@intel.com \
--cc=markyacoub@chromium.org \
--cc=navaremanasi@google.com \
--cc=swati2.sharma@intel.com \
--cc=ville.syrjala@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox