Re: [PATCH 3/7] lib/amdgpu: Add AMD platform filtering backend

[Jani Nikula <jani.nikula@linux.intel.com>]

On Thu, 02 Jul 2026, Kamil Konieczny <kamil.konieczny@linux.intel.com> wrote:
> Hi vitaly.prosyak,
> On 2026-06-29 at 23:23:22 -0400, vitaly.prosyak@amd.com wrote:
>> From: Vitaly Prosyak <vitaly.prosyak@amd.com>
>> 
>> Implement the AMD-specific backend for the generic platform filtering
>> framework, providing:
>> 
>> - ASIC identification via amdgpu family_id and chip_rev ranges
>> - ASIC name table mapping (navi10, navi48, arcturus, etc.)
>> - AMD-specific built-in skip rules
>> - amd_platform_filter_init() convenience function for AMD tests
>> 
>> This is a pluggable backend accessed through platform_filter_ops
>> callbacks. The core framework has zero AMD-specific knowledge.
>> 
>> To add support for another vendor (e.g., Intel):
>> 1. Create lib/i915/intel_platform.c/h
>> 2. Implement platform_filter_ops callbacks
>> 3. Define Intel platform data (platform_id, stepping ranges)
>> 4. Call intel_platform_filter_init() from Intel tests
>> 
>> Usage in AMD tests:
>>     amd_platform_filter_init(&gpu_info);
>>     igt_platform_require(igt_test_name(), "my-subtest");
>> 
>> Example skip via environment variable:
>>     export IGT_PLATFORM_SKIP_CONFIG=navi48:amd_basic:*-UMQ:unstable
>> 
>> Cc: Kamil Konieczny <kamil.konieczny@linux.intel.com>
>> Cc: Jani Nikula <jani.nikula@linux.intel.com>
>> Cc: Jesse Zhang <jesse.zhang@amd.com>
>> Cc: Christian König <christian.koenig@amd.com>
>> Cc: Alex Deucher <alexander.deucher@amd.com>
>> Signed-off-by: Vitaly Prosyak <vitaly.prosyak@amd.com>
>> Reviewed-by: Jesse Zhang <jesse.zhang@amd.com>
>> ---
>>  lib/amdgpu/amd_platform.c | 318 ++++++++++++++++++++++++++++++++++++++
>>  lib/amdgpu/amd_platform.h |  53 +++++++
>>  lib/meson.build           |   1 +
>>  3 files changed, 372 insertions(+)
>>  create mode 100644 lib/amdgpu/amd_platform.c
>>  create mode 100644 lib/amdgpu/amd_platform.h
>
> Please make sure that you patch series compile patch after patch,
> so it will not break bisecting. For example run:
>
> git rebase origin -x ./compile.sh
>
> with script which will remove build folder before each build.

Why should the build folder be removed? Is there reason to believe
dependency tracking and incremental builds are failing?

I only ever do git rebase -i origin -x 'ninja -C build'.

BR,
Jani.


-- 
Jani Nikula, Intel