From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qt1-f193.google.com (mail-qt1-f193.google.com [209.85.160.193]) by gabe.freedesktop.org (Postfix) with ESMTPS id 1B3EA6E291 for ; Tue, 29 Jan 2019 20:08:13 +0000 (UTC) Received: by mail-qt1-f193.google.com with SMTP id u47so23723141qtj.6 for ; Tue, 29 Jan 2019 12:08:13 -0800 (PST) Message-ID: <45cfa144bcb2366a54a1ec3128f71baeee61e6fb.camel@redhat.com> From: Lyude Paul Date: Tue, 29 Jan 2019 15:08:10 -0500 In-Reply-To: <20190125145842.15738-8-maxime.ripard@bootlin.com> References: <20190125145842.15738-1-maxime.ripard@bootlin.com> <20190125145842.15738-8-maxime.ripard@bootlin.com> Mime-Version: 1.0 Subject: Re: [igt-dev] [PATCH i-g-t v5 07/13] igt: fb: Don't pass the stride when allocating a dumb, multi-planar buffer List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" To: Maxime Ripard , igt-dev@lists.freedesktop.org Cc: Petri Latvala , Thomas Petazzoni , eben@raspberrypi.org List-ID: T24gRnJpLCAyMDE5LTAxLTI1IGF0IDE1OjU4ICswMTAwLCBNYXhpbWUgUmlwYXJkIHdyb3RlOgo+ IFRoZSBkdW1iIGJ1ZmZlciBhbGxvY2F0aW9uIEFQSSBvbmx5IGNvbnNpZGVycyBhIHNpbmdsZSBw bGFuZSwgYW5kIGV2ZW4KPiB0aG91Z2ggYWxsb2NhdGluZyBtdWx0aS1wbGFuYXIgYnVmZmVycyB0 aHJvdWdoIGl0IGlzIGFsbG93ZWQsIHRoZSBzdHJpZGUgaXQKPiBnaXZlcyBiYWNrIGlzIHRoZSB0 aGUgd2lkdGggdGltZXMgdGhlIGJwcCBwYXNzZWQgYXMgYW4gYXJndW1lbnQuCj4gCj4gVGhhdCBk b2Vzbid0IHdvcmsgaW4gb3VyIGNhc2UsIHNpbmNlIHRoZSBicHAgaXMgZ29pbmcgdG8gYmUgdGhl IG9uZSB3ZSBnaXZlCj4gYXMgYW4gYXJndW1lbnQsIGJ1dCBzcGxpdCBvdmVyIHRocmVlIHBsYW5l cyBzbyB0aGUgc3RyaWRlIGRvZXNuJ3QgbWF0Y2gKPiBhbnltb3JlLgo+IAo+IEEgcHJvcGVyIGZp eCBmb3IgdGhpcyB3b3VsZCBiZSB0byBoYXZlIGEgYmV0dGVyIGR1bWIgYnVmZmVyIGFsbG9jYXRp b24gQVBJLAo+IGJ1dCBmb3IgdGhlIHRpbWUgYmVpbmcsIGxldCdzIGRvIGl0IHRoYXQgd2F5Lgo+ IAo+IFJldmlld2VkLWJ5OiBQYXVsIEtvY2lhbGtvd3NraSA8cGF1bC5rb2NpYWxrb3dza2lAYm9v dGxpbi5jb20+Cj4gU2lnbmVkLW9mZi1ieTogTWF4aW1lIFJpcGFyZCA8bWF4aW1lLnJpcGFyZEBi b290bGluLmNvbT4KPiAtLS0KPiAgbGliL2lndF9mYi5jIHwgMTcgKysrKysrKysrKysrKysrKy0K PiAgMSBmaWxlIGNoYW5nZWQsIDE2IGluc2VydGlvbnMoKyksIDEgZGVsZXRpb24oLSkKPiAKPiBk aWZmIC0tZ2l0IGEvbGliL2lndF9mYi5jIGIvbGliL2lndF9mYi5jCj4gaW5kZXggMWM1MmFlYmI2 NzRlLi4wNDhkMjc0ZTVkMzYgMTAwNjQ0Cj4gLS0tIGEvbGliL2lndF9mYi5jCj4gKysrIGIvbGli L2lndF9mYi5jCj4gQEAgLTUzMCw2ICs1MzAsNyBAQCBzdGF0aWMgaW50IGNyZWF0ZV9ib19mb3Jf ZmIoc3RydWN0IGlndF9mYiAqZmIpCj4gIHsKPiAgCWNvbnN0IHN0cnVjdCBmb3JtYXRfZGVzY19z dHJ1Y3QgKmZtdCA9IGxvb2t1cF9kcm1fZm9ybWF0KGZiLQo+ID5kcm1fZm9ybWF0KTsKPiAgCXVu c2lnbmVkIGludCBwbGFuZSwgYnBwOwo+ICsJdW5zaWduZWQgKnN0cmlkZXMgPSAmZmItPnN0cmlk ZXNbMF07Cj4gIAlpbnQgZmQgPSBmYi0+ZmQ7Cj4gIAo+ICAJaWYgKGZiLT50aWxpbmcgfHwgZmIt PnNpemUgfHwgZmItPnN0cmlkZXNbMF0gfHwgaWd0X2Zvcm1hdF9pc195dXYoZmItCj4gPmRybV9m b3JtYXQpKSB7Cj4gQEAgLTU3NSw4ICs1NzYsMjIgQEAgc3RhdGljIGludCBjcmVhdGVfYm9fZm9y X2ZiKHN0cnVjdCBpZ3RfZmIgKmZiKQo+ICAJCQkJICAgIHBsYW5lID8gZm10LT5oc3ViICogZm10 LT52c3ViIDogMSk7Cj4gIAo+ICAJZmItPmlzX2R1bWIgPSB0cnVlOwo+ICsKPiArCS8qCj4gKwkg KiBXZSBjYW4ndCByZWFsbHkgcGFzcyB0aGUgc3RyaWRlIGFycmF5IGhlcmUgc2luY2UgdGhlIGR1 bWIKPiArCSAqIGJ1ZmZlciBhbGxvY2F0aW9uIGlzIGFzc3VtaW5nIHRoYXQgaXQgb3BlcmF0ZXMg b24gb25lCj4gKwkgKiBwbGFuZSwgYW5kIHRoZXJlZm9yZSB3aWxsIGNhbGN1bGF0ZSB0aGUgc3Ry aWRlIGFzIGlmIGVhY2gKPiArCSAqIHBpeGVscyB3ZXJlIHN0b3JlZCBvbiBhIHNpbmdsZSBwbGFu ZS4KCm5pdHBpY2s6IHMvZWFjaCBwaXhlbHMgd2VyZS9lYWNoIHBpeGVsIHdhcy8KCj4gKwkgKgo+ ICsJICogVGhpcyBtaWdodCBjYXVzZSBpc3N1ZXMgYXQgc29tZSBwb2ludCBvbiBkcml2ZXJzIHRo YXQgd291bGQKPiArCSAqIGNoYW5nZSB0aGUgc3RyaWRlIG9mIFlVViBidWZmZXJzLCBidXQgd2Ug aGF2ZW4ndAo+ICsJICogZW5jb3VudGVyZWQgYW55IHlldC4KPiArCSAqLwpJcyBpdCBwb3NzaWJs ZSB0byBhZGQgYW4gaWd0X2Fzc2VydCB0byBjaGVjayBmb3IgdGhpcz8gRWl0aGVyIHdheSwgd2l0 aCB0aG9zZQpjaGFuZ2VzOgoKUmV2aWV3ZWQtYnk6IEx5dWRlIFBhdWwgPGx5dWRlQHJlZGhhdC5j b20+Cgo+ICsJaWYgKGZiLT5udW1fcGxhbmVzID4gMSkKPiArCQlzdHJpZGVzID0gTlVMTDsKPiAr Cj4gIAlmYi0+Z2VtX2hhbmRsZSA9IGttc3Rlc3RfZHVtYl9jcmVhdGUoZmQsIGZiLT53aWR0aCwg ZmItPmhlaWdodCwKPiAtCQkJCQkgICAgIGJwcCwgJmZiLT5zdHJpZGVzWzBdLCAmZmItPnNpemUp Owo+ICsJCQkJCSAgICAgYnBwLCBzdHJpZGVzLCAmZmItPnNpemUpOwo+ICAKPiAgCXJldHVybiBm Yi0+Z2VtX2hhbmRsZTsKPiAgfQotLSAKQ2hlZXJzLAoJTHl1ZGUgUGF1bAoKX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KaWd0LWRldiBtYWlsaW5nIGxpc3QK aWd0LWRldkBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5v cmcvbWFpbG1hbi9saXN0aW5mby9pZ3QtZGV2Cg==