public inbox for igt-dev@lists.freedesktop.org
 help / color / mirror / Atom feed
* [PATCH i-g-t v8 0/5] Close any open drm device after engine initialization in GPUTOP
@ 2026-02-19  9:47 Soham Purkait
  2026-02-19  9:48 ` [PATCH i-g-t v8 1/5] tools: Rename tools/gputop to tools/gputop.src Soham Purkait
                   ` (8 more replies)
  0 siblings, 9 replies; 14+ messages in thread
From: Soham Purkait @ 2026-02-19  9:47 UTC (permalink / raw)
  To: igt-dev, riana.tauro, badal.nilawar, kamil.konieczny,
	ashutosh.dixit, vinay.belgaumkar
  Cc: anshuman.gupta, soham.purkait, umesh.nerlige.ramappa

       During engine initialization for a specific device, the helper
functions require an open card_fd to query engines and configurations
needed to compute engine busyness via PMU. However, KMS tests require
that no other DRM client be active, and keeping card_fd open causes
gputop to appear as a DRM client. Therefore, card_fd is closed immediately
after discovery.
     Additionally, this patch removes the lib/xe/* dependency and perform
engine discovery using direct ioctl calls, simplifying the implementation
and reducing external dependencies, while also providing a fallback to
report only client busyness when engine busyness counters are not
accessible to non-root users.
  
  GPUTOP engine busyness is also capable of running without superuser access
through setting CAP_PERFMON or an appropriate perf_event_paranoid setting,
Otherwise user could continue with only GPU client busyness if required.

Steps to enable engine busyness to run without root (using CAP_PERFMON):
$ cd /path/to/igt-gpu-tools/
$ sudo setcap cap_perfmon=+ep $(pwd)/build/tools/gputop
$ sudo sh -c "echo $(pwd)/build/lib > /etc/ld.so.conf.d/lib-igt.conf"
$ sudo ldconfig
Steps to revert once done:
$ sudo setcap cap_perfmon=-ep $(pwd)/build/tools/gputop
$ sudo rm /etc/ld.so.conf.d/lib-igt.conf
$ sudo ldconfig

Steps to enable engine busyness to run without root (using perf_event_paranoid):
# Save current value
$ orig_val=$(sysctl -n kernel.perf_event_paranoid)
# Set the value to allow running GPUTOP without root privileges
$ sudo sysctl -w kernel.perf_event_paranoid=-1
Steps to revert once done:
$ sudo sysctl -w kernel.perf_event_paranoid=$orig_val

Soham Purkait (5):
  tools: Rename tools/gputop to tools/gputop.src
  tools/gputop.src/utils: Add clamp macro to remove dependency on
    lib/xe/*
  tools/gputop.src/xe_gputop: Refactor xe_populate_engines to close
    card_fd and use direct ioctl calls
  tools/gputop.src/gputop: Enable support for multiple GPUs and
    instances
  tools/gputop.src/gputop: Add command line option for device filter

 tools/{ => gputop.src}/gputop.c          | 292 +++++++++++++++++++----
 tools/gputop.src/meson.build             |   1 +
 tools/{gputop => gputop.src}/utils.c     |   0
 tools/{gputop => gputop.src}/utils.h     |  11 +-
 tools/{gputop => gputop.src}/xe_gputop.c | 108 +++++++--
 tools/{gputop => gputop.src}/xe_gputop.h |   3 +-
 tools/meson.build                        |  12 +-
 7 files changed, 352 insertions(+), 75 deletions(-)
 rename tools/{ => gputop.src}/gputop.c (57%)
 create mode 100644 tools/gputop.src/meson.build
 rename tools/{gputop => gputop.src}/utils.c (100%)
 rename tools/{gputop => gputop.src}/utils.h (89%)
 rename tools/{gputop => gputop.src}/xe_gputop.c (81%)
 rename tools/{gputop => gputop.src}/xe_gputop.h (95%)

-- 
2.34.1


^ permalink raw reply	[flat|nested] 14+ messages in thread

end of thread, other threads:[~2026-03-26  6:59 UTC | newest]

Thread overview: 14+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-02-19  9:47 [PATCH i-g-t v8 0/5] Close any open drm device after engine initialization in GPUTOP Soham Purkait
2026-02-19  9:48 ` [PATCH i-g-t v8 1/5] tools: Rename tools/gputop to tools/gputop.src Soham Purkait
2026-02-19  9:48 ` [PATCH i-g-t v8 2/5] tools/gputop.src/utils: Add clamp macro to remove dependency on lib/xe/* Soham Purkait
2026-02-19  9:48 ` [PATCH i-g-t v8 3/5] tools/gputop.src/xe_gputop: Refactor xe_populate_engines to close card_fd and use direct ioctl calls Soham Purkait
2026-03-11 17:38   ` Kamil Konieczny
2026-03-12 17:02   ` Belgaumkar, Vinay
2026-02-19  9:48 ` [PATCH i-g-t v8 4/5] tools/gputop.src/gputop: Enable support for multiple GPUs and instances Soham Purkait
2026-03-11 17:27   ` Kamil Konieczny
2026-03-26  6:58     ` Purkait, Soham
2026-02-19  9:48 ` [PATCH i-g-t v8 5/5] tools/gputop.src/gputop: Add command line option for device filter Soham Purkait
2026-02-19 15:27 ` ✓ Xe.CI.BAT: success for Close any open drm device after engine initialization in GPUTOP (rev9) Patchwork
2026-02-19 15:47 ` ✓ i915.CI.BAT: " Patchwork
2026-02-19 18:26 ` ✗ Xe.CI.FULL: failure " Patchwork
2026-02-19 19:45 ` ✗ i915.CI.Full: " Patchwork

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox