From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-io0-x242.google.com (mail-io0-x242.google.com [IPv6:2607:f8b0:4001:c06::242]) by gabe.freedesktop.org (Postfix) with ESMTPS id 52EBF6E5BC for ; Fri, 17 Aug 2018 06:53:58 +0000 (UTC) Received: by mail-io0-x242.google.com with SMTP id y24-v6so2386423iob.12 for ; Thu, 16 Aug 2018 23:53:58 -0700 (PDT) Message-ID: <46d34064b8b84e3fb1304c42f02805fffe1773b2.camel@gmail.com> From: Dhinakaran Pandiyan Date: Thu, 16 Aug 2018 23:53:54 -0700 In-Reply-To: <20180814122222.31509-2-maarten.lankhorst@linux.intel.com> References: <20180814122222.31509-1-maarten.lankhorst@linux.intel.com> <20180814122222.31509-2-maarten.lankhorst@linux.intel.com> Mime-Version: 1.0 Subject: Re: [igt-dev] [PATCH i-g-t 2/2] tests/kms_frontbuffer_tracking: Remove redundant modesets during subtest start, v4. List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" To: Maarten Lankhorst , igt-dev@lists.freedesktop.org List-ID: T24gVHVlLCAyMDE4LTA4LTE0IGF0IDE0OjIyICswMjAwLCBNYWFydGVuIExhbmtob3JzdCB3cm90 ZToKPiBDUkMgY2FwdHVyaW5nIGVuYWJsZXMgdGhlIGRpc3BsYXksIHRoZW4gZGlzYWJsZXMgaXQg YWdhaW4uIFdpdGgKPiBpZ3RfZGlzcGxheSB3ZSBjYW4gdXNlIGlndF9kaXNwbGF5X3Jlc2V0IHRv IHJlc3RvcmUgdGhlIG9yaWdpbmFsCj4gc3RhdGUsCj4gd2l0aG91dCBjb21taXR0aW5nIGl0IHRv IHRoZSBody4KPiAKPiBBbGwgc3VidGVzdHMgZmlyc3Qgc2V0IHRoZWlyIG93biBzdGF0ZSBhbnl3 YXksIHNvIHdlIGNhbiBzYXZlIHVwIG9uCj4gdGhlIG51bWJlciBvZiBjb21taXRzLgo+IAo+IENo YW5nZXMgc2luY2UgdjE6Cj4gLSBUcnkgdG8gYXZvaWQgbW9kZXNldHMgZm9yIFBTUiBpZiB0aGUg a2VybmVsIHN1cHBvcnRzIGl0LCBidXQKPiBvdGhlcndpc2UgZm9yY2UKPiAgIGEgbW9kZXNldCBm b3IgdGhlIGNoYW5nZXMgdG8gdGFrZSBlZmZlY3QuCj4gQ2hhbmdlcyBzaW5jZSB2MjoKPiAtIFJl YmFzZSBvbiB0b3Agb2YgcHJldmlvdXMgUFNSIGNoYW5nZXMuCj4gQ2hhbmdlcyBzaW5jZSB2MzoK PiAtIFJlYmFzZSBvbiBtb3ZlIHRvIGxpYi9pZ3RfcHNyLgo+IAo+IFNpZ25lZC1vZmYtYnk6IE1h YXJ0ZW4gTGFua2hvcnN0IDxtYWFydGVuLmxhbmtob3JzdEBsaW51eC5pbnRlbC5jb20+Cj4gLS0t Cj4gIHRlc3RzL2ttc19mcm9udGJ1ZmZlcl90cmFja2luZy5jIHwgNTcgKysrKysrKysrKysrKysr KysrKysrKysrLS0tLQo+IC0tLS0KPiAgMSBmaWxlIGNoYW5nZWQsIDQ0IGluc2VydGlvbnMoKyks IDEzIGRlbGV0aW9ucygtKQo+IAo+IGRpZmYgLS1naXQgYS90ZXN0cy9rbXNfZnJvbnRidWZmZXJf dHJhY2tpbmcuYwo+IGIvdGVzdHMva21zX2Zyb250YnVmZmVyX3RyYWNraW5nLmMKPiBpbmRleCA3 ZWEyZjY5NzE4NGQuLjJjZWMzMGRhMjc1MCAxMDA2NDQKPiAtLS0gYS90ZXN0cy9rbXNfZnJvbnRi dWZmZXJfdHJhY2tpbmcuYwo+ICsrKyBiL3Rlc3RzL2ttc19mcm9udGJ1ZmZlcl90cmFja2luZy5j Cj4gQEAgLTExMjksMTQgKzExMjksMTQgQEAgc3RhdGljIHZvaWQgdW5zZXRfYWxsX2NydGNzKHZv aWQpCj4gIAlpZ3RfZGlzcGxheV9jb21taXQoJmRybS5kaXNwbGF5KTsKPiAgfQo+ICAKPiAtc3Rh dGljIHZvaWQgZGlzYWJsZV9mZWF0dXJlcyhjb25zdCBzdHJ1Y3QgdGVzdF9tb2RlICp0KQo+ICtz dGF0aWMgYm9vbCBkaXNhYmxlX2ZlYXR1cmVzKGNvbnN0IHN0cnVjdCB0ZXN0X21vZGUgKnQpCj4g IHsKPiAgCWlmICh0LT5mZWF0dXJlID09IEZFQVRVUkVfREVGQVVMVCkKPiAtCQlyZXR1cm47Cj4g KwkJcmV0dXJuIGZhbHNlOwo+ICAKPiAgCWZiY19kaXNhYmxlKCk7Cj4gLQlwc3JfZGlzYWJsZShk cm0uZGVidWdmcyk7Cj4gIAlkcnJzX2Rpc2FibGUoKTsKPiArCXJldHVybiBwc3JfZGlzYWJsZShk cm0uZGVidWdmcyk7Cj4gIH0KPiAgCj4gIHN0YXRpYyB2b2lkICpidXN5X3RocmVhZF9mdW5jKHZv aWQgKmRhdGEpCj4gQEAgLTEyMjAsNyArMTIyMCw3IEBAIHN0YXRpYyB2b2lkIGluaXRfYmx1ZV9j cmMoZW51bSBwaXhlbF9mb3JtYXQKPiBmb3JtYXQpCj4gIAo+ICAJcHJpbnRfY3JjKCJCbHVlIENS QzogICIsICZibHVlX2NyY3NbZm9ybWF0XS5jcmMpOwo+ICAKPiAtCXVuc2V0X2FsbF9jcnRjcygp Owo+ICsJaWd0X2Rpc3BsYXlfcmVzZXQoJmRybS5kaXNwbGF5KTsKPiAgCj4gIAlpZ3RfcmVtb3Zl X2ZiKGRybS5mZCwgJmJsdWUpOwo+ICAKPiBAQCAtMTI3Miw3ICsxMjcyLDcgQEAgc3RhdGljIHZv aWQgaW5pdF9jcmNzKGVudW0gcGl4ZWxfZm9ybWF0IGZvcm1hdCwKPiAgCQlwcmludF9jcmMoIiIs ICZwYXR0ZXJuLT5jcmNzW2Zvcm1hdF1bcl0pOwo+ICAJfQo+ICAKPiAtCXVuc2V0X2FsbF9jcnRj cygpOwo+ICsJaWd0X2Rpc3BsYXlfcmVzZXQoJmRybS5kaXNwbGF5KTsKPiAgCj4gIAlmb3IgKHIg PSAwOyByIDwgcGF0dGVybi0+bl9yZWN0czsgcisrKQo+ICAJCWlndF9yZW1vdmVfZmIoZHJtLmZk LCAmdG1wX2Zic1tyXSk7Cj4gQEAgLTE2OTUsNiArMTY5NSwyMiBAQCBzdGF0aWMgdm9pZCBlbmFi bGVfc2NuZF9zY3JlZW5fYW5kX3dhaXQoY29uc3QKPiBzdHJ1Y3QgdGVzdF9tb2RlICp0KQo+ICAJ ZG9fYXNzZXJ0aW9ucyhBU1NFUlRfTk9fQUNUSU9OX0NIQU5HRSk7Cj4gIH0KPiAgCj4gK3N0YXRp YyB2b2lkIGVuYWJsZV9ib3RoX3NjcmVlbnNfYW5kX3dhaXQoY29uc3Qgc3RydWN0IHRlc3RfbW9k ZSAqdCkKPiArewo+ICsJZmlsbF9mYl9yZWdpb24oJnByaW1fbW9kZV9wYXJhbXMucHJpbWFyeSwg Q09MT1JfUFJJTV9CRyk7Cj4gKwlmaWxsX2ZiX3JlZ2lvbigmc2NuZF9tb2RlX3BhcmFtcy5wcmlt YXJ5LCBDT0xPUl9TQ05EX0JHKTsKPiArCj4gKwlfX3NldF9tb2RlX2Zvcl9wYXJhbXMoJnByaW1f bW9kZV9wYXJhbXMpOwo+ICsJX19zZXRfbW9kZV9mb3JfcGFyYW1zKCZzY25kX21vZGVfcGFyYW1z KTsKPiArCj4gKwlpZ3RfZGlzcGxheV9jb21taXQyKCZkcm0uZGlzcGxheSwgZHJtLmRpc3BsYXku aXNfYXRvbWljID8KPiBDT01NSVRfQVRPTUlDIDogQ09NTUlUX0xFR0FDWSk7Cj4gKwo+ICsJd2Fu dGVkX2NyYyA9ICZibHVlX2NyY3NbdC0+Zm9ybWF0XS5jcmM7Cj4gKwlmYmNfdXBkYXRlX2xhc3Rf YWN0aW9uKCk7Cj4gKwo+ICsJZG9fYXNzZXJ0aW9ucyhBU1NFUlRfTk9fQUNUSU9OX0NIQU5HRSk7 Cj4gK30KPiArCj4gIHN0YXRpYyB2b2lkIHNldF9yZWdpb25fZm9yX3Rlc3QoY29uc3Qgc3RydWN0 IHRlc3RfbW9kZSAqdCwKPiAgCQkJCXN0cnVjdCBmYl9yZWdpb24gKnJlZykKPiAgewo+IEBAIC0x NzA5LDE3ICsxNzI1LDIxIEBAIHN0YXRpYyB2b2lkIHNldF9yZWdpb25fZm9yX3Rlc3QoY29uc3Qg c3RydWN0Cj4gdGVzdF9tb2RlICp0LAo+ICAJZG9fYXNzZXJ0aW9ucyhBU1NFUlRfTk9fQUNUSU9O X0NIQU5HRSk7Cj4gIH0KPiAgCj4gLXN0YXRpYyB2b2lkIGVuYWJsZV9mZWF0dXJlc19mb3JfdGVz dChjb25zdCBzdHJ1Y3QgdGVzdF9tb2RlICp0KQo+ICtzdGF0aWMgYm9vbCBlbmFibGVfZmVhdHVy ZXNfZm9yX3Rlc3QoY29uc3Qgc3RydWN0IHRlc3RfbW9kZSAqdCkKPiAgewo+ICsJYm9vbCByZXQg PSBmYWxzZTsKPiArCj4gIAlpZiAodC0+ZmVhdHVyZSA9PSBGRUFUVVJFX0RFRkFVTFQpCj4gLQkJ cmV0dXJuOwo+ICsJCXJldHVybiBmYWxzZTsKPiAgCj4gIAlpZiAodC0+ZmVhdHVyZSAmIEZFQVRV UkVfRkJDKQo+ICAJCWZiY19lbmFibGUoKTsKPiAgCWlmICh0LT5mZWF0dXJlICYgRkVBVFVSRV9Q U1IpCj4gLQkJcHNyX2VuYWJsZShkcm0uZGVidWdmcyk7Cj4gKwkJcmV0ID0gcHNyX2VuYWJsZShk cm0uZGVidWdmcyk7Cj4gIAlpZiAodC0+ZmVhdHVyZSAmIEZFQVRVUkVfRFJSUykKPiAgCQlkcnJz X2VuYWJsZSgpOwo+ICsKPiArCXJldHVybiByZXQ7Cj4gIH0KPiAgCj4gIHN0YXRpYyB2b2lkIGNo ZWNrX3Rlc3RfcmVxdWlyZW1lbnRzKGNvbnN0IHN0cnVjdCB0ZXN0X21vZGUgKnQpCj4gQEAgLTE4 MDEsMjggKzE4MjEsNDAgQEAgc3RhdGljIHZvaWQgc2V0X2NydGNfZmJzKGNvbnN0IHN0cnVjdAo+ IHRlc3RfbW9kZSAqdCkKPiAgc3RhdGljIHZvaWQgcHJlcGFyZV9zdWJ0ZXN0X2RhdGEoY29uc3Qg c3RydWN0IHRlc3RfbW9kZSAqdCwKPiAgCQkJCSBzdHJ1Y3QgZHJhd19wYXR0ZXJuX2luZm8gKnBh dHRlcm4pCj4gIHsKPiArCWJvb2wgbmVlZF9tb2Rlc2V0Owo+ICsKPiAgCWNoZWNrX3Rlc3RfcmVx dWlyZW1lbnRzKHQpOwo+ICAKPiAgCXN0b3BfYnVzeV90aHJlYWQoKTsKPiAgCj4gLQlkaXNhYmxl X2ZlYXR1cmVzKHQpOwo+ICsJbmVlZF9tb2Rlc2V0ID0gZGlzYWJsZV9mZWF0dXJlcyh0KTsKPiAg CXNldF9jcnRjX2Zicyh0KTsKPiAgCj4gIAlpZiAodC0+c2NyZWVuID09IFNDUkVFTl9PRkZTQ1JF RU4pCj4gIAkJZmlsbF9mYl9yZWdpb24oJm9mZnNjcmVlbl9mYiwgQ09MT1JfT0ZGU0NSRUVOX0JH KTsKPiAgCj4gLQl1bnNldF9hbGxfY3J0Y3MoKTsKPiArCWlndF9kaXNwbGF5X3Jlc2V0KCZkcm0u ZGlzcGxheSk7Cj4gKwlpZiAobmVlZF9tb2Rlc2V0KQo+ICsJCWlndF9kaXNwbGF5X2NvbW1pdCgm ZHJtLmRpc3BsYXkpOwo+ICAKPiAgCWluaXRfYmx1ZV9jcmModC0+Zm9ybWF0KTsKPiAgCWlmIChw YXR0ZXJuKQo+ICAJCWluaXRfY3Jjcyh0LT5mb3JtYXQsIHBhdHRlcm4pOwo+ICAKPiAtCWVuYWJs ZV9mZWF0dXJlc19mb3JfdGVzdCh0KTsKPiArCWlndF9kaXNwbGF5X3Jlc2V0KCZkcm0uZGlzcGxh eSk7CgpCb3RoIGluaXRfYmx1ZV9jcmMoKSBhbmQgaW5pdF9jcmMoKSBjYWxsIGlndF9kaXNwbGF5 X3Jlc2V0KCkuIFdoeSBpcyBhCmFub3RoZXIgcmVzZXQgcmVxdWlyZWQgaGVyZT8KCkZlZWwgbGlr ZSB0aGVyZSdzIHRvbyBtdWNoIGdvaW5nIG9uIGluIHRoaXMgb25lIHBhdGNoLiBDYW4geW91IHBs ZWFzZQpzcGxpdCB0aGUgbW9kZXNldCBlbGltaW5hdGlvbnMgeW91IGFyZSBpbXBsZW1lbnRpbmc/ IEkgdGhpbmsgY2hhbmdlcwpjb3JyZXNwb25kaW5nIHRvIFBTUiBlbmFibGluZywgQ1JDIGluaXRp YWxpemF0aW9uIGFuZCB0aGUgcmVmYWN0b3JpbmcKb2YgZW5hYmxlX2JvdGhfc2NyZWVuc19hbmRf d2FpdCgpIGFsbCB3YXJyYW50IHRvIGJlIGluZGl2aWR1YWwgcGF0Y2hlcy4KCgotREsKCj4gKwo+ ICsJbmVlZF9tb2Rlc2V0ID0gZW5hYmxlX2ZlYXR1cmVzX2Zvcl90ZXN0KHQpOwo+ICsJaWYgKG5l ZWRfbW9kZXNldCkKPiArCQlpZ3RfZGlzcGxheV9jb21taXQoJmRybS5kaXNwbGF5KTsKPiAgfQo+ ICAKPiAgc3RhdGljIHZvaWQgcHJlcGFyZV9zdWJ0ZXN0X3NjcmVlbnMoY29uc3Qgc3RydWN0IHRl c3RfbW9kZSAqdCkKPiAgewo+IC0JZW5hYmxlX3ByaW1fc2NyZWVuX2FuZF93YWl0KHQpOwo+ICsJ aWYgKHQtPnBpcGVzID09IFBJUEVfRFVBTCkKPiArCQllbmFibGVfYm90aF9zY3JlZW5zX2FuZF93 YWl0KHQpOwo+ICsJZWxzZQo+ICsJCWVuYWJsZV9wcmltX3NjcmVlbl9hbmRfd2FpdCh0KTsKPiAr Cj4gIAlpZiAodC0+c2NyZWVuID09IFNDUkVFTl9QUklNKSB7Cj4gIAkJaWYgKHQtPnBsYW5lID09 IFBMQU5FX0NVUikKPiAgCQkJc2V0X3JlZ2lvbl9mb3JfdGVzdCh0LAo+ICZwcmltX21vZGVfcGFy YW1zLmN1cnNvcik7Cj4gQEAgLTE4MzMsNyArMTg2NSw2IEBAIHN0YXRpYyB2b2lkIHByZXBhcmVf c3VidGVzdF9zY3JlZW5zKGNvbnN0Cj4gc3RydWN0IHRlc3RfbW9kZSAqdCkKPiAgCWlmICh0LT5w aXBlcyA9PSBQSVBFX1NJTkdMRSkKPiAgCQlyZXR1cm47Cj4gIAo+IC0JZW5hYmxlX3NjbmRfc2Ny ZWVuX2FuZF93YWl0KHQpOwo+ICAJaWYgKHQtPnNjcmVlbiA9PSBTQ1JFRU5fU0NORCkgewo+ICAJ CWlmICh0LT5wbGFuZSA9PSBQTEFORV9DVVIpCj4gIAkJCXNldF9yZWdpb25fZm9yX3Rlc3QodCwK PiAmc2NuZF9tb2RlX3BhcmFtcy5jdXJzb3IpOwotLSAKLURLCl9fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fCmlndC1kZXYgbWFpbGluZyBsaXN0CmlndC1kZXZA bGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxt YW4vbGlzdGluZm8vaWd0LWRldgo=