Re: [igt-dev] [PATCH i-g-t 2/2] tests/kms_rotation_crc: Check requested format/mod combo is supported

["Kahola, Mika" <mika.kahola@intel.com>]

On Mon, 2019-10-07 at 22:52 +0300, Juha-Pekka Heikkila wrote:
> Avoid failing test for wrong reasons.
> 
> Signed-off-by: Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com>
Nitpick with checkpatch: 

checkpatch.pl 0002-tests-kms_rotation_crc-Check-requested-format-mod-
co.patch ERROR: trailing whitespace
#22: FILE: tests/kms_rotation_crc.c:254:
+^I/* $

total: 1 errors, 0 warnings, 12 lines checked

NOTE: For some of the reported defects, checkpatch may be able to
      mechanically convert to the typical style using --fix or --fix-
inplace.

NOTE: Whitespace errors detected.
      You may wish to use scripts/cleanpatch or scripts/cleanfile

0002-tests-kms_rotation_crc-Check-requested-format-mod-co.patch has
style problems, please review.

NOTE: If any of the errors are false positives, please report
      them to the maintainer, see CHECKPATCH in MAINTAINERS.

With that fixed, this is 

Reviewed-by: Mika Kahola <mika.kahola@intel.com>

> ---
>  tests/kms_rotation_crc.c | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/tests/kms_rotation_crc.c b/tests/kms_rotation_crc.c
> index 668c173..fe63311 100644
> --- a/tests/kms_rotation_crc.c
> +++ b/tests/kms_rotation_crc.c
> @@ -251,6 +251,12 @@ static void prepare_fbs(data_t *data,
> igt_output_t *output,
>  		igt_swap(w, h);
>  	}
>  
> +	/* 
> +	 * Just try here if requested tiling format is generally
> available,
> +	 * if one format fail it will skip entire subtest.
> +	 */
> +	igt_require(igt_display_has_format_mod(display, pixel_format,
> tiling));
> +
>  	/*
>  	 * Create a reference software rotated flip framebuffer.
>  	 */
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev