From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm1-x334.google.com (mail-wm1-x334.google.com [IPv6:2a00:1450:4864:20::334]) by gabe.freedesktop.org (Postfix) with ESMTPS id DB8D510E1B5 for ; Tue, 10 Oct 2023 07:50:23 +0000 (UTC) Received: by mail-wm1-x334.google.com with SMTP id 5b1f17b1804b1-405361bb9f7so49223395e9.2 for ; Tue, 10 Oct 2023 00:50:23 -0700 (PDT) Message-ID: <46fd9f27-b874-c7a4-e992-b29c77b7cb89@gmail.com> Date: Tue, 10 Oct 2023 10:50:15 +0300 MIME-Version: 1.0 Content-Language: en-US To: "Sharma, Swati2" , igt-dev@lists.freedesktop.org References: <20231009182507.390403-1-juhapekka.heikkila@gmail.com> <169688131397.24833.6731791529433237239@emeril.freedesktop.org> <204d9c5e-86e6-4faf-becd-5e5cbac15fb5@intel.com> From: Juha-Pekka Heikkila In-Reply-To: <204d9c5e-86e6-4faf-becd-5e5cbac15fb5@intel.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Subject: Re: [igt-dev] =?utf-8?b?4pyTIEZpLkNJLkJBVDogc3VjY2VzcyBmb3IgdGVzdHMv?= =?utf-8?q?kms=5Fplane=3A_test_odd_size_planar_yuv?= List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: juhapekka.heikkila@gmail.com Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" List-ID: Hei Swati, On 10.10.2023 9.22, Sharma, Swati2 wrote: > Hi JP > > Overall patch looks good. One review comment we had from Lucas before, > "It's also odd from a testing perspective since we are testing a > *negative*, in test_*invalid*_settings(), and then expecting it to be > valid.  Should we need to improve the test, maybe being more specific on > its name? Example: odd-width-nv12 / odd-height-nv12" > > Should we rename test? With current name, it seems its a negative test. yes, we should rename this test. In fact I had done it as discussed earlier but that change made it only to commit message while that renaming change in source code I'll need to amend to my patch and send again. :) /Juha-Pekka > > On 10-Oct-23 1:25 AM, Patchwork wrote: >> *Patch Details* >> *Series:*    tests/kms_plane: test odd size planar yuv >> *URL:*    https://patchwork.freedesktop.org/series/124848/ >> >> *State:*    success >> *Details:* >> https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9954/index.html >> >> >> >>   CI Bug Log - changes from IGT_7523 -> IGTPW_9954 >> >> >>     Summary >> >> *SUCCESS* >> >> No regressions found. >> >> External URL: >> https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9954/index.html >> >> >>     Participating hosts (37 -> 36) >> >> Additional (1): fi-kbl-soraka >> Missing (2): fi-hsw-4770 fi-snb-2520m >> >> >>     Known issues >> >> Here are the changes found in IGTPW_9954 that come from known issues: >> >> >>       IGT changes >> >> >>         Issues hit >> >>   * >> >>     igt@gem_huc_copy@huc-copy: >> >>       o fi-kbl-soraka: NOTRUN -> SKIP >> >> (fdo#109271 / i915#2190 ) >>   * >> >>     igt@gem_lmem_swapping@basic: >> >>       o fi-kbl-soraka: NOTRUN -> SKIP >> >> (fdo#109271 / i915#4613 ) +3 other tests skip >>   * >> >>     igt@gem_lmem_swapping@random-engines: >> >>       o fi-bsw-n3050: NOTRUN -> SKIP >> >> (fdo#109271 ) +18 other tests skip >>   * >> >>     igt@i915_selftest@live@gt_pm: >> >>       o fi-kbl-soraka: NOTRUN -> DMESG-FAIL >> >> (i915#1886 ) >>   * >> >>     igt@kms_dsc@dsc-basic: >> >>       o fi-kbl-soraka: NOTRUN -> SKIP >> >> (fdo#109271 ) +9 other tests skip >>   * >> >>     igt@kms_frontbuffer_tracking@basic: >> >>       o fi-bsw-nick: PASS >> >> -> FAIL (i915#9276 ) >>   * >> >>     igt@kms_hdmi_inject@inject-audio: >> >>       o >> >>         fi-kbl-guc: PASS >> >> -> FAIL (IGT#3 ) >> >>       o >> >>         fi-bsw-n3050: NOTRUN -> FAIL >> >> (IGT#3 ) >> >> >>         Possible fixes >> >>   * igt@i915_selftest@live@gt_heartbeat: >>       o fi-apl-guc: DMESG-FAIL >> >> (i915#5334 ) -> PASS >> >> {name}: This element is suppressed. This means it is ignored when >> computing >> the status of the difference (SUCCESS, WARNING, or FAILURE). >> >> >>     Build changes >> >>   * CI: CI-20190529 -> None >>   * IGT: IGT_7523 -> IGTPW_9954 >> >> CI-20190529: 20190529 >> CI_DRM_13730: 1c99af947eb335283794db0644648dc4b40f44cd @ >> git://anongit.freedesktop.org/gfx-ci/linux >> IGTPW_9954: >> https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9954/index.html >> IGT_7523: 361c2f92f1fe5641090f2fc59951fcaba15387f5 @ >> https://gitlab.freedesktop.org/drm/igt-gpu-tools.git >>