From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM12-MW2-obe.outbound.protection.outlook.com (mail-mw2nam12on2089.outbound.protection.outlook.com [40.107.244.89]) by gabe.freedesktop.org (Postfix) with ESMTPS id B6DA710E009 for ; Tue, 22 Aug 2023 22:11:42 +0000 (UTC) Message-ID: <498c41b0-d041-67ad-e7ea-1ebc809974c5@nvidia.com> Date: Tue, 22 Aug 2023 15:11:36 -0700 Content-Language: en-US To: igt-dev@lists.freedesktop.org From: Erik Kurzinger Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [igt-dev] [PATCH v2] syncobj_timeline: don't expect EINVAL for WAIT_UNSUBMITTED, | WAIT_AVAILABLE List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" List-ID: The syncobj_timeline test expects waiting for an unsubmitted fence with the WAIT_AVAILABLE flag set to fail with EINVAL. While this matches the behavior of current kernels, that behavior is incorrect and will be fixed by https://lists.freedesktop.org/archives/dri-devel/2023-August/418710.html With that fix, the WAIT_AVAILABLE flag will have the intended semantics of waiting for an unsubmitted fence to be submitted instead of failing. Note that this will cause the test to fail with kernels that lack the fix, but such failures will reflect a genuine defect. Signed-off-by: Erik Kurzinger Reviewed-by: Zbigniew Kempczyński --- tests/syncobj_timeline.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/syncobj_timeline.c b/tests/syncobj_timeline.c index b4e1d093a..0422bca51 100644 --- a/tests/syncobj_timeline.c +++ b/tests/syncobj_timeline.c @@ -1782,7 +1782,7 @@ igt_main WAIT_SIGNALED)) != 1) continue; - if ((flags & WAIT_UNSUBMITTED) && !(flags & WAIT_FOR_SUBMIT)) + if ((flags & WAIT_UNSUBMITTED) && !((flags & WAIT_FOR_SUBMIT) || (flags & WAIT_AVAILABLE))) err = -EINVAL; else if (!(flags & WAIT_SIGNALED) && !((flags & WAIT_SUBMITTED) && (flags & WAIT_AVAILABLE))) err = -ETIME; @@ -1851,7 +1851,7 @@ igt_main continue; err = 0; - if ((flags & WAIT_UNSUBMITTED) && !(flags & WAIT_FOR_SUBMIT)) { + if ((flags & WAIT_UNSUBMITTED) && !((flags & WAIT_FOR_SUBMIT) || (flags & WAIT_AVAILABLE))) { err = -EINVAL; } else if (flags & WAIT_ALL) { if (flags & (WAIT_UNSUBMITTED | WAIT_SUBMITTED)) -- 2.41.0