From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by gabe.freedesktop.org (Postfix) with ESMTPS id 7C4BF89159 for ; Mon, 14 Jan 2019 15:55:22 +0000 (UTC) From: "Kalamarz, Lukasz" Date: Mon, 14 Jan 2019 15:55:20 +0000 Message-ID: <4b44e8164060e99e7d67c8a5727d23ae659b06a6.camel@intel.com> References: <20190111161548.15732-1-lukasz.kalamarz@intel.com> In-Reply-To: Content-Language: en-US Content-ID: <05EA90FDC9F74641BDA2CD4BDF93ADD1@intel.com> MIME-Version: 1.0 Subject: Re: [igt-dev] [PATCH i-g-t v3 1/4] lib/ioctl_wrapper: use defines for get_param instead of param number List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" To: "Ceraolo Spurio, Daniele" , "igt-dev@lists.freedesktop.org" List-ID: T24gRnJpLCAyMDE5LTAxLTExIGF0IDA5OjU0IC0wODAwLCBEYW5pZWxlIENlcmFvbG8gU3B1cmlv IHdyb3RlOg0KPiANCj4gT24gMDEvMTEvMjAxOSAwODoxNSBBTSwgTHVrYXN6IEthbGFtYXJ6IHdy b3RlOg0KPiA+IEluIGxpYiBjb2RlIHRoZXJlIHdlcmUgZmV3IGZ1bmN0aW9ucyB1c2luZyBwYXJh bSBudW1iZXIgaW5zdGVhZCBvZg0KPiA+IGRlZmluZXMuIFRoaXMgY291bGQgbGVhZCB0byBzb21l IGlzc3VlcyAoaS5lLiBzdG9sZW4gc3VwcG9ydA0KPiA+IHBvaW50aW5nIG9uIGRpZmZlcmVudCBw YXJhbWV0ZXIpIGFuZCB3ZSB3b3VsZCBsaWtlIHRvIGF2b2lkIHRoZW0uDQo+IA0KPiBUaGUgMyBk ZWZpbmVzIHlvdSdyZSB0b3VjaGluZyBhcmUgcGFydCBvZiB0aGUgcHVibGlzaGVkIGtlcm5lbCB1 YXBpLA0KPiBzbyANCj4gdGhlcmUgaXMgbm8gd2F5IGZvciB0aGVtIHRvIGNoYW5nZSBhbmQgY2F1 c2UgaXNzdWVzLiBUaGUgY2hhbmdlIGlzIA0KDQoNCkluIHRoZW9yeSB3aGF0IFlvdSd2ZSBzYWlk IGlzIHRydWUsIGJ1dCB3ZSBoYWQgb25lIGV4YW1wbGUgd2l0aGluIElHVA0KdGhhdCBtYXkgYmUg Y2F1c2luZyB0cm91Ymxlcy4gV2UgaGFkIGdlbV9zdG9sZW4gaXNzdWUsIHdoZXJlIHdlIGFyZQ0K cG9pbnRpbmcgdG8gcGFyYW0gd2l0aCBkaXJlY3QgbnVtYmVyICgzOCksIGJ1dCB0aGVuIHVhcGkg aXMgcG9pbnRpbmcgb24NCnNvbWV0aGluZyBkaWZmZXJlbnQgKGNoYW5nZXMgaW4gaTkxNSBmb3Ig c3RvbGUgc3VwcG9ydCB3ZXJlIG5ldmVyDQptZXJnZWQpLiBXaGVuIHJ1bm5pbmcgdGhvc2UgdGVz dHMgKG9ubHkgaGliZXJuYXRlIHRlc3RjYXNlIGlzIG5vdCBydW4NCmluIGR1cmluZyBmdWxscnVu IGV4ZWN1dGlvbnMpIHdlIG1heSBiZSB0b3VjaGluZyBzb21ldGhpbmcgZGlmZmVyZW50DQp0aGFu IHdlIGV4cGVjdC4NCg0KPiBzdGlsbCANCj4gd29ydGggZG9pbmcgSU1PIHNpbmNlIGRlZmluZXMg YXJlIGJldHRlciB0aGFuIGhhcmQtY29kZWQgbnVtYmVycy4NCj4gDQo+ID4gdjI6IFJlYmFzZWQg cGF0Y2gNCj4gPiANCj4gPiBTaWduZWQtb2ZmLWJ5OiBMdWthc3ogS2FsYW1hcnogPGx1a2Fzei5r YWxhbWFyekBpbnRlbC5jb20+DQo+ID4gQ2M6IE1pY2hhbCBXaW5pYXJza2kgPG1pY2hhbC53aW5p YXJza2lAaW50ZWwuY29tPg0KPiA+IENjOiBLYXRhcnp5bmEgRGVjIDxrYXRhcnp5bmEuZGVjQGlu dGVsLmNvbT4NCj4gPiBDYzogRGFuaWVsZSBDZXJhb2xvIFNwdXJpbyA8ZGFuaWVsZS5jZXJhb2xv c3B1cmlvQGludGVsLmNvbT4NCj4gPiBDYzogQ2hyaXMgV2lsc29uIDxjaHJpc0BjaHJpcy13aWxz b24uY28udWs+DQo+IA0KPiBBbGwgMyBkZWZzIGFyZSBpbiB0aGUgaTkxNV9kcm0uaCBmaWxlIGlu IElHVCwgc28gd2l0aCBhIGNsZWFuZWQNCj4gY29tbWl0IA0KPiBtZXNzYWdlOg0KPiANCj4gUmV2 aWV3ZWQtYnk6IERhbmllbGUgQ2VyYW9sbyBTcHVyaW8gPGRhbmllbGUuY2VyYW9sb3NwdXJpb0Bp bnRlbC5jb20+DQo+IA0KPiA+IC0tLQ0KPiA+ICAgbGliL2lvY3RsX3dyYXBwZXJzLmMgfCA2ICsr Ky0tLQ0KPiA+ICAgMSBmaWxlIGNoYW5nZWQsIDMgaW5zZXJ0aW9ucygrKSwgMyBkZWxldGlvbnMo LSkNCj4gPiANCj4gPiBkaWZmIC0tZ2l0IGEvbGliL2lvY3RsX3dyYXBwZXJzLmMgYi9saWIvaW9j dGxfd3JhcHBlcnMuYw0KPiA+IGluZGV4IDlmMjU1NTA4Li5mNzFmMGUzMiAxMDA2NDQNCj4gPiAt LS0gYS9saWIvaW9jdGxfd3JhcHBlcnMuYw0KPiA+ICsrKyBiL2xpYi9pb2N0bF93cmFwcGVycy5j DQo+ID4gQEAgLTcwOCwxMiArNzA4LDEyIEBAIGJvb2wgZ2VtX21tYXBfX2hhc193YyhpbnQgZmQp DQo+ID4gICAJCWhhc193YyA9IDA7DQo+ID4gICANCj4gPiAgIAkJbWVtc2V0KCZncCwgMCwgc2l6 ZW9mKGdwKSk7DQo+ID4gLQkJZ3AucGFyYW0gPSA0MDsgLyogTU1BUF9HVFRfVkVSU0lPTiAqLw0K PiA+ICsJCWdwLnBhcmFtID0gSTkxNV9QQVJBTV9NTUFQX0dUVF9WRVJTSU9OOw0KPiA+ICAgCQln cC52YWx1ZSA9ICZndHRfdmVyc2lvbjsNCj4gPiAgIAkJaW9jdGwoZmQsIERSTV9JT0NUTF9JOTE1 X0dFVFBBUkFNLCAmZ3ApOw0KPiA+ICAgDQo+ID4gICAJCW1lbXNldCgmZ3AsIDAsIHNpemVvZihn cCkpOw0KPiA+IC0JCWdwLnBhcmFtID0gMzA7IC8qIE1NQVBfVkVSU0lPTiAqLw0KPiA+ICsJCWdw LnBhcmFtID0gSTkxNV9QQVJBTV9NTUFQX1ZFUlNJT047DQo+ID4gICAJCWdwLnZhbHVlID0gJm1t YXBfdmVyc2lvbjsNCj4gPiAgIAkJaW9jdGwoZmQsIERSTV9JT0NUTF9JOTE1X0dFVFBBUkFNLCAm Z3ApOw0KPiA+ICAgDQo+ID4gQEAgLTk2NCw3ICs5NjQsNyBAQCBzdGF0aWMgaW50IGdlbV9ndHRf dHlwZShpbnQgZmQpDQo+ID4gICAJaW50IHZhbCA9IDA7DQo+ID4gICANCj4gPiAgIAltZW1zZXQo JmdwLCAwLCBzaXplb2YoZ3ApKTsNCj4gPiAtCWdwLnBhcmFtID0gMTg7IC8qIEhBU19BTElBU0lO R19QUEdUVCAqLw0KPiA+ICsJZ3AucGFyYW0gPSBJOTE1X1BBUkFNX0hBU19BTElBU0lOR19QUEdU VDsNCj4gPiAgIAlncC52YWx1ZSA9ICZ2YWw7DQo+ID4gICANCj4gPiAgIAlpZiAoaW9jdGwoZmQs IERSTV9JT0NUTF9JOTE1X0dFVFBBUkFNLCAmZ3AsIHNpemVvZihncCkpKQ0KPiA+IA0KX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KaWd0LWRldiBtYWlsaW5n IGxpc3QKaWd0LWRldkBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVz a3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pZ3QtZGV2Cg==