From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: References: <20190322092155.1656-1-chris@chris-wilson.co.uk> <20190322092155.1656-12-chris@chris-wilson.co.uk> From: Tvrtko Ursulin Message-ID: <4bd49529-d2b2-330f-a1ef-f93888d6dd8e@linux.intel.com> Date: Tue, 26 Mar 2019 10:14:49 +0000 MIME-Version: 1.0 In-Reply-To: <20190322092155.1656-12-chris@chris-wilson.co.uk> Content-Language: en-US Subject: Re: [igt-dev] [PATCH i-g-t 12/24] lib/i915: Improve gem_context error messages List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" To: Chris Wilson , intel-gfx@lists.freedesktop.org Cc: igt-dev@lists.freedesktop.org List-ID: Ck9uIDIyLzAzLzIwMTkgMDk6MjEsIENocmlzIFdpbHNvbiB3cm90ZToKPiBBdm9pZCBlbWJlZGRp bmcgdGhlIERSTV9JT0NUTCgpIG1hY3JvIGludG8gdGhlIGVycm9yIG1lc3NhZ2UgYXMgaXQgaXMK PiB1bnJlYWRhYmxlLCBhbmQgaW5zdGVhZCBhbHdheXMgd3JhcCB0aGUgaW9jdGwgd2l0aCBhIHNl bGYtZGVzY3JpcHRpdmUKPiBoZWxwZXIuCj4gCj4gU2lnbmVkLW9mZi1ieTogQ2hyaXMgV2lsc29u IDxjaHJpc0BjaHJpcy13aWxzb24uY28udWs+Cj4gLS0tCj4gICBsaWIvaTkxNS9nZW1fY29udGV4 dC5jIHwgNzIgKysrKysrKysrKysrKysrKysrKystLS0tLS0tLS0tLS0tLS0tLS0tLS0tCj4gICAx IGZpbGUgY2hhbmdlZCwgMzQgaW5zZXJ0aW9ucygrKSwgMzggZGVsZXRpb25zKC0pCj4gCj4gZGlm ZiAtLWdpdCBhL2xpYi9pOTE1L2dlbV9jb250ZXh0LmMgYi9saWIvaTkxNS9nZW1fY29udGV4dC5j Cj4gaW5kZXggMTYwMDQ2ODVlLi44YjRkNWI3MDQgMTAwNjQ0Cj4gLS0tIGEvbGliL2k5MTUvZ2Vt X2NvbnRleHQuYwo+ICsrKyBiL2xpYi9pOTE1L2dlbV9jb250ZXh0LmMKPiBAQCAtMTEzLDE2ICsx MTMsMTYgQEAgdWludDMyX3QgZ2VtX2NvbnRleHRfY3JlYXRlKGludCBmZCkKPiAgIAo+ICAgaW50 IF9fZ2VtX2NvbnRleHRfZGVzdHJveShpbnQgZmQsIHVpbnQzMl90IGN0eF9pZCkKPiAgIHsKPiAt CXN0cnVjdCBkcm1faTkxNV9nZW1fY29udGV4dF9kZXN0cm95IGRlc3Ryb3k7Cj4gLQlpbnQgcmV0 Owo+ICsJc3RydWN0IGRybV9pOTE1X2dlbV9jb250ZXh0X2Rlc3Ryb3kgZGVzdHJveSA9IHsgY3R4 X2lkIH07Cj4gKwlpbnQgZXJyID0gMDsKPiAgIAo+IC0JbWVtc2V0KCZkZXN0cm95LCAwLCBzaXpl b2YoZGVzdHJveSkpOwo+IC0JZGVzdHJveS5jdHhfaWQgPSBjdHhfaWQ7Cj4gKwlpZiAoaWd0X2lv Y3RsKGZkLCBEUk1fSU9DVExfSTkxNV9HRU1fQ09OVEVYVF9ERVNUUk9ZLCAmZGVzdHJveSkpIHsK PiArCQllcnIgPSAtZXJybm87Cj4gKwkJaWd0X2Fzc3VtZShlcnIpOwo+ICsJfQo+ICAgCj4gLQly ZXQgPSBpZ3RfaW9jdGwoZmQsIERSTV9JT0NUTF9JOTE1X0dFTV9DT05URVhUX0RFU1RST1ksICZk ZXN0cm95KTsKPiAtCWlmIChyZXQpCj4gLQkJcmV0dXJuIC1lcnJubzsKPiAtCXJldHVybiAwOwo+ ICsJZXJybm8gPSAwOwo+ICsJcmV0dXJuIGVycjsKPiAgIH0KPiAgIAo+ICAgLyoqCj4gQEAgLTEz NCwyMSArMTM0LDIwIEBAIGludCBfX2dlbV9jb250ZXh0X2Rlc3Ryb3koaW50IGZkLCB1aW50MzJf dCBjdHhfaWQpCj4gICAgKi8KPiAgIHZvaWQgZ2VtX2NvbnRleHRfZGVzdHJveShpbnQgZmQsIHVp bnQzMl90IGN0eF9pZCkKPiAgIHsKPiAtCXN0cnVjdCBkcm1faTkxNV9nZW1fY29udGV4dF9kZXN0 cm95IGRlc3Ryb3k7Cj4gLQo+IC0JbWVtc2V0KCZkZXN0cm95LCAwLCBzaXplb2YoZGVzdHJveSkp Owo+IC0JZGVzdHJveS5jdHhfaWQgPSBjdHhfaWQ7Cj4gLQo+IC0JZG9faW9jdGwoZmQsIERSTV9J T0NUTF9JOTE1X0dFTV9DT05URVhUX0RFU1RST1ksICZkZXN0cm95KTsKPiArCWlndF9hc3NlcnRf ZXEoX19nZW1fY29udGV4dF9kZXN0cm95KGZkLCBjdHhfaWQpLCAwKTsKPiAgIH0KPiAgIAo+ICAg aW50IF9fZ2VtX2NvbnRleHRfZ2V0X3BhcmFtKGludCBmZCwgc3RydWN0IGRybV9pOTE1X2dlbV9j b250ZXh0X3BhcmFtICpwKQo+ICAgewo+IC0JaWYgKGlndF9pb2N0bChmZCwgRFJNX0lPQ1RMX0k5 MTVfR0VNX0NPTlRFWFRfR0VUUEFSQU0sIHApKQo+IC0JCXJldHVybiAtZXJybm87Cj4gKwlpbnQg ZXJyID0gMDsKPiArCj4gKwlpZiAoaWd0X2lvY3RsKGZkLCBEUk1fSU9DVExfSTkxNV9HRU1fQ09O VEVYVF9HRVRQQVJBTSwgcCkpIHsKPiArCQllcnIgPSAtZXJybm87Cj4gKwkJaWd0X2Fzc3VtZShl cnIpOwo+ICsJfQo+ICAgCj4gICAJZXJybm8gPSAwOwo+IC0JcmV0dXJuIDA7Cj4gKwlyZXR1cm4g ZXJyOwo+ICAgfQo+ICAgCj4gICAvKioKPiBAQCAtMTYxLDE4ICsxNjAsMjIgQEAgaW50IF9fZ2Vt X2NvbnRleHRfZ2V0X3BhcmFtKGludCBmZCwgc3RydWN0IGRybV9pOTE1X2dlbV9jb250ZXh0X3Bh cmFtICpwKQo+ICAgICovCj4gICB2b2lkIGdlbV9jb250ZXh0X2dldF9wYXJhbShpbnQgZmQsIHN0 cnVjdCBkcm1faTkxNV9nZW1fY29udGV4dF9wYXJhbSAqcCkKPiAgIHsKPiAtCWlndF9hc3NlcnQo X19nZW1fY29udGV4dF9nZXRfcGFyYW0oZmQsIHApID09IDApOwo+ICsJaWd0X2Fzc2VydF9lcShf X2dlbV9jb250ZXh0X2dldF9wYXJhbShmZCwgcCksIDApOwo+ICAgfQo+ICAgCj4gLQo+ICAgaW50 IF9fZ2VtX2NvbnRleHRfc2V0X3BhcmFtKGludCBmZCwgc3RydWN0IGRybV9pOTE1X2dlbV9jb250 ZXh0X3BhcmFtICpwKQo+ICAgewo+IC0JaWYgKGlndF9pb2N0bChmZCwgRFJNX0lPQ1RMX0k5MTVf R0VNX0NPTlRFWFRfU0VUUEFSQU0sIHApKQo+IC0JCXJldHVybiAtZXJybm87Cj4gKwlpbnQgZXJy ID0gMDsKPiArCj4gKwlpZiAoaWd0X2lvY3RsKGZkLCBEUk1fSU9DVExfSTkxNV9HRU1fQ09OVEVY VF9TRVRQQVJBTSwgcCkpIHsKPiArCQllcnIgPSAtZXJybm87Cj4gKwkJaWd0X2Fzc3VtZShlcnIp Owo+ICsJfQo+ICAgCj4gICAJZXJybm8gPSAwOwo+IC0JcmV0dXJuIDA7Cj4gKwlyZXR1cm4gZXJy Owo+ICAgfQo+ICsKPiAgIC8qKgo+ICAgICogZ2VtX2NvbnRleHRfc2V0X3BhcmFtOgo+ICAgICog QGZkOiBvcGVuIGk5MTUgZHJtIGZpbGUgZGVzY3JpcHRvcgo+IEBAIC0xODMsNyArMTg2LDcgQEAg aW50IF9fZ2VtX2NvbnRleHRfc2V0X3BhcmFtKGludCBmZCwgc3RydWN0IGRybV9pOTE1X2dlbV9j b250ZXh0X3BhcmFtICpwKQo+ICAgICovCj4gICB2b2lkIGdlbV9jb250ZXh0X3NldF9wYXJhbShp bnQgZmQsIHN0cnVjdCBkcm1faTkxNV9nZW1fY29udGV4dF9wYXJhbSAqcCkKPiAgIHsKPiAtCWln dF9hc3NlcnQoX19nZW1fY29udGV4dF9zZXRfcGFyYW0oZmQsIHApID09IDApOwo+ICsJaWd0X2Fz c2VydF9lcShfX2dlbV9jb250ZXh0X3NldF9wYXJhbShmZCwgcCksIDApOwo+ICAgfQo+ICAgCj4g ICAvKioKPiBAQCAtMTk2LDE0ICsxOTksOSBAQCB2b2lkIGdlbV9jb250ZXh0X3NldF9wYXJhbShp bnQgZmQsIHN0cnVjdCBkcm1faTkxNV9nZW1fY29udGV4dF9wYXJhbSAqcCkKPiAgICAqLwo+ICAg dm9pZCBnZW1fY29udGV4dF9yZXF1aXJlX3BhcmFtKGludCBmZCwgdWludDY0X3QgcGFyYW0pCj4g ICB7Cj4gLQlzdHJ1Y3QgZHJtX2k5MTVfZ2VtX2NvbnRleHRfcGFyYW0gcDsKPiAtCj4gLQlwLmN0 eF9pZCA9IDA7Cj4gLQlwLnBhcmFtID0gcGFyYW07Cj4gLQlwLnZhbHVlID0gMDsKPiAtCXAuc2l6 ZSA9IDA7Cj4gKwlzdHJ1Y3QgZHJtX2k5MTVfZ2VtX2NvbnRleHRfcGFyYW0gcCA9IHsgLnBhcmFt ID0gcGFyYW0gfTsKPiAgIAo+IC0JaWd0X3JlcXVpcmUoaWd0X2lvY3RsKGZkLCBEUk1fSU9DVExf STkxNV9HRU1fQ09OVEVYVF9HRVRQQVJBTSwgJnApID09IDApOwo+ICsJaWd0X3JlcXVpcmUoX19n ZW1fY29udGV4dF9nZXRfcGFyYW0oZmQsICZwKSA9PSAwKTsKPiAgIH0KPiAgIAo+ICAgdm9pZCBn ZW1fY29udGV4dF9yZXF1aXJlX2Jhbm5hYmxlKGludCBmZCkKPiBAQCAtMjUyLDEzICsyNTAsMTEg QEAgdm9pZCBnZW1fY29udGV4dF9yZXF1aXJlX2Jhbm5hYmxlKGludCBmZCkKPiAgICAqLwo+ICAg aW50IF9fZ2VtX2NvbnRleHRfc2V0X3ByaW9yaXR5KGludCBmZCwgdWludDMyX3QgY3R4X2lkLCBp bnQgcHJpbykKPiAgIHsKPiAtCXN0cnVjdCBkcm1faTkxNV9nZW1fY29udGV4dF9wYXJhbSBwOwo+ IC0KPiAtCW1lbXNldCgmcCwgMCwgc2l6ZW9mKHApKTsKPiAtCXAuY3R4X2lkID0gY3R4X2lkOwo+ IC0JcC5zaXplID0gMDsKPiAtCXAucGFyYW0gPSBEUk1fSTkxNV9DT05URVhUX1BBUkFNX1BSSU9S SVRZOwo+IC0JcC52YWx1ZSA9IHByaW87Cj4gKwlzdHJ1Y3QgZHJtX2k5MTVfZ2VtX2NvbnRleHRf cGFyYW0gcCA9IHsKPiArCQkuY3R4X2lkID0gY3R4X2lkLAo+ICsJCS5wYXJhbSA9IERSTV9JOTE1 X0NPTlRFWFRfUEFSQU1fUFJJT1JJVFksCj4gKwkJLnZhbHVlID0gcHJpbywKPiArCX07Cj4gICAK PiAgIAlyZXR1cm4gX19nZW1fY29udGV4dF9zZXRfcGFyYW0oZmQsICZwKTsKPiAgIH0KPiBAQCAt MjczLDUgKzI2OSw1IEBAIGludCBfX2dlbV9jb250ZXh0X3NldF9wcmlvcml0eShpbnQgZmQsIHVp bnQzMl90IGN0eF9pZCwgaW50IHByaW8pCj4gICAgKi8KPiAgIHZvaWQgZ2VtX2NvbnRleHRfc2V0 X3ByaW9yaXR5KGludCBmZCwgdWludDMyX3QgY3R4X2lkLCBpbnQgcHJpbykKPiAgIHsKPiAtCWln dF9hc3NlcnQoX19nZW1fY29udGV4dF9zZXRfcHJpb3JpdHkoZmQsIGN0eF9pZCwgcHJpbykgPT0g MCk7Cj4gKwlpZ3RfYXNzZXJ0X2VxKF9fZ2VtX2NvbnRleHRfc2V0X3ByaW9yaXR5KGZkLCBjdHhf aWQsIHByaW8pLCAwKTsKPiAgIH0KPiAKClJldmlld2VkLWJ5OiBUdnJ0a28gVXJzdWxpbiA8dHZy dGtvLnVyc3VsaW5AaW50ZWwuY29tPgoKUmVnYXJkcywKClR2cnRrbwpfX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwppZ3QtZGV2IG1haWxpbmcgbGlzdAppZ3Qt ZGV2QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9t YWlsbWFuL2xpc3RpbmZvL2lndC1kZXY=