From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga06.intel.com (mga06b.intel.com [134.134.136.31]) by gabe.freedesktop.org (Postfix) with ESMTPS id B65EB10E141 for ; Thu, 16 Mar 2023 09:07:16 +0000 (UTC) Message-ID: <4c335f90-e548-2fad-f413-4b0ac4e8b48e@intel.com> Date: Thu, 16 Mar 2023 14:36:53 +0530 Content-Language: en-US References: <20230316084552.2433948-1-bhanuprakash.modem@intel.com> From: "Modem, Bhanuprakash" In-Reply-To: <20230316084552.2433948-1-bhanuprakash.modem@intel.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Subject: Re: [igt-dev] [i-g-t] lib/xe/xe_query: Fix the return type of xe_dev_id List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" To: igt-dev@lists.freedesktop.org, zbigniew.kempczynski@intel.com, mchehab@kernel.org List-ID: Hi Mauro, As discussed offline, I am adding your R-b: Reviewed-by: Mauro Carvalho Chehab - Bhanu On Thu-16-03-2023 02:15 pm, Bhanuprakash Modem wrote: > Since we are truncating the rev_dev_id value to 16 bit, the return > type of xe_dev_id() must be uint16_t. > > Fixes: cfec580a8 > Signed-off-by: Bhanuprakash Modem > --- > lib/xe/xe_query.c | 2 +- > lib/xe/xe_query.h | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/lib/xe/xe_query.c b/lib/xe/xe_query.c > index e27d14383..183523280 100644 > --- a/lib/xe/xe_query.c > +++ b/lib/xe/xe_query.c > @@ -472,7 +472,7 @@ xe_dev_FN(xe_va_bits, va_bits, uint32_t); > * > * Returns Device id of xe device @fd. > */ > -xe_dev_FN(xe_dev_id, dev_id, uint32_t); > +xe_dev_FN(xe_dev_id, dev_id, uint16_t); > > igt_constructor > { > diff --git a/lib/xe/xe_query.h b/lib/xe/xe_query.h > index 13ac77d3d..beea9d094 100644 > --- a/lib/xe/xe_query.h > +++ b/lib/xe/xe_query.h > @@ -88,7 +88,7 @@ bool xe_has_vram(int fd); > uint64_t xe_vram_size(int fd, int gt); > uint32_t xe_get_default_alignment(int fd); > uint32_t xe_va_bits(int fd); > -uint32_t xe_dev_id(int fd); > +uint16_t xe_dev_id(int fd); > bool xe_supports_faults(int fd); > const char *xe_engine_class_string(uint32_t engine_class); >