From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM11-CO1-obe.outbound.protection.outlook.com (mail-co1nam11on2071.outbound.protection.outlook.com [40.107.220.71]) by gabe.freedesktop.org (Postfix) with ESMTPS id 17B2110E423 for ; Wed, 23 Aug 2023 13:38:19 +0000 (UTC) Message-ID: <4df8e8e9-06c0-4e17-9dcb-03a815399c6e@amd.com> Date: Wed, 23 Aug 2023 09:38:14 -0400 Content-Language: en-US To: Kamil Konieczny , igt-dev@lists.freedesktop.org, Alex Hung , hersenxs.wu@amd.com, rodrigo.siqueira@amd.com, Petri Latvala References: <20230821140712.1034591-1-aurabindo.pillai@amd.com> <20230821140712.1034591-2-aurabindo.pillai@amd.com> <581a47bb-0e4c-7408-d107-5ad0e5da8c9e@amd.com> <97b7e6a3-bf81-4a17-b224-1351d8dedf53@amd.com> <20230822194558.3tebkhiztteeq7rv@kamilkon-desk.igk.intel.com> <20230823080243.sniyeayghyzw34df@kamilkon-desk.igk.intel.com> From: Aurabindo Pillai In-Reply-To: <20230823080243.sniyeayghyzw34df@kamilkon-desk.igk.intel.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Subject: Re: [igt-dev] [PATCH v4 2/2] tests/amdgpu: Add test for ODM combine List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" List-ID: On 2023-08-23 04:02, Kamil Konieczny wrote: > Hi Aurabindo, > > On 2023-08-22 at 16:18:08 -0400, Aurabindo Pillai wrote: >> >> >> On 2023-08-22 15:45, Kamil Konieczny wrote: >>> Hi Aurabindo, >>> >>> On 2023-08-21 at 16:18:42 -0400, Aurabindo Pillai wrote: >>>> Thanks for the review Alex. >>>> >>>> Kamil, >>>> >>>> There seems to be a false positive failure for this patchset: >>>> https://lists.freedesktop.org/archives/igt-dev/2023-August/060105.html >>>> >>>> Do you have any further review suggestions or is it okay to merge ? >>>> >>> >>> This is not ok, on some images your test will not build, >>> to reproduce: >>> >>> follow links from failed build to find out what image was used >>> for example here: https://gitlab.freedesktop.org/gfx-ci/igt-ci-tags/-/jobs/47853345 >>> >>> install podman, enter to igt-tools source dir, >>> then run script: >>> >>> POD_IGT=registry.freedesktop.org/gfx-ci/igt-ci-tags/build-debian:commit-26f3d20c6ff4274aeb71d4851cdf7a7cefb0a008 >>> >>> mkdir -p /tmp/igt-build >>> cp -R * /tmp/igt-build/ >>> sudo podman run -i -t -v /tmp/igt-build/:/opt/builds --privileged ${POD_IGT} >>> >>> ## end of script >>> >>> now you will have root prompt '#' inside podman image (debian), >>> enter commands: >>> >>> # cd /opt/builds >>> # meson build >>> # ninja -C build >>> >>> imho this is problem on some old(?) systems where the system >>> and/or igt headers are missing. >>> >>> Please fix this before merging. >>> >> >> Hi Kamil, >> >> Thanks for the detailed steps. The Patchwork CI showed build success, which >> is why I merged the patches. I have a oneliner fix that I'll send to the >> list. > > Well I do not see it, even now it shows build failure but there is color > issue with that (for me it is hard to diff between green and that orange). Yes, I got confused with the same. Sorry. > It shows success (green) for Fi.CI.BAT so maybe you missed GitLab.build > status. Please always look into build warnings, wait a few days for > replay as people sometimes go to vacations/meetings/conferences, ask on > irc #igt/oftc. > Will keep that in mind for future. > I also plan to add some help for container how-to or instead adding some > script into scripts/podman-example.sh. +cc Petri > > Regards, > Kamil > >> >> -- >> >> Thanks & Regards, >> Jay -- -- Thanks & Regards, Jay