Re: [igt-dev] [PATCH i-g-t 1/2] lib/gpgpu_fill/tgl: Implement gpgpu_fillfunc for TGL

Kempczynski, Zbigniew
2019-09-17T04:14:24Z

On Mon, 2019-09-16 at 18:44 +0300, Arkadiusz Hiler wrote:
> On Fri, Sep 13, 2019 at 02:49:02PM +0200, Katarzyna Dec wrote:
> >
> > + else if (IS_TIGERLAKE(devid))
> > + fill = gen12p1_gpgpu_fillfunc;
>
> I find this naming a bit odd.
>
> If you don't want to overenable it for all GEN12 because you don't know
> what the future brings I think we should go with tgl_*_fillfunc, so it's
> closer to what we do in kernel (using platform codenames as function
> prefixes). This way it isalso direcly related to check
> (IS_TIGERLAKE()).
>
> If it proves to be generic then we can alway change the check to
> IS_GEN12() or whatever and rename the function accordingly.
>
> This applies to the media variant too.
>
> Other than that looks good, let's see what the CI says.
>

First patch version had this naming convention, tgl_ as prefix,
but we got negative feedback and suggestion that function should
contain genX in the name and selection should be using IS_TIGERLAKE()
macro. Due to many reasons naming in gen12 is not easy, so imo
we've chosen best option.

Zbigniew