From: Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com>
To: Mika Kahola <mika.kahola@intel.com>, igt-dev@lists.freedesktop.org
Subject: Re: [igt-dev] [PATCH i-g-t] tests/kms_plane_scaling: Ensure minimum height and width for planar uyv formats
Date: Thu, 21 Mar 2019 11:02:25 +0200 [thread overview]
Message-ID: <4e2cd400-e6a4-d761-1b7c-3417d3ea0672@gmail.com> (raw)
In-Reply-To: <20190320092254.31807-1-mika.kahola@intel.com>
Looks good,
Reviewed-by: Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com>
On 20.3.2019 11.22, Mika Kahola wrote:
> Let's ensure that we test with minimum width and height of 16 for all planar uyv formats.
>
> References: https://bugs.freedesktop.org/show_bug.cgi?id=110098
> Signed-off-by: Mika Kahola <mika.kahola@intel.com>
> ---
> tests/kms_plane_scaling.c | 15 ++++++++++++++-
> 1 file changed, 14 insertions(+), 1 deletion(-)
>
> diff --git a/tests/kms_plane_scaling.c b/tests/kms_plane_scaling.c
> index d408a203..01f5f7c9 100644
> --- a/tests/kms_plane_scaling.c
> +++ b/tests/kms_plane_scaling.c
> @@ -60,6 +60,19 @@ static int get_num_scalers(data_t* d, enum pipe pipe)
> return 1;
> }
>
> +static bool is_planar_yuv_format(uint32_t pixelformat)
> +{
> + switch (pixelformat) {
> + case DRM_FORMAT_NV12:
> + case DRM_FORMAT_P010:
> + case DRM_FORMAT_P012:
> + case DRM_FORMAT_P016:
> + return true;
> + default:
> + return false;
> + }
> +}
> +
> static void cleanup_fbs(data_t *data)
> {
> int i;
> @@ -136,7 +149,7 @@ static void check_scaling_pipe_plane_rot(data_t *d, igt_plane_t *plane,
>
> /* create buffer in the range of min and max source side limit.*/
> width = height = 8;
> - if (pixel_format == DRM_FORMAT_NV12)
> + if (is_planar_yuv_format(pixel_format))
> width = height = 16;
> igt_create_color_fb(display->drm_fd, width, height,
> pixel_format, tiling, 0.0, 1.0, 0.0, &d->fb[0]);
>
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
prev parent reply other threads:[~2019-03-21 9:02 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-20 9:22 [igt-dev] [PATCH i-g-t] tests/kms_plane_scaling: Ensure minimum height and width for planar uyv formats Mika Kahola
2019-03-20 10:57 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2019-03-20 16:21 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
2019-03-20 16:35 ` [igt-dev] [PATCH i-g-t] " Ville Syrjälä
2019-03-21 9:08 ` Kahola, Mika
2019-03-21 9:02 ` Juha-Pekka Heikkila [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4e2cd400-e6a4-d761-1b7c-3417d3ea0672@gmail.com \
--to=juhapekka.heikkila@gmail.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=mika.kahola@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox