From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by gabe.freedesktop.org (Postfix) with ESMTPS id E13E56E30D for ; Fri, 22 Mar 2019 10:10:36 +0000 (UTC) References: <20190321160528.4131-1-andi.shyti@intel.com> <20190321160528.4131-5-andi.shyti@intel.com> <6b531677-8e74-c51c-535a-bb5e1c1f2ac7@linux.intel.com> <20190322095155.GA1557@intel.intel> From: Tvrtko Ursulin Message-ID: <4e38b160-e523-f9b0-f07e-545c281b9fd6@linux.intel.com> Date: Fri, 22 Mar 2019 10:10:33 +0000 MIME-Version: 1.0 In-Reply-To: <20190322095155.GA1557@intel.intel> Content-Language: en-US Subject: Re: [igt-dev] [PATCH v15 4/5] lib/i915: add gem_engine_topology library and for_each loop definition List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" To: Andi Shyti Cc: IGT dev , Andi Shyti List-ID: Ck9uIDIyLzAzLzIwMTkgMDk6NTEsIEFuZGkgU2h5dGkgd3JvdGU6Cj4gSGkgVHZydGtvLAo+IAo+ Pj4gK3N0YXRpYyB2b2lkIGluaXRfZW5naW5lKHN0cnVjdCBpbnRlbF9leGVjdXRpb25fZW5naW5l MiAqZTIsIGNvbnN0IGNoYXIgKm5hbWUsCj4+PiArCQkJdWludDE2X3QgY2xhc3MsIHVpbnQxNl90 IGluc3RhbmNlLCB1aW50NjRfdCBmbGFncykKPj4KPj4gWW91IGFyZSBrZWVwaW5nIG5hbWUgZm9y IHRoZSBmdXR1cmU/IChJdCBpcyB1bnVzZWQgYXQgdGhlIG1vbWVudC4pCj4gCj4gSSBzaW1wbHkg Zm9yZ290IHRvIHJlbW92ZSBpdCA6KQo+IAo+Pj4gK3sKPj4+ICsJc3RhdGljIGNvbnN0IGNoYXIg KnVua25vd25fbmFtZSA9ICJ1bmtub3duIiwKPj4+ICsJCQkgICp2aXJ0dWFsX25hbWUgPSAidmly dHVhbCI7Cj4+Cj4+IFVudXN1YWwgc3R5bGUgYnV0IGl0IGlzIGFjdHVhbGx5IHJlYWRhYmxlIHNv IEkgdGhpbmsgSSBsaWtlIGl0Lgo+IAo+IGxpa2UgdGhlIGZ1bmN0aW9uIGJlbG93LCBpdCBkb2Vz bid0IGhhcHBlbiBldmVyeWRheSB0byBkZWNsYXJlCj4gdmFyaWFibGVzL2Z1bmN0aW9ucyB3aGVy ZSB0aGUgbG9uZ2VzdCBwYXJ0IG9mIHRoZSBsaW5lIGlzIHRoZQo+IHR5cGUuCj4gCj4gTmVlZCB0 byBjb21lIG91dCB3aXRoIHNvbWV0aGluZyA6KQo+IAo+Pj4gKwo+Pj4gKwllMi0+Y2xhc3MgICAg PSBjbGFzczsKPj4+ICsJZTItPmluc3RhbmNlID0gaW5zdGFuY2U7Cj4+PiArCWUyLT5mbGFncyAg ICA9IGZsYWdzOwo+Pj4gKwo+Pj4gKwlpZiAoY2xhc3MgPCAwICYmIGluc3RhbmNlIDwgMCkgewo+ Pj4gKwkJZTItPm5hbWUgPSB2aXJ0dWFsX25hbWU7Cj4+PiArCX0gZWxzZSB7Cj4+PiArCQljb25z dCBzdHJ1Y3QgaW50ZWxfZXhlY3V0aW9uX2VuZ2luZTIgKl9fZTI7Cj4+PiArCj4+PiArCQlfX2Zv cl9lYWNoX3N0YXRpY19lbmdpbmUoX19lMikKPj4+ICsJCQlpZiAoX19lMi0+Y2xhc3MgPT0gY2xh c3MgJiYgX19lMi0+aW5zdGFuY2UgPT0gaW5zdGFuY2UpCj4+PiArCQkJCWJyZWFrOwo+Pj4gKwo+ Pj4gKwkJZTItPm5hbWUgPSBfX2UyLT5uYW1lID8gX19lMi0+bmFtZSA6IHVua25vd25fbmFtZTsK Pj4KPj4gSSd2ZSBub3cgc3RhcnRlZCB0byB3b3JyeSBhYm91dCBob3cgd2lsbCBDSS9idWdsb2cg aGFuZGxlIHVzIGZvcmdldHRpbmcgdG8KPj4gZXhwYW5kIHRoZSBzdGF0aWMgbGlzdC4gKE1vcmUg dGhhbiBvbmUgc3VidGVzdCBvZiBhIHNhbWUgbmFtZSBmb3IKPj4gInRlc3QtJGVuZ2luZV9uYW1l IiBvbmVzPykgRG8gd2Ugd2FudCBhbmQgaWd0X3dhcm4gb24gdW5rbm93biBlbmdpbmVzIHRvCj4+ IG1ha2UgaXQgbW9yZSB2aXNpYmxlPyBPciBldmVuIGp1c3QgY3Jhc2g/Cj4gCj4gUmlnaHQhIEkg Z3Vlc3MganVzdCBhIHdhcm5pbmcgd291bGQgYmUgbmljZSwgd2UgY2FuIGdhdGhlciBtb3JlCj4g aW5mb3JtYXRpb24gZnJvbSB0aGUgbG9ncyBhYm91dCB1bmtvd24gZW5naW5lcy4uLiBJIGd1ZXNz Lgo+IAo+Pj4gKwlpZiAobmVuZ2luZXMgPiBJOTE1X0VYRUNfUklOR19NQVNLICsgMSkgewo+Pj4g KwkJZW5naW5lX2RhdGEuZXJyb3IgPSByZXQgPyByZXQgOiAtRUlOVkFMOwo+Pj4gKwkJcmV0dXJu IGVuZ2luZV9kYXRhOwo+Pj4gKwl9Cj4+Cj4+IElmIHdlIG9uZSBkYXkgYWxsb3cgbW9yZSBlbmdp bmVzIGluIHRoZSBtYXAgdGhhbiB0aGUgY3VycmVudCBsaW1pdD8KPiAKPiBmb3Igbm93IHRoaXMg aXMgYSBkcml2ZXIgbGltaXRhdGlvbiBhbmQgdGhhdCdzIHdoYXQgaWd0IGNoZWNrcy4gSQo+IGd1 ZXNzIHRoZSByaWdodCBhcHByb2FjaCB3b3VsZCBiZSB0byB1cGRhdGUgaWd0IGFjY29yZGluZyB0 byB0aGUKPiBkcml2ZXIsIHJpZ2h0PwoKWWVzLCBJIHRoaW5rIG9sZCBJR1Qgb24gbmV3ZXIga2Vy bmVscyBpcyBub3Qgc29tZXRoaW5nIHdlIG5lZWQgdG8gCnN1cHBvcnQuIE9sZCBrZXJuZWwgd2l0 aCBuZXcgSUdUIHdlIHNvbWV0aW1lcywgbGlrZSBpbiB0aGlzIHNlcmllcyBkby4KCj4+IEl0IGxv b2tzIHRoaXMgd291bGQgbWFrZSB0aGUgaXRlcmF0b3Igbm90IHdvcmsuIFdhcyB0aGF0IHRoZSBp bnRlbnRpb24/IFdoYXQKPj4gaXMgdGhlIHBvaW50IG9mIGNvbnRpbnVpbmcgdGhlbiByYXRoZXIg dGhhbiBqdXN0IGFzc2VydGluZz8KPiAKPiB5ZXMsIHRoZSBpdGVyYXRvciB3b3VsZG4ndCBsb29w IGFuZCB3b3VsZCBwcm92aWRlIGEgMCBzaXplIGxpc3QKPiBvZiBlbmdpbmVzLiBBc3NlcnRpbmcg bWFrZXMgbW9yZSBzZW5zZS4KCkkgdGhpbmsgc28sIG9yIGlndF93YXJuLiBCdXQgdGhlcmUgaXMg YWxzbyB0aGUgcXVlcnkgd2hpY2ggd2lsbCBmYWlsIGlmIAp0aGlzIGxpbWl0IGlzIHN1cnBhc3Nl ZCwgZHVlIGxpbWl0ZWQgcGFzc2VkIGluIGJ1ZmZlciBzaXplLgoKTWF5YmUgYXNzZXJ0IGluIHRo ZSBxdWVyeSBvbiAtRUlOVkFMIGFuZCBhc3NlcnQgaGVyZSBpbnN0ZWFkIG9mIHRoZSAKZXJyb3Ig Y29tcGxpY2F0aW9uPwoKPj4+ICtzdHJ1Y3QgaW50ZWxfZXhlY3V0aW9uX2VuZ2luZTIKPj4+ICsJ KmludGVsX2dldF9jdXJyZW50X2VuZ2luZShzdHJ1Y3QgaW50ZWxfZW5naW5lX2RhdGEgKmVkKQo+ Pgo+PiBVbnVzdWFsIGNvZGluZyBzdHlsZSwgd2UgdXNlOgo+Pgo+PiB0eXBlCj4+IGZ1bmMocGFy YW1zKQo+Pgo+PiBvcjoKPj4KPj4gdHlwZSBmdW5jKHBhcmFtcykKPiAKPiB5ZXMsIEkndmUgc2Vl biBpdCBhcm91bmQsIEkgcGVyc29uYWxseSBkb24ndCBsaWtlIGl0LCBidXQgSSB3aWxsCj4gZG8g aXQgYXMgdGhlIHN0eWxlIGlzLgoKWWVwLCBoYXZlIHRvIGNvbXBseSB3aXRoIG91ciBzdHlsZS4K Cj4+PiArCXJldHVybiAoZWQtPm4gPCBlZC0+bmVuZ2luZXMpICYmICFlZC0+ZXJyb3IgPwo+Pj4g KwkJJmVkLT5lbmdpbmVzW2VkLT5uXSA6Cj4+PiArCQlOVUxMOwo+Pgo+PiBTbyBjb3VsZCBzdG9y ZSB0aGUgcG9pbnRlciB0byBjdXJyZW50IGVuZ2luZSBpbiB0aGUgaXRlcmF0b3I/Cj4gCj4gSSBz dGlsbCBkb24ndCBzZWUgdGhlIHVzZSBvZiBpdCwgYnV0IG9mIGNvdXJzZSwgSSBjYW4gYWRkIGl0 LiBJdAo+IG1pZ2h0IG1ha2UgbW9yZSBzZW5zZSBub3cgdGhhdCBJIGhhdmUgYSAiX2N1cnJlbnQi IGFuZCBhICJfbmV4dCIKPiBmdW5jdGlvbi4KClRoYXQgZXhhY3RseSB3aHkgSSBtZW50aW9uZWQg aXQgYWdhaW4sIGJ1dCBpdCBpcyBvZiBhIG1pbm9yIGltcG9ydGFuY2UgCmFzIGxvbmcgYXMgd2Ug YXJlIGdvaW5nIHdpdGggdGhlIGV4cGxpY2l0IGVuZ2luZSBwb2ludGVyIGluIHRoZSBmb3IgbG9v cCAKaXRlcmF0b3IuIERvIGFzIHlvdSBwcmVmZXIuCgo+Pj4gQEAgLTQzNCw3ICs0MzQsNyBAQCBi dXN5X2NoZWNrX2FsbChpbnQgZ2VtX2ZkLCBjb25zdCBzdHJ1Y3QgaW50ZWxfZXhlY3V0aW9uX2Vu Z2luZTIgKmUsCj4+PiAgICAJaSA9IDA7Cj4+PiAgICAJZmRbMF0gPSAtMTsKPj4+IC0JZm9yX2Vh Y2hfZW5naW5lX2NsYXNzX2luc3RhbmNlKGdlbV9mZCwgZV8pIHsKPj4+ICsJZm9yX2VhY2hfY29u dGV4dF9lbmdpbmUoZ2VtX2ZkLCAwLCBlXykgewo+Pgo+PiBNYWtlIHBlcmZfcG11IHVzZSBmb3Jf ZWFjaF9waHlzaWNhbF9lbmdpbmUsIGFwYXJ0IGZyb20gdGhlIHRlc3QgZW51bWVyYXRpb24uCj4g Cj4gdGhlIHJlYXNvbiBJIGRpZG4ndCByZXBsYWNlIGl0IHJpZ2h0IGF3YXkgaXMgdGhhdCBzdGls bCB0byBtYW55Cj4gZnVuY3Rpb25zIGFyZSB1c2luZyB0aGUgY3VycmVudCBpbXBsZW1lbnRhdGlv biBvZgo+IGZvcl9lYWNoX3BoeXNpY2FsX2VuZ2luZSBhbmQgSSB3YW50ZWQgdG8gYXZvaWQsIGlu IHRoaXMgcGF0Y2hzZXQsCj4gdG91Y2hpbmcgdG9vIG1hbnkgZmlsZXMuIEknbSBhbHJlYWR5IGNo YW5naW5nIG1vcmUgdGhhbiBJCj4gd2lzaGVkLgoKSXQgZG9lc24ndCBzZWVtIGxpa2UgYSBsb3Qg dG8gbWUuIEFuZCB5b3UgaGF2ZSB0byBjaGFuZ2Ugc29tZXRoaW5nIHNvIHdlIAprbm93IGl0IHdv cmtzLiA6KQoKPiB0aGF0J3Mgd2h5IEkgY2FsbGVkIGl0Ogo+IAo+ICAgICAjZGVmaW5lIF9fZm9y X2VhY2hfcGh5c2ljYWxfZW5naW5lX18oZmRfXywgZV9fKQo+IAo+IGF0IHRoZSBiZWdpbm5pbmcg SSB3YW50ZWQgdG8gY2FsbCBpdAo+IAo+ICAgICAjZGVmaW5lIF9fRE9fTk9UX1VTRV9mb3JfZWFj aF9waHlzaWNhbF9lbmdpbmVfWUVUX18oZmRfXywgZV9fKSBcCj4gCj4gQmVzaWRlcywgbm9uZSBv ZiBhbGwgdGhvc2UgZnVuY3Rpb25zIGlzIHVzaW5nIHRoZSBuZXcgZTIKPiBzdHJ1Y3R1cmUuCj4g Cj4gSWYgaXQncyBPSyB3aXRoIHlvdSwgSSB3b3VsZCBzd2FwIGV2ZXJ5dGhpbmcgdG8gdXNlIGVp dGhlcgo+IF9fZm9yX2VhY2hfc3RhdGljX2VuZ2luZSBvciB0aGUgbmV3IGZvcl9lYWNoX3BoeXNp Y2FsX2VuZ2luZQo+IHJpZ2h0IGFmdGVyIHRoaXMgcGF0Y2ggZ29lcyBpbi4KCk9oIEkgbWlzc2Vk IGl0IGlzIF9fZm9yX2VhY2hfcGh5c2ljYWxfZW5naW5lIGluIHRoaXMgcGF0Y2guCgpJIGRvbid0 IGxpa2UgdGhlIGludGVybWVkaWF0ZSBzdGVwIG9mIHBlcmZfcG11IHVzaW5nIHRoZSBjb250ZXh0 IAppdGVyYXRvci4gTWFrZSBpdCB1c2UgX19mb3JfZWFjaF9waHlzaWNhbF9lbmdpbmUgdGhlbiBm b3Igbm93PyBJdCdzIGp1c3QgCmEgdHJpdmlhbCBmaW5kIGFuZCByZXBsYWNlLgoKUmVnYXJkcywK ClR2cnRrbwpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpp Z3QtZGV2IG1haWxpbmcgbGlzdAppZ3QtZGV2QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczov L2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2lndC1kZXY=