Re: [PATCH i-g-t v2 2/3] lib/kms: Update force joiner helpers to accomodate Ultra joiner

[Karthik B S <karthik.b.s@intel.com>]

On 9/11/2024 1:13 PM, Reddy Guddati, Santhosh wrote:
> Hi Karthik,
>
> Can we add an enum something like below , which can be re used at 
> other places.
>
> enum joiner_mode {
>     JOINED_PIPES_NONE,
>     JOINED_PIPES_1,
>     JOINED_PIPES_2,
>     JOINED_PIPES_3,
>     JOINED_PIPES_4,
>     JOINED_PIPES_MAX
> };
>
> bool kmstest_force_connector_joiner(int drm_fd, drmModeConnector 
> *connector, int joined_pipes)
> {
>     const char *value;
>     drmModeConnector *temp;
>
>     switch (joined_pipes) {
>     case 0:  -- > case JOINED_PIPES_NONE
>         value = "0";
>         break;

Hi Santhosh,

Thank you for the review. Sure will update this.

Thanks,
Karthik.B.S
>
> On 11-09-2024 12:52, Karthik B S wrote:
>> +        status = kmstest_force_connector_joiner(data->drm_fd, 
>> output->config.connector, 2);
>
> >> status = kmstest_force_connector_joiner(data->drm_fd, 
> output->config.connector, JOINED_PIPES_2);