From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by gabe.freedesktop.org (Postfix) with ESMTPS id EFC306EC70 for ; Mon, 26 Jul 2021 19:56:47 +0000 (UTC) From: "Shankar, Uma" Date: Mon, 26 Jul 2021 19:56:42 +0000 Message-ID: <4ebece4443894fee8e618013027f7be0@intel.com> References: <20210723093844.22352-1-vidya.srinivas@intel.com> In-Reply-To: Content-Language: en-US MIME-Version: 1.0 Subject: Re: [igt-dev] [PATCH i-g-t] tests/kms_big_fb: Fix hw stride length tests List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" To: "Srinivas, Vidya" , "igt-dev@lists.freedesktop.org" Cc: "Joshi, Kunal1" , "Latvala, Petri" , "Heikkila, Juha-pekka" , "Lin, Charlton" List-ID: > > > -----Original Message----- > > From: Srinivas, Vidya > > Sent: Friday, July 23, 2021 3:09 PM > > To: igt-dev@lists.freedesktop.org > > Cc: Modem, Bhanuprakash ; Shankar, Uma > > ; Almahallawy, Khaled > > ; Joshi, Kunal1 > > ; Heikkila, Juha-pekka > pekka.heikkila@intel.com>; Lin, Charlton ; > > Latvala, Petri ; Srinivas, Vidya > > ; Lin, Charlton > > Subject: [PATCH i-g-t] tests/kms_big_fb: Fix hw stride length tests > > > > We see the HW stride length tests are crashing when run in sequence. > > Individually, they PASS. > > This is happening due to missing data.ibb creation before the > > test_scanout. Patch fixes the same. > > Looks Good to me. > Reviewed-by: Uma Shankar Meanwhile while we are at it, I feel the intel_bb_create at fixture can be dropped as well. Currently its created but not getting destroyed in cleanup. Please check and update your patch fixing that as well. Thanks & Regards, Uma Shankar > > Signed-off-by: Lin Charlton > > Signed-off-by: Vidya Srinivas > > --- > > tests/kms_big_fb.c | 4 ++++ > > 1 file changed, 4 insertions(+) > > > > diff --git a/tests/kms_big_fb.c b/tests/kms_big_fb.c index > > c6f374bdd073..91439ceb34b6 100644 > > --- a/tests/kms_big_fb.c > > +++ b/tests/kms_big_fb.c > > @@ -978,7 +978,9 @@ igt_main > > igt_require(data.format == > > DRM_FORMAT_C8 || > > > > igt_fb_supported_format(data.format)); > > > > igt_require(igt_display_has_format_mod(&data.display, data.format, > > data.modifier)); > > + data.ibb = > > intel_bb_create(data.drm_fd, 4096); > > test_scanout(&data); > > + intel_bb_destroy(data.ibb); > > } > > > > // async flip doesn't support linear fbs. > > @@ -994,7 +996,9 @@ igt_main > > > > igt_require(igt_display_has_format_mod(&data.display, data.format, > > data.modifier)); > > > > igt_require_f(data.async_flip_support, "Async Flip is not supported\n"); > > data.max_hw_fb_width = > > min(data.hw_stride / (formats[j].bpp >> 3), data.max_fb_width); > > + data.ibb = > > intel_bb_create(data.drm_fd, 4096); > > test_scanout(&data); > > + intel_bb_destroy(data.ibb); > > } > > data.async_flip_test = false; > > } > > -- > > 2.32.0 _______________________________________________ igt-dev mailing list igt-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/igt-dev