From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6FFE6CDB47F for ; Wed, 24 Jun 2026 08:04:25 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 1C81C10E04F; Wed, 24 Jun 2026 08:04:25 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="B8HdFX9Y"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.10]) by gabe.freedesktop.org (Postfix) with ESMTPS id CF1E310EDF7 for ; Wed, 24 Jun 2026 08:03:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1782288235; x=1813824235; h=from:to:cc:subject:in-reply-to:references:date: message-id:mime-version:content-transfer-encoding; bh=Mk4gHu3zflChvG/qn4kUglaPUzNAbbhhvXmGnqnSvIQ=; b=B8HdFX9YAVBSYPwdJOUbsfzUFc3tI4QmR5bnJM77yYW1OTpX9AP1572x QQVX2o+sMbe/DWvaOWgozYA7j2V4h3ueanNQo9MTAvUUMKcebU2ar7drV lyoBUjQ7WwgL6XLeunxa/2PTOkLp9n3WuQoNvIVm+KjQXA5DQsOYQ5Jbh PTPwNa743cMvOcTf7q+aXtdlBFaI3lRGoi7c8IQ0lRij+HMcRfunSbuRw R/QekthuvP/Xa5yeB17z8m52G2pjYtuq3b2kOsX9XhBs++5k43U8Xl/H7 icNFgNlK8G70KxrX2Y/ckrvbwDuz1Z1oYQ0Auw8NtfuqxcShm5UxM4j2n Q==; X-CSE-ConnectionGUID: jCxYqqT+SpOzUkA3RTNqZA== X-CSE-MsgGUID: GaBcFfS6RHyIPpQvyOvNJw== X-IronPort-AV: E=McAfee;i="6800,10657,11826"; a="94440040" X-IronPort-AV: E=Sophos;i="6.24,222,1774335600"; d="scan'208";a="94440040" Received: from orviesa001.jf.intel.com ([10.64.159.141]) by fmvoesa104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Jun 2026 01:03:55 -0700 X-CSE-ConnectionGUID: jiH/f5ExSbOZnVQ1772euQ== X-CSE-MsgGUID: D5zzJSGAR7argkub53kUtw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.24,222,1774335600"; d="scan'208";a="287887798" Received: from amilburn-desk.amilburn-desk (HELO localhost) ([10.245.244.187]) by smtpauth.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Jun 2026 01:03:54 -0700 From: Jani Nikula To: Zbigniew =?utf-8?Q?Kempczy=C5=84ski?= Cc: igt-dev@lists.freedesktop.org Subject: Re: [PATCH i-g-t 4/5] benchmarks/gem_exec_trace: use hars_petruska_f54_1_random() from lib/rand In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - c/o Alberga Business Park, 6 krs Bertel Jungin Aukio 5, 02600 Espoo, Finland References: Date: Wed, 24 Jun 2026 11:03:51 +0300 Message-ID: <4ee63ffce8504cd794430e1cad3da6205b134cd0@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: igt-dev@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development mailing list for IGT GPU Tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" On Mon, 22 Jun 2026, Jani Nikula wrote: > On Fri, 19 Jun 2026, Zbigniew Kempczy=C5=84ski wrote: >> On Thu, Jun 18, 2026 at 05:09:52PM +0300, Jani Nikula wrote: >>> Remove the local duplicate of hars_petruska_f54_1_random() by switching >>> to use lib/rand. >>>=20 >>> Signed-off-by: Jani Nikula >>> --- >>> benchmarks/gem_exec_trace.c | 12 +++--------- >>> 1 file changed, 3 insertions(+), 9 deletions(-) >>>=20 >>> diff --git a/benchmarks/gem_exec_trace.c b/benchmarks/gem_exec_trace.c >>> index 4263ccb03dbd..c27639105903 100644 >>> --- a/benchmarks/gem_exec_trace.c >>> +++ b/benchmarks/gem_exec_trace.c >>> @@ -42,6 +42,7 @@ >>> #include "drm.h" >>> #include "drmtest.h" >>> #include "i915/gem_create.h" >>> +#include "igt_rand.h" >>> #include "igt_stats.h" >>> #include "intel_io.h" >>> #include "ioctl_wrappers.h" >>> @@ -92,14 +93,7 @@ struct trace_wait { >>> uint32_t handle; >>> } __attribute__((packed)); >>>=20=20 >>> -static uint32_t hars_petruska_f54_1_random(void) >>> -{ >>> - static uint32_t state =3D 0x12345678; >>> - >>> -#define rol(x,k) ((x << k) | (x >> (32-k))) >>> - return state =3D (state ^ rol (state, 5) ^ rol (state, 24)) + 0x37798= 849; >>> -#undef rol >>> -} >>> +static uint32_t random_state =3D 0x12345678; >>>=20=20 >>> static double elapsed(const struct timespec *start, const struct times= pec *end) >>> { >>> @@ -277,7 +271,7 @@ static double replay(const char *filename, long nop= , long range) >>> sizeof(*exec_objects)))->handle =3D bo[0]; >>>=20=20 >>> if (nop > 0) { >>> - eb.batch_start_offset =3D hars_petruska_f54_1_random(); >>> + eb.batch_start_offset =3D hars_petruska_f54_1_random(&random_state= ); >> >> With random_state as above this offset is not random. I think adding nop >> to random_state would do this. > > I'm only aiming to do a non-functional conversion to existing library > functions. Please explain how this patch changes behaviour; I don't see > it. Zbigniew, ping? > > > BR, > Jani. > >> >> -- >> Zbigniew >> >>> eb.batch_start_offset =3D >>> ((uint64_t)eb.batch_start_offset * range) >> 32; >>> eb.batch_start_offset =3D ALIGN(eb.batch_start_offset, 64); >>> --=20 >>> 2.47.3 >>>=20 --=20 Jani Nikula, Intel