From: "Kahola, Mika" <mika.kahola@intel.com>
To: "Latvala, Petri" <petri.latvala@intel.com>
Cc: "igt-dev@lists.freedesktop.org" <igt-dev@lists.freedesktop.org>
Subject: Re: [igt-dev] [PATCH i-g-t] tests/kms_ccs: Use correct CCS plane for semiplanar formats
Date: Thu, 13 Feb 2020 14:05:00 +0000 [thread overview]
Message-ID: <4fb1604c756c8a705876a9699f1a8df8b8188842.camel@intel.com> (raw)
In-Reply-To: <20200213120303.GU25209@platvala-desk.ger.corp.intel.com>
On Thu, 2020-02-13 at 14:03 +0200, Petri Latvala wrote:
> On Thu, Feb 13, 2020 at 11:30:41AM +0200, Mika Kahola wrote:
> > In case with semiplanar formats, we should use correct CCS plane
> > when these formats are under a test.
> >
> > Signed-off-by: Mika Kahola <mika.kahola@intel.com>
> > ---
> > lib/igt_fb.c | 2 +-
> > lib/igt_fb.h | 1 +
> > tests/kms_ccs.c | 27 ++++++++++++++++++++-------
> > 3 files changed, 22 insertions(+), 8 deletions(-)
> >
> > diff --git a/lib/igt_fb.c b/lib/igt_fb.c
> > index 8bdb0a09..0f8435a5 100644
> > --- a/lib/igt_fb.c
> > +++ b/lib/igt_fb.c
> > @@ -359,7 +359,7 @@ static const struct format_desc_struct
> > *lookup_drm_format(uint32_t drm_format)
> > return NULL;
> > }
> >
> > -static bool igt_format_is_yuv_semiplanar(uint32_t format)
> > +bool igt_format_is_yuv_semiplanar(uint32_t format)
>
>
> New exported library function could use some docs if you don't mind!
Agreed. Some documentation would be nice to have. I'll fix that.
-Mika-
>
>
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
next prev parent reply other threads:[~2020-02-13 14:05 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-13 9:30 [igt-dev] [PATCH i-g-t] tests/kms_ccs: Use correct CCS plane for semiplanar formats Mika Kahola
2020-02-13 11:31 ` Imre Deak
2020-02-13 14:03 ` Kahola, Mika
2020-02-17 11:28 ` Kahola, Mika
2020-02-13 12:01 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2020-02-13 12:03 ` [igt-dev] [PATCH i-g-t] " Petri Latvala
2020-02-13 14:05 ` Kahola, Mika [this message]
2020-02-17 9:55 ` [igt-dev] ✓ Fi.CI.IGT: success for " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4fb1604c756c8a705876a9699f1a8df8b8188842.camel@intel.com \
--to=mika.kahola@intel.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=petri.latvala@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox