Re: [PATCH i-g-t 1/3] drm-uapi-experimental/xe_drm_eudebug: Sync after exec_queue placement event addition.

["Manszewski, Christoph" <christoph.manszewski@intel.com>]

Hi Dominik,

On 13.11.2024 09:51, Dominik Grzegorzek wrote:
> Exec queue placement event has been added in logical order, due to that
> there is a shift in event numbering. Sync uapi to match kernel changes.
> 
> Signed-off-by: Dominik Grzegorzek <dominik.grzegorzek@intel.com>

Reviewed-by: Christoph Manszewski <christoph.manszewski@intel.com>

> ---
>   .../drm-uapi-experimental/xe_drm_eudebug.h    | 30 +++++++++++++++----
>   1 file changed, 24 insertions(+), 6 deletions(-)
> 
> diff --git a/include/drm-uapi-experimental/xe_drm_eudebug.h b/include/drm-uapi-experimental/xe_drm_eudebug.h
> index 13c069e00..f50051e9a 100644
> --- a/include/drm-uapi-experimental/xe_drm_eudebug.h
> +++ b/include/drm-uapi-experimental/xe_drm_eudebug.h
> @@ -147,12 +147,13 @@ struct drm_xe_eudebug_event {
>   #define DRM_XE_EUDEBUG_EVENT_OPEN		2
>   #define DRM_XE_EUDEBUG_EVENT_VM			3
>   #define DRM_XE_EUDEBUG_EVENT_EXEC_QUEUE		4
> -#define DRM_XE_EUDEBUG_EVENT_EU_ATTENTION	5
> -#define DRM_XE_EUDEBUG_EVENT_VM_BIND		6
> -#define DRM_XE_EUDEBUG_EVENT_VM_BIND_OP		7
> -#define DRM_XE_EUDEBUG_EVENT_VM_BIND_UFENCE	8
> -#define DRM_XE_EUDEBUG_EVENT_METADATA		9
> -#define DRM_XE_EUDEBUG_EVENT_VM_BIND_OP_METADATA 10
> +#define DRM_XE_EUDEBUG_EVENT_EXEC_QUEUE_PLACEMENTS 5
> +#define DRM_XE_EUDEBUG_EVENT_EU_ATTENTION	6
> +#define DRM_XE_EUDEBUG_EVENT_VM_BIND		7
> +#define DRM_XE_EUDEBUG_EVENT_VM_BIND_OP		8
> +#define DRM_XE_EUDEBUG_EVENT_VM_BIND_UFENCE	9
> +#define DRM_XE_EUDEBUG_EVENT_METADATA		10
> +#define DRM_XE_EUDEBUG_EVENT_VM_BIND_OP_METADATA 11
>   
>   	__u16 flags;
>   #define DRM_XE_EUDEBUG_EVENT_CREATE		(1 << 0)
> @@ -188,6 +189,22 @@ struct drm_xe_eudebug_event_exec_queue {
>   	__u64 lrc_handle[];
>   };
>   
> +struct drm_xe_eudebug_event_exec_queue_placements {
> +	struct drm_xe_eudebug_event base;
> +
> +	__u64 client_handle;
> +	__u64 vm_handle;
> +	__u64 exec_queue_handle;
> +	__u64 lrc_handle;
> +	__u32 num_placements;
> +	__u32 pad;
> +	/**
> +	 * @instances: user pointer to num_placements sized array of struct
> +	 * drm_xe_engine_class_instance
> +	 */
> +	__u64 instances[];
> +};
> +
>   struct drm_xe_eudebug_event_eu_attention {
>   	struct drm_xe_eudebug_event base;
>   
> @@ -303,6 +320,7 @@ struct drm_xe_eudebug_vm_open {
>   	/** @flags: flags */
>   	__u64 flags;
>   
> +#define DRM_XE_EUDEBUG_VM_SYNC_MAX_TIMEOUT_NSECS (10ULL * NSEC_PER_SEC)
>   	/** @timeout_ns: Timeout value in nanoseconds operations (fsync) */
>   	__u64 timeout_ns;
>   };