When all screens are disabled, it takes some time to release eDP/DP AUX IO power domain ref count. Also, delayed audio codec disabling takes time to release AUDIO power domain ref-count, using igt_wait to check lpsp after disabling all screens. v2: - Added a code comment for delay of igt_wait. [Animesh] Signed-off-by: Anshuman Gupta <anshuman.gupta@intel.com>
Looks good to me. Reviewed-by: Animesh Manna <animesh.manna@intel.com>
--- tests/i915/i915_pm_lpsp.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/tests/i915/i915_pm_lpsp.c b/tests/i915/i915_pm_lpsp.c index 56980de2..986bfc03 100644 --- a/tests/i915/i915_pm_lpsp.c +++ b/tests/i915/i915_pm_lpsp.c @@ -81,7 +81,9 @@ static void screens_disabled_subtest(data_t *data) } igt_require_f(valid_output, "No connected output found\n"); - igt_assert_f(lpsp_is_enabled(data), "lpsp is not enabled\n%s:\n%s\n", + /* eDP panel may have power_cycle_delay of 600ms, 1sec delay is safer */ + igt_assert_f(igt_wait(lpsp_is_enabled(data), 1000, 100), + "lpsp is not enabled\n%s:\n%s\n", PWR_DOMAIN_INFO, data->pwr_dmn_info = igt_sysfs_get(data->debugfs_fd, PWR_DOMAIN_INFO)); }