From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by gabe.freedesktop.org (Postfix) with ESMTPS id EC10B6E0EF for ; Wed, 13 Oct 2021 17:56:58 +0000 (UTC) From: "Vudum, Lakshminarayana" Date: Wed, 13 Oct 2021 17:56:50 +0000 Message-ID: <50f705ea458645038e0c0dd4d84e125d@intel.com> References: <20211008085917.393839-1-stylon.wang@amd.com> <1760fac2-d508-d04a-a00a-f40714333dd7@amd.com> <7a891b83094e437f9d430a58b052ece7@intel.com> In-Reply-To: Content-Language: en-US Content-Type: multipart/alternative; boundary="_000_50f705ea458645038e0c0dd4d84e125dintelcom_" MIME-Version: 1.0 Subject: Re: [igt-dev] [PATCH i-g-t v2] tests/kms_hdr: Fix failure to read output_bpc List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" To: "Wang, Chao-kai (Stylon)" , "Siqueira, Rodrigo" , "igt-dev@lists.freedesktop.org" Cc: "Choi, Nicholas" , "Wentland, Harry" , "Kazlauskas, Nicholas" , "contact@emersion.fr" List-ID: --_000_50f705ea458645038e0c0dd4d84e125dintelcom_ Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Re-reported. From: Wang, Chao-kai (Stylon) Sent: Tuesday, October 12, 2021 10:57 PM To: Vudum, Lakshminarayana ; Siqueira, Rod= rigo ; igt-dev@lists.freedesktop.org Cc: Choi, Nicholas ; Wentland, Harry ; Kazlauskas, Nicholas ; contact@emer= sion.fr Subject: Re: [PATCH i-g-t v2] tests/kms_hdr: Fix failure to read output_bpc [AMD Official Use Only] Hi Lakshminarayana, Here it is: https://patchwork.freedesktop.org/series/95601/ Regards Stylon Wang MTS Software Development Eng. | AMD Display Solution Team O +(886) 2-3789-3667 ext. 23667 C +(886) 921-897-142 ---------------------------------------------------------------------------= ------------------------------------------------------- 6F, 3, YuanCyu St (NanKang Software Park) Taipei, Taiwan Facebook | Twitter = | amd.com ________________________________ From: Vudum, Lakshminarayana > Sent: October 9, 2021 5:04 AM To: Siqueira, Rodrigo >; igt-dev@lists.freedesktop.org= > Cc: Choi, Nicholas >; W= entland, Harry >; Kaz= lauskas, Nicholas >; Siqueira, Rodrigo >; contact@emersion.fr >; Wang, Chao-kai (Stylon) > Subject: RE: [PATCH i-g-t v2] tests/kms_hdr: Fix failure to read output_bpc Can you please post the series link here? Lakshmi. -----Original Message----- From: Rodrigo Siqueira Jordao > Sent: Friday, October 8, 2021 12:32 PM To: igt-dev@lists.freedesktop.org; Vu= dum, Lakshminarayana > Cc: nicholas.choi@amd.com; harry.wentland@amd= .com; nicholas.kazlauskas@amd.com; rodrigo.siqueira@amd.com; contact@emersion.fr; Stylon Wang > Subject: Re: [PATCH i-g-t v2] tests/kms_hdr: Fix failure to read output_bpc Hi Lakshminarayana, It looks like that we have another false-positive result from the CI in thi= s patch. Thanks Siqueira On 2021-10-08 4:59 a.m., Stylon Wang wrote: > The first commit with TEST_ONLY flag in bpc-switch subtests could fail > the test, because previous state can be with any bpc or even wth no > crtc assigned to the connector. > > v2: > - Keep the test commit for its original purpose of checking > if 512x512 plane size works for the hardware. > - Add new atomic commit so the setting of 8 bpc really takes effect. > > Signed-off-by: Stylon Wang > > --- > tests/kms_hdr.c | 22 +++++++++++++--------- > 1 file changed, 13 insertions(+), 9 deletions(-) > > diff --git a/tests/kms_hdr.c b/tests/kms_hdr.c index > 5b8529c8..273263db 100644 > --- a/tests/kms_hdr.c > +++ b/tests/kms_hdr.c > @@ -213,16 +213,27 @@ static void test_bpc_switch_on_output(data_t > *data, igt_output_t *output, > > draw_hdr_pattern(&afb); > > - /* Start in 8bpc. */ > + /* Plane may be required to fit fullscreen. Check it here a= nd allow > + * smaller plane size in following tests. > + */ > igt_plane_set_fb(data->primary, &afb); > igt_plane_set_size(data->primary, data->w, data->h); > - igt_output_set_prop_value(data->output, IGT_CONNECTOR_MAX_B= PC, 8); > ret =3D igt_display_try_commit_atomic(display, DRM_MODE_AT= OMIC_TEST_ONLY, NULL); > if (!ret) { > data->w =3D afb.width; > data->h =3D afb.height; > } > > + /* Start in 8bpc. */ > + igt_output_set_prop_value(data->output, IGT_CONNECTOR_MAX_B= PC, 8); > + igt_display_commit_atomic(display, DRM_MODE_ATOMIC_ALLOW_MO= DESET, NULL); > + /* > + * i915 driver doesn't expose max bpc as debugfs entry, > + * so limiting assert only for amd driver. > + */ > + if (is_amdgpu_device(data->fd)) > + assert_output_bpc(data, 8); > + > /* > * amdgpu requires a primary plane when the CRTC is enable= d. > * However, some older Intel hardware (hsw) have scaling @= @ > -232,13 +243,6 @@ static void test_bpc_switch_on_output(data_t *data, igt= _output_t *output, > if (!is_amdgpu_device(data->fd)) > igt_plane_set_fb(data->primary, NULL); > > - /* > - * i915 driver doesn't expose max bpc as debugfs entry, > - * so limiting assert only for amd driver. > - */ > - if (is_amdgpu_device(data->fd)) > - assert_output_bpc(data, 8); > - > /* Switch to 10bpc. */ > igt_output_set_prop_value(data->output, IGT_CONNECTOR_MAX_= BPC, 10); > igt_display_commit_atomic(display, DRM_MODE_ATOMIC_ALLOW_M= ODESET, > NULL); > --_000_50f705ea458645038e0c0dd4d84e125dintelcom_ Content-Type: text/html; charset="us-ascii" Content-Transfer-Encoding: quoted-printable

Re-reported.

 

From: Wang, Chao-kai (Stylon) <Stylon.Wang= @amd.com>
Sent: Tuesday, October 12, 2021 10:57 PM
To: Vudum, Lakshminarayana <lakshminarayana.vudum@intel.com>; = Siqueira, Rodrigo <Rodrigo.Siqueira@amd.com>; igt-dev@lists.freedeskt= op.org
Cc: Choi, Nicholas <Nicholas.Choi@amd.com>; Wentland, Harry &l= t;Harry.Wentland@amd.com>; Kazlauskas, Nicholas <Nicholas.Kazlauskas@= amd.com>; contact@emersion.fr
Subject: Re: [PATCH i-g-t v2] tests/kms_hdr: Fix failure to read out= put_bpc

 

[AMD Official Use Only]

 

Hi Lakshminarayana,=

 =

 =

 =

Regards

Stylon Wang

MTS Software Devel= opment Eng.  |  AMD
Display Solution Team

 +(886) 2-3789-3667 ext. 23667  C +(886) 921-897-142

--------------------------------= ---------------------------------------------------------------------------= -----------------------=

6F, 3, YuanCyu St (NanKang Software Park) Taipei, Ta= iwan

Facebook |  Twitter | =  amd.com<= span style=3D"font-size:10.0pt;font-family:"Arial",sans-serif;col= or:black"> 

 

Can you please post t= he series link here?

Lakshmi.
-----Original Message-----
From: Rodrigo Siqueira Jordao <rjor= drigo@amd.com>
Sent: Friday, October 8, 2021 12:32 PM
To: igt-dev@lists.freedesk= top.org; Vudum, Lakshminarayana <lakshminarayana.vudum@intel.com>
Cc: nicholas.choi@amd.com; harry.wentland@amd.com; = nicholas.kazlauskas@amd.com; rodrigo.siqueira@amd.com; <= a href=3D"mailto:contact@emersion.fr"> contact@emersion.fr; Stylon Wang <stylon.wang@amd.com>
Subject: Re: [PATCH i-g-t v2] tests/kms_hdr: Fix failure to read output_bpc=

Hi Lakshminarayana,

It looks like that we have another false-positive result from the CI in thi= s patch.

Thanks
Siqueira

On 2021-10-08 4:59 a.m., Stylon Wang wrote:
> The first commit with TEST_ONLY flag in bpc-switch subtests could fail=
> the test, because previous state can be with any bpc or even wth no > crtc assigned to the connector.
>
> v2:
> - Keep the test commit for its original purpose of checking
>    if 512x512 plane size works for the hardware.
> - Add new atomic commit so the setting of 8 bpc really takes effect. >
> Signed-off-by: Stylon Wang <= stylon.wang@amd.com>
> ---
>   tests/kms_hdr.c | 22 +++++++&#= 43;+++++---------
>   1 file changed, 13 insertions(+), 9 deletions(-)
>
> diff --git a/tests/kms_hdr.c b/tests/kms_hdr.c index
> 5b8529c8..273263db 100644
> --- a/tests/kms_hdr.c
> +++ b/tests/kms_hdr.c
> @@ -213,16 +213,27 @@ static void test_bpc_switch_on_output(data_t=
> *data, igt_output_t *output,
>  
>            = ;    draw_hdr_pattern(&afb);
>  
> -           &nb= sp; /* Start in 8bpc. */
> +           = ;  /* Plane may be required to fit fullscreen. Check it here and allow=
> +           = ;   * smaller plane size in following tests.
> +           = ;   */
>            = ;    igt_plane_set_fb(data->primary, &afb);
>            = ;    igt_plane_set_size(data->primary, data->w, data-&= gt;h);
> -           &nb= sp; igt_output_set_prop_value(data->output, IGT_CONNECTOR_MAX_BPC, 8); >            = ;    ret =3D igt_display_try_commit_atomic(display, DRM_MODE= _ATOMIC_TEST_ONLY, NULL);
>            = ;    if (!ret) {
>            = ;            data-&g= t;w =3D afb.width;
>            = ;            data-&g= t;h =3D afb.height;
>            = ;    }
>  
> +           = ;  /* Start in 8bpc. */
> +           = ;  igt_output_set_prop_value(data->output, IGT_CONNECTOR_MAX_BPC, 8= );
> +           = ;  igt_display_commit_atomic(display, DRM_MODE_ATOMIC_ALLOW_MODESET, N= ULL);
> +           = ;  /*
> +           = ;   * i915 driver doesn't expose max bpc as debugfs entry,
> +           = ;   * so limiting assert only for amd driver.
> +           = ;   */
> +           = ;  if (is_amdgpu_device(data->fd))
> +           = ;          assert_output_bpc(d= ata, 8);
> +
>            = ;    /*
>            = ;     * amdgpu requires a primary plane when the CRTC i= s enabled.
>            = ;     * However, some older Intel hardware (hsw) have s= caling @@
> -232,13 +243,6 @@ static void test_bpc_switch_on_output(data_t *da= ta, igt_output_t *output,
>            = ;    if (!is_amdgpu_device(data->fd))
>            = ;            igt_pla= ne_set_fb(data->primary, NULL);
>  
> -           &nb= sp; /*
> -           &nb= sp;  * i915 driver doesn't expose max bpc as debugfs entry,
> -           &nb= sp;  * so limiting assert only for amd driver.
> -           &nb= sp;  */
> -           &nb= sp; if (is_amdgpu_device(data->fd))
> -           &nb= sp;         assert_output_bpc(data,= 8);
> -
>            = ;    /* Switch to 10bpc. */
>            = ;    igt_output_set_prop_value(data->output, IGT_CONNECTO= R_MAX_BPC, 10);
>            = ;    igt_display_commit_atomic(display, DRM_MODE_ATOMIC_ALLO= W_MODESET,
> NULL);
>

--_000_50f705ea458645038e0c0dd4d84e125dintelcom_--