Re: [PATCH i-g-t v1] tests/kms_hdr: Skip brightness on non-internal panels

["Sharma, Swati2" <swati2.sharma@intel.com>]

Hi Santosh,

Please add closes tag in the commit

Closes: https://gitlab.freedesktop.org/drm/xe/kernel/-/issues/3312

Rest LGTM

Reviewed-by: Swati Sharma <swati2.sharma@intel.com>

On 13-11-2024 07:55 pm, Santhosh Reddy Guddati wrote:

> Skip the brightness test if the output is not an internal panel and log
> the skip message.
>
> Signed-off-by: Santhosh Reddy Guddati <santhosh.reddy.guddati@intel.com>
> ---
>   tests/kms_hdr.c | 6 ++++++
>   1 file changed, 6 insertions(+)
>
> diff --git a/tests/kms_hdr.c b/tests/kms_hdr.c
> index b67902d43..c4c9df3fc 100644
> --- a/tests/kms_hdr.c
> +++ b/tests/kms_hdr.c
> @@ -696,6 +696,12 @@ static void test_hdr(data_t *data, uint32_t flags)
>   			continue;
>   		}
>   
> +		if ((flags & TEST_BRIGHTNESS) && !output_is_internal_panel(output)) {
> +			igt_info("%s: Can't run brightness test on non-internal panel.\n",
> +				 igt_output_name(output));
> +			continue;
> +		}
> +
>   		for_each_pipe(display, pipe) {
>   			igt_output_set_pipe(output, pipe);
>   			if (!intel_pipe_output_combo_valid(display)) {