From: Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com>
To: Bhanuprakash Modem <bhanuprakash.modem@intel.com>,
igt-dev@lists.freedesktop.org
Subject: Re: [igt-dev] [i-g-t V2 1/4] tests/intel/kms_fbt: Use blitter as a default draw method
Date: Wed, 15 Nov 2023 15:31:01 +0200 [thread overview]
Message-ID: <52b339f1-72da-4ad0-ac28-0a033acaf3f7@gmail.com> (raw)
In-Reply-To: <20231115130237.1522518-2-bhanuprakash.modem@intel.com>
Reviewed-by: Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com>
On 15.11.2023 15.02, Bhanuprakash Modem wrote:
> As Rendercopy support in IGT is not present for few latest
> platforms, use Blitter as default draw method.
>
> Cc: Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com>
> Cc: Jouni Högander <jouni.hogander@intel.com>
> Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
> ---
> tests/intel/kms_frontbuffer_tracking.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/tests/intel/kms_frontbuffer_tracking.c b/tests/intel/kms_frontbuffer_tracking.c
> index 60a469901..eac33f48b 100644
> --- a/tests/intel/kms_frontbuffer_tracking.c
> +++ b/tests/intel/kms_frontbuffer_tracking.c
> @@ -1236,12 +1236,12 @@ static void init_crcs(enum pixel_format format, enum tiling_type tiling,
> for (r_ = 0; r_ <= r; r_++)
> draw_rect_igt_fb(pattern, &tmp_fbs[r],
> igt_draw_supports_method(drm.fd, IGT_DRAW_PWRITE) ?
> - IGT_DRAW_PWRITE : IGT_DRAW_RENDER,
> + IGT_DRAW_PWRITE : IGT_DRAW_BLT,
> r_);
> } else {
> for (r = 0; r < pattern->n_rects; r++)
> draw_rect_igt_fb(pattern, &tmp_fbs[r], igt_draw_supports_method(drm.fd, IGT_DRAW_PWRITE) ?
> - IGT_DRAW_PWRITE : IGT_DRAW_RENDER, r);
> + IGT_DRAW_PWRITE : IGT_DRAW_BLT, r);
> }
>
> igt_output_set_pipe(prim_mode_params.output, prim_mode_params.pipe);
next prev parent reply other threads:[~2023-11-15 13:31 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-15 13:02 [igt-dev] [i-g-t V2 0/4] Fix the usage of Rendercopy in KMS tests Bhanuprakash Modem
2023-11-15 13:02 ` [igt-dev] [i-g-t V2 1/4] tests/intel/kms_fbt: Use blitter as a default draw method Bhanuprakash Modem
2023-11-15 13:31 ` Juha-Pekka Heikkila [this message]
2023-11-15 13:02 ` [igt-dev] [i-g-t V2 2/4] tests/intel/kms_fbt: Fill fb region with requested " Bhanuprakash Modem
2023-11-15 13:30 ` Juha-Pekka Heikkila
2023-11-15 13:02 ` [igt-dev] [i-g-t V2 3/4] tests/intel/kms_dirtyfb: Use blitter if rendercopy isn't present Bhanuprakash Modem
2023-11-15 13:02 ` [igt-dev] [i-g-t V2 4/4] tests/intel/kms_dirtyfb: Restructure dynamic subtests Bhanuprakash Modem
2023-11-15 16:05 ` [igt-dev] ✓ Fi.CI.BAT: success for Fix the usage of Rendercopy in KMS tests (rev2) Patchwork
2023-11-15 16:08 ` [igt-dev] ✓ CI.xeBAT: " Patchwork
2023-11-17 3:10 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52b339f1-72da-4ad0-ac28-0a033acaf3f7@gmail.com \
--to=juhapekka.heikkila@gmail.com \
--cc=bhanuprakash.modem@intel.com \
--cc=igt-dev@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox