Re: [igt-dev] [PATCH i-g-t v4] tests/i915/gem_huc_copy: Enable a HuC copy test

From: "Ye, Tony" <tony.ye@intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>,
	"Robert M. Fosha" <robert.m.fosha@intel.com>,
	igt-dev@lists.freedesktop.org
Cc: Sally Qi <feng.qi@intel.com>
Subject: Re: [igt-dev] [PATCH i-g-t v4] tests/i915/gem_huc_copy: Enable a HuC copy test
Date: Fri, 10 Jan 2020 11:51:58 -0800	[thread overview]
Message-ID: <5315c347-7ebc-1519-73d6-16eb0d409ec9@intel.com> (raw)
In-Reply-To: <157868089371.10140.10254349676452972062@skylake-alporthouse-com>

On 1/10/2020 10:28 AM, Chris Wilson wrote:
> Quoting Robert M. Fosha (2020-01-10 17:41:46)
>> +static bool
>> +check_huc_enabled(int fd)
>> +{
>> +       int dir;
>> +       dir = igt_sysfs_open_parameters(fd);
>> +
>> +       if (dir < 0)
>> +               return 0;
>> +
>> +       if (igt_sysfs_get_u32(dir, "enable_guc") & 2)
>> +               return 1;
>> +       else
>> +               return 0;
> 
> No. If you have this in your userspace, please immediately remove it,
> and backport that to any and all stable branches and releases.
> -Chris

The code is to skip the test when HuC is disabled by the enable_guc 
module parameter. If HuC is disabled by the enable_guc param, then skip 
the test. If the HuC failed to load due to a real error, then fail the 
test.

Could you suggest how to handle HUC_STATUS failure properly without this 
code?

Regards,
Tony

> _______________________________________________
> igt-dev mailing list
> igt-dev@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/igt-dev
> 
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev