Re: [PATCH 01/66] tests/xe_eudebug: Test eudebug connection

["Manszewski, Christoph" <christoph.manszewski@intel.com>]

Hi Zbigniew,

On 30.07.2024 09:58, Zbigniew Kempczyński wrote:
> On Mon, Jul 29, 2024 at 06:00:54PM +0200, Christoph Manszewski wrote:
>> From: Dominik Grzegorzek <dominik.grzegorzek@intel.com>
>>
>> Add basic tests checking xe eudebug connection capability.
>>
>> Signed-off-by: Dominik Grzegorzek <dominik.grzegorzek@intel.com>
>> Signed-off-by: Mika Kuoppala <mika.kuoppala@linux.intel.com>
>> Cc: Christoph Manszewski <christoph.manszewski@intel.com>
>> ---
>>   tests/intel/xe_eudebug.c | 115 +++++++++++++++++++++++++++++++++++++++
>>   tests/meson.build        |   1 +
>>   2 files changed, 116 insertions(+)
>>   create mode 100644 tests/intel/xe_eudebug.c
>>
>> diff --git a/tests/intel/xe_eudebug.c b/tests/intel/xe_eudebug.c
>> new file mode 100644
>> index 000000000..2bd5a44f9
>> --- /dev/null
>> +++ b/tests/intel/xe_eudebug.c
>> @@ -0,0 +1,115 @@
>> +// SPDX-License-Identifier: MIT
>> +/*
>> + * Copyright © 2023 Intel Corporation
>> + */
>> +
>> +#include <xe_drm.h>
>> +#include "igt.h"
>> +
>> +static int __debug_connect(int fd, int *debugfd, struct drm_xe_eudebug_connect *param)
>> +{
>> +	int ret = 0;
>> +
>> +	*debugfd = igt_ioctl(fd, DRM_IOCTL_XE_EUDEBUG_CONNECT, param);
> 
> On first glance it looks it won't compile at this point.

Yes, haven't been doing format-patch for a while and missed a patch, my bad.

> 
> Christoph, may you reorder patches to make sure all of them
> will compile in the series?

Sure, before I send all patches I make sure each individual one compiles.

Thanks,
Christoph

> 
> --
> Zbigniew
> 
>> +
>> +	if (*debugfd < 0) {
>> +		ret = -errno;
>> +		igt_assume(ret != 0);
>> +	}
>> +
>> +	errno = 0;
>> +	return ret;
>> +}
>> +
>> +static void test_connect(int fd)
>> +{
>> +	struct drm_xe_eudebug_connect param = {};
>> +	int debugfd, ret;
>> +	pid_t *pid;
>> +
>> +	pid = mmap(NULL, sizeof(pid_t), PROT_WRITE,
>> +		   MAP_SHARED | MAP_ANON, -1, 0);
>> +
>> +	/* get fresh unrelated pid */
>> +	igt_fork(child, 1)
>> +		*pid = getpid();
>> +
>> +	igt_waitchildren();
>> +	param.pid = *pid;
>> +	munmap(pid, sizeof(pid_t));
>> +
>> +	ret = __debug_connect(fd, &debugfd, &param);
>> +	igt_assert(debugfd == -1);
>> +	igt_assert_eq(ret, param.pid ? -ENOENT : -EINVAL);
>> +
>> +	param.pid = 0;
>> +	ret = __debug_connect(fd, &debugfd, &param);
>> +	igt_assert(debugfd == -1);
>> +	igt_assert_eq(ret, -EINVAL);
>> +
>> +	param.pid = getpid();
>> +	param.version = -1;
>> +	ret = __debug_connect(fd, &debugfd, &param);
>> +	igt_assert(debugfd == -1);
>> +	igt_assert_eq(ret, -EINVAL);
>> +
>> +	param.version = 0;
>> +	param.flags = ~0;
>> +	ret = __debug_connect(fd, &debugfd, &param);
>> +	igt_assert(debugfd == -1);
>> +	igt_assert_eq(ret, -EINVAL);
>> +
>> +	param.flags = 0;
>> +	param.extensions = ~0;
>> +	ret = __debug_connect(fd, &debugfd, &param);
>> +	igt_assert(debugfd == -1);
>> +	igt_assert_eq(ret, -EINVAL);
>> +
>> +	param.extensions = 0;
>> +	ret = __debug_connect(fd, &debugfd, &param);
>> +	igt_assert_neq(debugfd, -1);
>> +	igt_assert_eq(ret, 0);
>> +
>> +	close(debugfd);
>> +}
>> +
>> +static void test_close(int fd)
>> +{
>> +	struct drm_xe_eudebug_connect param = { 0,  };
>> +	int debug_fd1, debug_fd2;
>> +	int fd2;
>> +
>> +	param.pid = getpid();
>> +
>> +	igt_assert_eq(__debug_connect(fd, &debug_fd1, &param), 0);
>> +	igt_assert(debug_fd1 >= 0);
>> +	igt_assert_eq(__debug_connect(fd, &debug_fd2, &param), -EBUSY);
>> +	igt_assert_eq(debug_fd2, -1);
>> +
>> +	close(debug_fd1);
>> +	fd2 = drm_open_driver(DRIVER_XE);
>> +
>> +	igt_assert_eq(__debug_connect(fd2, &debug_fd2, &param), 0);
>> +	igt_assert(debug_fd2 >= 0);
>> +	close(fd2);
>> +	close(debug_fd2);
>> +	close(debug_fd1);
>> +}
>> +
>> +igt_main
>> +{
>> +	int fd;
>> +
>> +	igt_fixture {
>> +		fd = drm_open_driver(DRIVER_XE);
>> +	}
>> +
>> +	igt_subtest("basic-connect")
>> +		test_connect(fd);
>> +
>> +	igt_subtest("basic-close")
>> +		test_close(fd);
>> +
>> +	igt_fixture
>> +		drm_close_driver(fd);
>> +}
>> diff --git a/tests/meson.build b/tests/meson.build
>> index e649466be..35bf8ed35 100644
>> --- a/tests/meson.build
>> +++ b/tests/meson.build
>> @@ -279,6 +279,7 @@ intel_xe_progs = [
>>   	'xe_dma_buf_sync',
>>   	'xe_debugfs',
>>   	'xe_drm_fdinfo',
>> +	'xe_eudebug',
>>   	'xe_evict',
>>   	'xe_evict_ccs',
>>   	'xe_exec_atomic',
>> -- 
>> 2.34.1
>>