Re: [PATCH i-g-t 3/4] Revert "drm-uapi-experimental/xe_drm_eudebug: Sync after exec_queue placement event addition"

["Manszewski, Christoph" <christoph.manszewski@intel.com>]

Hi Mika,

On 7.02.2025 12:49, Mika Kuoppala wrote:
> Exec queue placements support was dropped as unused.
> 
> This reverts commit 722494e73a3117c0de1708a2ff2a326446b043b6.
> 
> Signed-off-by: Mika Kuoppala <mika.kuoppala@linux.intel.com>

Reviewed-by: Christoph Manszewski <christoph.manszewski@intel.com>

Thanks,
Christoph
> ---
>   .../drm-uapi-experimental/xe_drm_eudebug.h    | 31 +++++--------------
>   1 file changed, 7 insertions(+), 24 deletions(-)
> 
> diff --git a/include/drm-uapi-experimental/xe_drm_eudebug.h b/include/drm-uapi-experimental/xe_drm_eudebug.h
> index ed2e728c2..714bb93c7 100644
> --- a/include/drm-uapi-experimental/xe_drm_eudebug.h
> +++ b/include/drm-uapi-experimental/xe_drm_eudebug.h
> @@ -147,14 +147,13 @@ struct drm_xe_eudebug_event {
>   #define DRM_XE_EUDEBUG_EVENT_OPEN		2
>   #define DRM_XE_EUDEBUG_EVENT_VM			3
>   #define DRM_XE_EUDEBUG_EVENT_EXEC_QUEUE		4
> -#define DRM_XE_EUDEBUG_EVENT_EXEC_QUEUE_PLACEMENTS 5
> -#define DRM_XE_EUDEBUG_EVENT_EU_ATTENTION	6
> -#define DRM_XE_EUDEBUG_EVENT_VM_BIND		7
> -#define DRM_XE_EUDEBUG_EVENT_VM_BIND_OP		8
> -#define DRM_XE_EUDEBUG_EVENT_VM_BIND_UFENCE	9
> -#define DRM_XE_EUDEBUG_EVENT_METADATA		10
> -#define DRM_XE_EUDEBUG_EVENT_VM_BIND_OP_METADATA 11
> -#define DRM_XE_EUDEBUG_EVENT_PAGEFAULT		12
> +#define DRM_XE_EUDEBUG_EVENT_EU_ATTENTION	5
> +#define DRM_XE_EUDEBUG_EVENT_VM_BIND		6
> +#define DRM_XE_EUDEBUG_EVENT_VM_BIND_OP		7
> +#define DRM_XE_EUDEBUG_EVENT_VM_BIND_UFENCE	8
> +#define DRM_XE_EUDEBUG_EVENT_METADATA		9
> +#define DRM_XE_EUDEBUG_EVENT_VM_BIND_OP_METADATA 10
> +#define DRM_XE_EUDEBUG_EVENT_PAGEFAULT		11
>   
>   	__u16 flags;
>   #define DRM_XE_EUDEBUG_EVENT_CREATE		(1 << 0)
> @@ -190,22 +189,6 @@ struct drm_xe_eudebug_event_exec_queue {
>   	__u64 lrc_handle[];
>   };
>   
> -struct drm_xe_eudebug_event_exec_queue_placements {
> -	struct drm_xe_eudebug_event base;
> -
> -	__u64 client_handle;
> -	__u64 vm_handle;
> -	__u64 exec_queue_handle;
> -	__u64 lrc_handle;
> -	__u32 num_placements;
> -	__u32 pad;
> -	/**
> -	 * @instances: user pointer to num_placements sized array of struct
> -	 * drm_xe_engine_class_instance
> -	 */
> -	__u64 instances[];
> -};
> -
>   struct drm_xe_eudebug_event_eu_attention {
>   	struct drm_xe_eudebug_event base;
>