public inbox for igt-dev@lists.freedesktop.org
 help / color / mirror / Atom feed
From: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
To: Umesh Nerlige Ramappa <umesh.nerlige.ramappa@intel.com>,
	igt-dev@lists.freedesktop.org,
	Ashutosh Dixit <ashutosh.dixit@intel.com>
Subject: Re: [igt-dev] [PATCH i-g-t] tests/perf: Fix B0 counter check in gen12-mi-rpc
Date: Tue, 21 Apr 2020 23:06:27 +0300	[thread overview]
Message-ID: <5559c6ff-8cba-7f84-0490-879a5dc3e2dc@intel.com> (raw)
In-Reply-To: <20200421182237.7743-1-umesh.nerlige.ramappa@intel.com>

On 21/04/2020 21:22, Umesh Nerlige Ramappa wrote:
> The gen12-mi-rpc test checks for B0 counter to be zero, however,
> occassionally the counter reads a non-zero value. To ensure the test
> works as expected, we check B0 with the preset value.


What the value being reported?


Sounds like we should ask around see if there isn't a deeper problem 
with the HW configuration.


-Lionel


>
> Signed-off-by: Umesh Nerlige Ramappa <umesh.nerlige.ramappa@intel.com>
> Fixes: https://gitlab.freedesktop.org/drm/intel/-/issues/1085
> ---
>   tests/perf.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/perf.c b/tests/perf.c
> index b7d5e50e..9d0ed45c 100644
> --- a/tests/perf.c
> +++ b/tests/perf.c
> @@ -3002,7 +3002,7 @@ gen12_test_mi_rpc(void)
>   	 */
>   	igt_assert_eq(report32[0], REPORT_ID);
>   	igt_assert_neq(report32[1], 0);
> -	igt_assert_eq(report32[format.b_off >> 2], 0);
> +	igt_assert_neq(report32[format.b_off >> 2], 0x80808080);
>   	igt_assert_eq(report32[format_size_32], 0x80808080);
>   
>   	drm_intel_bo_unmap(bo);


_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

  parent reply	other threads:[~2020-04-21 20:06 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-21 18:22 [igt-dev] [PATCH i-g-t] tests/perf: Fix B0 counter check in gen12-mi-rpc Umesh Nerlige Ramappa
2020-04-21 19:00 ` [igt-dev] ✗ Fi.CI.BAT: failure for " Patchwork
2020-04-21 20:06 ` Lionel Landwerlin [this message]
2020-04-22 15:47   ` [igt-dev] [PATCH i-g-t] " Umesh Nerlige Ramappa
2020-04-22 16:01     ` Lionel Landwerlin
2020-04-24 18:07       ` Umesh Nerlige Ramappa
2020-04-24 22:34         ` Lionel Landwerlin
  -- strict thread matches above, loose matches on Subject: below --
2020-04-27 17:53 Umesh Nerlige Ramappa

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5559c6ff-8cba-7f84-0490-879a5dc3e2dc@intel.com \
    --to=lionel.g.landwerlin@intel.com \
    --cc=ashutosh.dixit@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=umesh.nerlige.ramappa@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox