From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by gabe.freedesktop.org (Postfix) with ESMTPS id EA2046E058 for ; Fri, 5 Apr 2019 09:16:38 +0000 (UTC) References: <20190405010737.19111-1-andi@etezian.org> <20190405010737.19111-5-andi@etezian.org> <3af0b26f-f79a-bfc3-5735-241f192a8cc0@linux.intel.com> <20190405090047.GE18786@jack.zhora.eu> From: Tvrtko Ursulin Message-ID: <55a93de3-e8a4-dee0-8252-76b2093ca11e@linux.intel.com> Date: Fri, 5 Apr 2019 10:16:36 +0100 MIME-Version: 1.0 In-Reply-To: <20190405090047.GE18786@jack.zhora.eu> Content-Language: en-US Subject: Re: [igt-dev] [PATCH v17 4/7] lib/i915: add gem_engine_topology library and for_each loop definition List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" To: Andi Shyti Cc: IGT dev List-ID: Ck9uIDA1LzA0LzIwMTkgMTA6MDAsIEFuZGkgU2h5dGkgd3JvdGU6Cj4gSGkgVHZydGtvLAo+IAo+ Pj4gKwlzdHJ1Y3QgaTkxNV9jb250ZXh0X3BhcmFtX2VuZ2luZXMgKmVuZ2luZXMgPQo+Pj4gKwkJ CShzdHJ1Y3QgaTkxNV9jb250ZXh0X3BhcmFtX2VuZ2luZXMqKSBwYXJhbS0+dmFsdWU7Cj4+Cj4+ IENvc21ldGljcyBvbmx5OiBPdXIgY29kaW5nIHN0eWxlIGlzICIodHlwZSAqKXZhciIuCj4+Cj4+ PiArCWZvciAodHlwZW9mKGVuZ2luZXMtPmNsYXNzX2luc3RhbmNlWzBdKSAqcCA9Cj4+PiArCQkJ JmVuZ2luZXMtPmNsYXNzX2luc3RhbmNlWzBdOwo+Pj4gKwkJCQkJCWkgPCBlZC0+bmVuZ2luZXM7 IGkrKywgcCsrKQo+Pgo+PiBNb3JlIGNvc21ldGljczogSW5kZW50YXRpb24gYWxpZ25tZW50IGxv b2tzIHdvbmt5Lgo+IAo+IHdvcmtpbmcgYXQgdGhlIGVkZ2Ugb2YgdGhlIDgwIGNoYXJhY3RlcnMg cHJvdmlkZXMgYWx3YXlzCj4gY29zbWV0aWMgY2hhbGxlbmdlcywgSSdsbCBmaXggdGhlIGFib3Zl Lgo+IAo+Pj4gK3N0cnVjdCBpbnRlbF9leGVjdXRpb25fZW5naW5lMgo+Pj4gKyppbnRlbF9nZXRf Y3VycmVudF9lbmdpbmUoc3RydWN0IGludGVsX2VuZ2luZV9kYXRhICplZCkKPj4+ICt7Cj4+PiAr CWlmICghZWQtPm4pCj4+PiArCQllZC0+Y3VycmVudF9lbmdpbmUgPSAmZWQtPmVuZ2luZXNbMF07 Cj4+PiArCWVsc2UgaWYgKGVkLT5uID49IGVkLT5uZW5naW5lcykKPj4+ICsJCWVkLT5jdXJyZW50 X2VuZ2luZSA9IE5VTEw7Cj4+PiArCj4+PiArCXJldHVybiBlZC0+Y3VycmVudF9lbmdpbmU7Cj4+ PiArfQo+Pj4gKwo+Pgo+PiBXaHkgY2FuIHRoaXMganVzdCByZXR1cm4gZWQtPmN1cnJlbnRfZW5n aW5lPyBJIGFtIGNvbmZ1c2VkIGJ5IHRoZSBuZWVkIHRvCj4+IGNoZWNrIGFnYWluc3QgZWQtPm5l bmdpbmVzIGJvdGggaW4gdGhlIGdldHRlciBhbmQgaW4gdGhlIG5leHQgaGVscGVyLiBKdXN0Cj4+ IG5lZWQgdG8gaW5pdCBlZC0+Y3VycmVudF9lbmdpbmUgdG8gdGhlIGZpcnN0IG9uZSBpbiBpbml0 X2VuZ2luZV9saXN0IEkKPj4gdGhpbmsuCj4gCj4gSW4gdGhlIHByZXZpb3VzIHBhdGNoIHRoZXJl IHdhcyBhbiB1bnJlZmluZWQgbWlzdGFrZToKPiBlZC0+Y3VycmVudF9lbmdpbmUgd2FzIGluaXRp YWxpemVkIGluIHRoZQo+ICdpbnRlbF9pbml0X2VuZ2luZV9saXN0KCknIGZ1bmN0aW9uLgo+IAo+ IEJ1dCBiZWNhdXNlIHRoZXJlIGV2ZXJ5dGhpbmcgaXMgYWxsb2NhdGVkIGluIHN0YWNrLCB0aGUK PiAnJmVkLT5lbmdpbmVzWzBdJyBpcyBhbHNvIGluIHN0YWNrIHRoYXQgZ2V0IGZyZWVkIHdoZW4g dGhlCj4gZnVuY3Rpb24gcmV0dXJucywgd2l0aCB0aGUgcmVzdWx0IHRoYXQgSSBsb3NlIHJlZmVy ZW5jZS4KPiAKPiBGb3IgdGhpcywgSSB3b3VsZCBuZWVkIHRoZSBwb2ludGVyIHRvIGJlIGFzc2ln bmVkIHNvbWV3aGVyZSB0aGF0Cj4gd29ya3Mgd2l0aCB0aGUgYWRkcmVzc2VzIHByb3ZpZGVkIGJ5 IHRoZSBjYWxsZXIgYW5kIHRoaXMgbG9va3MKPiBsaWtlIHRoZSBiZXN0IHBsYWNlIGZvciBpdCAo aW5kZWVkIEkgcmVtb3ZlZCB0aGUgYXNzaWduZW1lbnQgZnJvbQo+IGludGVsX2luaXRfZW5naW5l X2xpc3QoKSkuCgpZb3UgYXJlIHJpZ2h0LCB5ZXAuCgo+IAo+Pj4gK3N0cnVjdCBpbnRlbF9leGVj dXRpb25fZW5naW5lMgo+Pj4gKyppbnRlbF9nZXRfY3VycmVudF9waHlzaWNhbF9lbmdpbmUoc3Ry dWN0IGludGVsX2VuZ2luZV9kYXRhICplZCkKPj4+ICt7Cj4+PiArCXN0cnVjdCBpbnRlbF9leGVj dXRpb25fZW5naW5lMiAqZTsKPj4+ICsKPj4+ICsJaWYgKGVkLT5uID49IGVkLT5uZW5naW5lcykK Pj4+ICsJCXJldHVybiBOVUxMOwo+Pgo+PiBDYW4gdGhpcyBiZSBoaXQ/IGludGVsX25leHRfZW5n aW5lIGxvb2tzIHRvIGJlIGF2b2lkaW5nIGluY3JlbWVudGluZyBwYXN0Cj4+IG5lbmdpbmVzIC0g MS4KPiAKPiB5ZXMsIHlvdSdyZSByaWdodCwgSSBkaWRuJ3Qgd2FudCB0byBoaXQgdGhlIGZvciBs b29wIGZvciB0aGlzCj4gY2FzZSB0aGF0IGNhbiBiZSBjaGVja2VkIGhlcmUsIGl0J3MgcmVkdW5k YW50LCBidXQgaXQgbG9va3MgbW9yZQo+IHJlYWRhYmxlLiBJJ2xsIHJlbW92ZSBpdC4KPiAKPj4+ ICsKPj4+ICsJaWYgKGlndF9vbmx5X2xpc3Rfc3VidGVzdHMoKSkKPj4+ICsJCWludGVsX25leHRf ZW5naW5lKGVkKTsKPj4KPj4gSW4gc3VidGVzdCBsaXN0aW5nIG1vZGUgdGhlcmUgY2Fubm90IGJl IHZpcnR1YWwgZW5naW5lcyBpbiB0aGUgbGlzdCBzbyBJCj4+IHRoaW5rIHRoaXMgYnJhbmNoIGlz IG5vdCBuZWVkZWQuCj4gCj4gWWVzLCBpbmRlZWQsIGlmIHdlIGhhdmUgdGhlIGxpc3Qgb2YgZW5n aW5lcyBhdCB0aGlzIHBvaW50LCBpdCdzCj4gb25seSBwaHlzaWNhbC4gSSdsbCByZW1vdmUgaXQu Cj4gCj4+PiArCQkJX19lMi0+bmFtZSAgICAgICA9IGUyLT5uYW1lOwo+Pj4gKwkJCV9fZTItPmlu c3RhbmNlICAgPSBlMi0+aW5zdGFuY2U7Cj4+PiArCQkJX19lMi0+Y2xhc3MgICAgICA9IGUyLT5j bGFzczsKPj4+ICsJCQlfX2UyLT5pc192aXJ0dWFsID0gZmFsc2U7Cj4+Cj4+IFlvdSBjb3VsZCB1 c2UgaW5pdF9lbmdpbmUgaGVyZSBidXQgZ3JhbnRlZCBpdCB3b3VsZCBoYXZlIHRvIGRvIGEgcmVk dW5kYW50Cj4+IG5hbWUgc2VhcmNoIHNvIG1heWJlIG5vdC4KPiAKPiB5ZXMsIHRoaXMgaXMgaG93 IGl0IGlzIHdhcyBkb25lIGF0IGZpcnN0LCBJIHB1dCBpdCBvdXRzaWRlIGZvcgo+IHRoZSByZWFz b24geW91IG1lbnRpb25lZCA6KQoKVGhhdCdzIGZpbmUuIE9rYXkgdGhlbiwganVzdCBvbmUgb3Ig dHdvIGRldGFpbHMgdG8gdXBkYXRlLgoKUmVnYXJkcywKClR2cnRrbwpfX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwppZ3QtZGV2IG1haWxpbmcgbGlzdAppZ3Qt ZGV2QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9t YWlsbWFuL2xpc3RpbmZvL2lndC1kZXY=