Re: [PATCH 1/1] Check gtidle before rc6 disable test

[Riana Tauro <riana.tauro@intel.com>]

Hi Soham

1) set your git config user.name. format should be first name followed 
by last

From: "Soham Purkait" <soham.purkait@intel.com>

2) you do not need a cover letter for a single patch

3) add a detailed commit message and the subject should follow
the format of other commits. check git log and follow the previous
commits

4) use "PATCH i-g-t" for igt patches
git format-patch --subject-prefix="PATCH i-g-t"

On 10/2/2024 12:42 AM, Soham Purkait wrote:
> From: "Purkait, Soham" <soham.purkait@intel.com>
> 
> ---
>   tests/intel/xe_oa.c | 4 +++-
>   1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/tests/intel/xe_oa.c b/tests/intel/xe_oa.c
> index 9be4fd633..6538d6323 100644
> --- a/tests/intel/xe_oa.c
> +++ b/tests/intel/xe_oa.c
> @@ -4644,8 +4644,10 @@ igt_main
>   			test_oa_unit_concurrent_oa_buffer_read();
>   	}
>   
> -	igt_subtest("rc6-disable")
> +	igt_subtest("rc6-disable"){
add space before {

Thanks,
Riana Tauro
> +		igt_require(xe_sysfs_gt_has_node(drm_fd, 0, "gtidle"));
>   		test_rc6_disable();
> +	}
>   
>   	igt_subtest_with_dynamic("stress-open-close") {
>   		__for_one_hwe_in_oag(hwe)