Re: [PATCH i-g-t v3 6/9] XE3: tests/intel/kms_draw_crc: fix x-tiled tests for case when there is no x-tile

["Pottumuttu, Sai Teja" <sai.teja.pottumuttu@intel.com>]

On 15-11-2024 00:33, Clint Taylor wrote:
> From: "Heikkila, Juha-pekka" <juha-pekka.heikkila@intel.com>
> 
> On Xe3 display no more support x-tile and will disable such framebuffers
> 
> Signed-off-by: Heikkila, Juha-pekka <juha-pekka.heikkila@intel.com>
> Signed-off-by: Clint Taylor <Clinton.A.Taylor@intel.com>
> ---
>   tests/intel/kms_draw_crc.c | 6 ++++--
>   1 file changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/tests/intel/kms_draw_crc.c b/tests/intel/kms_draw_crc.c
> index e3d1c0ba9..3084e9c9b 100644
> --- a/tests/intel/kms_draw_crc.c
> +++ b/tests/intel/kms_draw_crc.c
> @@ -243,8 +243,10 @@ static void fill_fb_subtest(void)
>   	get_fill_crc(DRM_FORMAT_MOD_LINEAR, &crc);
>   	igt_assert_crc_equal(&crc, &base_crc);
>   
> -	get_fill_crc(I915_FORMAT_MOD_X_TILED, &crc);
> -	igt_assert_crc_equal(&crc, &base_crc);
> +	if (intel_display_ver(intel_get_drm_devid(drm_fd)) <= 20) {

In the kernel, we now have,

{
   .modifier = I915_FORMAT_MOD_X_TILED,
   .display_ver = { 0, 29 },
   .plane_caps = INTEL_PLANE_CAP_TILING_X,
}

So, we should probably change the condition here as well to

if (intel_display_ver(intel_get_drm_devid(drm_fd)) < 30)

Thanks
Sai Teja


> +		get_fill_crc(I915_FORMAT_MOD_X_TILED, &crc);
> +		igt_assert_crc_equal(&crc, &base_crc);
> +	}
>   
>   	if (intel_display_ver(intel_get_drm_devid(drm_fd)) >= 9) {
>   		get_fill_crc(has_4tile ?