Re: [PATCH i-g-t 1/1] tests/intel/xe_exec_sip_eudebug: disable some tests on VF

["Manszewski, Christoph" <christoph.manszewski@intel.com>]

Hi Jan,

On 28.03.2025 09:19, Jan Sokolowski wrote:
> Tests wait-writesip-nodebug and breakpoint-writesip-nodebug
> were found to be incompatible with SR-IOV functionality, and
> should only be available to run if on PF.
> 
> Disable these tests if ran on VF.

As Łukasz mentioned, the toggle is not available for VFs. I think the 
proper fix would be something like:

```
bool xe_eudebug_enable(int fd, bool enable)
         bool old = false;
         int ret = __xe_eudebug_enable_getset(fd, &old, &enable);

-       if (ret) {
-               igt_skip_on(enable);
-               old = false;
-       }
+       igt_skip_on(ret);

         return old;
  }
```

That way if there is no eudebug in the KMD we will just skip it and it 
won't matter if it is not there because of not being compiled in or if 
it's in VF mode.

Regards,
Christoph

> 
> Signed-off-by: Jan Sokolowski <jan.sokolowski@intel.com>
> Cc: Katarzyna Piecielska <katarzyna.piecielska@intel.com>
> Cc: Lukasz Laguna <lukasz.laguna@intel.com>
> Cc: Christoph Manszewski <christoph.manszewski@intel.com>
> ---
>   tests/intel/xe_exec_sip_eudebug.c | 2 ++
>   1 file changed, 2 insertions(+)
> 
> diff --git a/tests/intel/xe_exec_sip_eudebug.c b/tests/intel/xe_exec_sip_eudebug.c
> index c317112b4..26b3f9176 100644
> --- a/tests/intel/xe_exec_sip_eudebug.c
> +++ b/tests/intel/xe_exec_sip_eudebug.c
> @@ -22,6 +22,7 @@
>   #include "xe/xe_eudebug.h"
>   #include "xe/xe_ioctl.h"
>   #include "xe/xe_query.h"
> +#include "lib/igt_sriov_device.h"
>   
>   #define WIDTH 64
>   #define HEIGHT 64
> @@ -316,6 +317,7 @@ igt_main
>   		igt_fixture {
>   			was_enabled = xe_eudebug_enable(fd, false);
>   			igt_require(!xe_eudebug_debugger_available(fd));
> +			igt_skip_on(intel_is_vf_device(fd));
>   		}
>   
>   		test_render_and_compute("wait-writesip-nodebug", fd, eci)