From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by gabe.freedesktop.org (Postfix) with ESMTPS id 6BE3310E5B4 for ; Thu, 11 May 2023 07:51:16 +0000 (UTC) Message-ID: <575087db-30d4-e9d7-8ed0-529c651e3e53@linux.intel.com> Date: Thu, 11 May 2023 08:50:58 +0100 MIME-Version: 1.0 Content-Language: en-US To: Umesh Nerlige Ramappa References: <20230506005528.1890922-1-umesh.nerlige.ramappa@intel.com> <20230506005528.1890922-16-umesh.nerlige.ramappa@intel.com> <04a7f10e-99ff-e1cd-0fe7-6f63d9e896d0@linux.intel.com> From: Tvrtko Ursulin In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Subject: Re: [igt-dev] [PATCH i-g-t 15/15] intel_gpu_top: Add gt specific values to header in interactive mode List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: igt-dev@lists.freedesktop.org Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" List-ID: On 10/05/2023 23:14, Umesh Nerlige Ramappa wrote: > On Wed, May 10, 2023 at 09:46:53AM +0100, Tvrtko Ursulin wrote: >> >> On 06/05/2023 01:55, Umesh Nerlige Ramappa wrote: >>> If -p options is specified in INTERACTIVE mode, show the gt specific >>> values. >>> >>> Signed-off-by: Umesh Nerlige Ramappa >>> --- >>>  tools/intel_gpu_top.c | 33 +++++++++++++++++++++++++-------- >>>  1 file changed, 25 insertions(+), 8 deletions(-) >>> >>> diff --git a/tools/intel_gpu_top.c b/tools/intel_gpu_top.c >>> index 0acc81e9e..7018499c7 100644 >>> --- a/tools/intel_gpu_top.c >>> +++ b/tools/intel_gpu_top.c >>> @@ -1988,14 +1988,31 @@ print_header(const struct igt_device_card *card, >>>      lines = print_header_token(" @ ", lines, con_w, con_h, &rem, >>>                     "%s", card->card); >>> -    lines = print_header_token(" - ", lines, con_w, con_h, &rem, >>> -                   "%s/%s MHz", >>> -                   freq_items[1].buf, >>> -                   freq_items[0].buf); >>> - >>> -    lines = print_header_token("; ", lines, con_w, con_h, &rem, >>> -                   "%s%% RC6", >>> -                   rc6_items[0].buf); >>> +    if (class_view || engines->num_gts == 1) { >>> +        lines = print_header_token(" - ", lines, con_w, con_h, &rem, >>> +                       "%s/%s MHz", >>> +                       freq_items[1].buf, >>> +                       freq_items[0].buf); >>> + >>> +        lines = print_header_token("; ", lines, con_w, con_h, &rem, >>> +                       "%s%% RC6", >>> +                       rc6_items[0].buf); >>> +    } else { >>> +        for (i = 0; i < engines->num_gts; i++) { >>> +            const char *cont = !i ? " - ": "; "; >>> + >>> +            lines = print_header_token(cont, lines, con_w, con_h, &rem, >>> +                           "%s/%s MHz(gt%d)", >>> +                           freq_items_gt[i * 4 + 1].buf, >>> +                           freq_items_gt[i * 4 + 0].buf, >>> +                           i); >>> + >>> +            lines = print_header_token("; ", lines, con_w, con_h, &rem, >>> +                           "%s%% RC6(gt%d)", >>> +                           rc6_items_gt[i * 3].buf, >>> +                           i); >>> +        } >>> +    } >>>      if (engines->r_gpu.present) { >>>          lines = print_header_token("; ", lines, con_w, con_h, >> >> Series was a super easy read, thanks for that! Pretty much r-b for the >> lot from me but I would just like to visualize how the output looks >> like first. Would you mind pasting some examples for all the modes? > > great, I am attaching the outputs in text files for MTL and DG2 here, > hope that is visible. If not, I can paste it in pastebin. > > MTL shows the gt specific changes. DG2 is single tile, so there are no > changes. Thank you, looks solid. Only thing I would change is use uppercase GTn in the interactive output, so it matches with -l and -c. Is it also doable to make the formatting of those labels match like "MHz GT0", or "GT0 MHz"? Regards, Tvrtko