From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.20]) by gabe.freedesktop.org (Postfix) with ESMTPS id C780A10E106 for ; Thu, 30 Nov 2023 15:00:37 +0000 (UTC) Message-ID: <57854b8e-adda-46a6-bf95-327c98fa7486@intel.com> Date: Thu, 30 Nov 2023 15:00:32 +0000 MIME-Version: 1.0 Content-Language: en-GB To: Kamil Konieczny , igt-dev@lists.freedesktop.org, Pallavi Mishra , Francois Dugast References: <20231130111735.435263-1-matthew.auld@intel.com> <20231130111735.435263-2-matthew.auld@intel.com> <20231130135556.crdwx3uzgmcym5qo@kamilkon-desk.igk.intel.com> From: Matthew Auld In-Reply-To: <20231130135556.crdwx3uzgmcym5qo@kamilkon-desk.igk.intel.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [igt-dev] [PATCH i-g-t 2/2] tests/intel-ci/xe-fast-feedback: add create-invalid-mbz List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" List-ID: On 30/11/2023 13:55, Kamil Konieczny wrote: > Hi Matthew, > On 2023-11-30 at 11:17:35 +0000, Matthew Auld wrote: >> Ensure we have some coverage in BAT for gem_create MBZ fields. >> >> Signed-off-by: Matthew Auld >> Cc: Pallavi Mishra >> Cc: Francois Dugast >> --- >> tests/intel-ci/xe-fast-feedback.testlist | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/tests/intel-ci/xe-fast-feedback.testlist b/tests/intel-ci/xe-fast-feedback.testlist >> index 5c53e249d..a83c17de7 100644 >> --- a/tests/intel-ci/xe-fast-feedback.testlist >> +++ b/tests/intel-ci/xe-fast-feedback.testlist >> @@ -2,6 +2,7 @@ >> igt@xe_module_load@load >> >> igt@xe_compute@compute-square >> +igt@xe_create@create-invalid-mbz > > Please move it before @create-massive-size, > it should be sorted alphabetically. Ok, I didn't realise that was a requirement. I can move it. Note that there are a bunch of tests in this list not following any kind of alphabetical sorting, but is more ordered/grouped/structured by functionality, which I think makes more sense IMO. Like here create-invalid-mbz is just a really simple sanity check for gem_create so running it first made sense to me. A better example is maybe xe_vm@shared-*, since for that it makes sense to run the pte subtest first, with every next test being the next level up in the paging structures: igt@xe_vm@shared-pte-page igt@xe_vm@shared-pde-page igt@xe_vm@shared-pde2-page igt@xe_vm@shared-pde3-page So here it rather ordered by functionally. Anyway, I think if we intend to sort this alphabetically we should put a comment at the top of the file or something, and then also send a patch to sort everything? > > Regards, > Kamil > >> igt@xe_create@create-execqueues-noleak >> igt@xe_create@create-execqueues-leak >> igt@xe_create@create-massive-size >> -- >> 2.43.0 >>